From: Asmaa Mnebhi <asmaa@nvidia.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>
Subject: RE: [PATCH v3 2/2] Support NVIDIA BlueField-3 pinctrl driver
Date: Thu, 16 Feb 2023 19:26:47 +0000 [thread overview]
Message-ID: <CH2PR12MB3895B9BC684751BFA25B4B08D7A09@CH2PR12MB3895.namprd12.prod.outlook.com> (raw)
In-Reply-To: <Y+57wasEo/CLHakK@smile.fi.intel.com>
-----Original Message-----
From: Andy Shevchenko <andriy.shevchenko@intel.com>
Sent: Thursday, February 16, 2023 1:54 PM
To: Asmaa Mnebhi <asmaa@nvidia.com>
Cc: linux-gpio@vger.kernel.org; linux-kernel@vger.kernel.org; linux-acpi@vger.kernel.org
Subject: Re: [PATCH v3 2/2] Support NVIDIA BlueField-3 pinctrl driver
Importance: High
On Thu, Feb 16, 2023 at 06:44:58PM +0000, Asmaa Mnebhi wrote:
> > > +config PINCTRL_MLXBF
> > > + tristate "NVIDIA BlueField-3 SoC Pinctrl driver"
> > > + depends on (MELLANOX_PLATFORM && ARM64 && ACPI)
> >
> > This is wrong.
> > Please make sure you cover more testing.
> > Also, do you really need an ACPI dependency?
> >
> > Could you please provide more details on why this is wrong? All our
> > upstreamed drivers use the same "depends on" Our pinctrl driver only
> > applies to Mellanox platforms, ARM64 and use ACPI tables.
>
> This is wrong because it narrows down testing coverage.
>
> Besides that you need to define functional and build dependencies separately.
>
> ACPI probably is not what you are using in the driver. I do not
> believe you have at all dependency on it.
>
> Noted, I will define function and build dependencies separately.
> We have our own custom UEFI for BlueField SoCs so ACPI tables are our
> only options (for users/customer etc... as well)
I understand that, but I'm pretty sure that driver can be compiled with ACPI=n which is good for testing coverage.
Ah! OK, understood. Will remove it then.
next prev parent reply other threads:[~2023-02-16 19:26 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 15:39 [PATCH v3 0/2] Add NVIDIA BlueField-3 GPIO driver and pin controller Asmaa Mnebhi
2023-02-10 15:39 ` [PATCH v3 1/2] Support NVIDIA BlueField-3 GPIO controller Asmaa Mnebhi
2023-02-11 7:37 ` kernel test robot
2023-02-11 11:51 ` Andy Shevchenko
2023-02-13 23:14 ` Asmaa Mnebhi
2023-02-13 23:39 ` andy.shevchenko
2023-02-10 15:39 ` [PATCH v3 2/2] Support NVIDIA BlueField-3 pinctrl driver Asmaa Mnebhi
2023-02-11 11:55 ` Andy Shevchenko
2023-02-16 17:50 ` Asmaa Mnebhi
2023-02-16 18:38 ` Andy Shevchenko
2023-02-16 18:44 ` Asmaa Mnebhi
2023-02-16 18:53 ` Andy Shevchenko
2023-02-16 19:26 ` Asmaa Mnebhi [this message]
2023-02-11 11:58 ` [PATCH v3 0/2] Add NVIDIA BlueField-3 GPIO driver and pin controller Andy Shevchenko
2023-02-17 21:26 ` [PATCH v4 0/2] Support Nvidia " Asmaa Mnebhi
2023-02-17 21:26 ` [PATCH v4 1/2] gpio: gpio-mlxbf3: Add gpio driver support Asmaa Mnebhi
2023-02-17 23:07 ` Andy Shevchenko
2023-02-22 18:40 ` Asmaa Mnebhi
2023-02-23 11:06 ` Andy Shevchenko
2023-02-23 19:08 ` Asmaa Mnebhi
2023-02-23 19:58 ` Andy Shevchenko
2023-02-23 22:51 ` Asmaa Mnebhi
2023-02-24 9:47 ` Andy Shevchenko
2023-02-24 14:42 ` Asmaa Mnebhi
2023-02-24 15:12 ` Andy Shevchenko
2023-02-24 15:59 ` Asmaa Mnebhi
2023-02-24 15:13 ` Andy Shevchenko
2023-02-24 15:14 ` Andy Shevchenko
2023-02-18 1:05 ` kernel test robot
2023-02-23 12:29 ` Linus Walleij
2023-02-17 21:26 ` [PATCH v4 2/2] pinctrl: pinctrl-mlxbf: Add pinctrl " Asmaa Mnebhi
2023-02-17 23:24 ` Andy Shevchenko
2023-02-23 21:07 ` Asmaa Mnebhi
2023-02-24 9:44 ` Andy Shevchenko
2023-03-14 20:30 ` Asmaa Mnebhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH2PR12MB3895B9BC684751BFA25B4B08D7A09@CH2PR12MB3895.namprd12.prod.outlook.com \
--to=asmaa@nvidia.com \
--cc=andriy.shevchenko@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).