* [PATCH v2] iio: dps310: Add ACPI HID table
@ 2022-01-27 14:38 Kai-Heng Feng
2022-01-27 16:22 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Kai-Heng Feng @ 2022-01-27 14:38 UTC (permalink / raw)
To: jic23, eajames
Cc: andy.shevchenko, Kai-Heng Feng, Lars-Peter Clausen, linux-iio,
linux-kernel
x86 boards may use ACPI HID "IFX3100" for dps310 device.
Vendor told us feel free to add the ID and contact
"Saumitra.Chafekar@infineon.com" for any further question.
So add an ACPI match table for that accordingly.
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
---
v2:
- Drop ACPI_PTR().
- Add info from vendor.
drivers/iio/pressure/dps310.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/iio/pressure/dps310.c b/drivers/iio/pressure/dps310.c
index 0730380ceb692..7e6fcb32212a2 100644
--- a/drivers/iio/pressure/dps310.c
+++ b/drivers/iio/pressure/dps310.c
@@ -812,9 +812,17 @@ static const struct i2c_device_id dps310_id[] = {
};
MODULE_DEVICE_TABLE(i2c, dps310_id);
+static const struct acpi_device_id dps310_acpi_match[] = {
+ { "IFX3100" },
+ { },
+};
+
+MODULE_DEVICE_TABLE(acpi, dps310_acpi_match);
+
static struct i2c_driver dps310_driver = {
.driver = {
.name = DPS310_DEV_NAME,
+ .acpi_match_table = dps310_acpi_match,
},
.probe = dps310_probe,
.id_table = dps310_id,
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] iio: dps310: Add ACPI HID table
2022-01-27 14:38 [PATCH v2] iio: dps310: Add ACPI HID table Kai-Heng Feng
@ 2022-01-27 16:22 ` Andy Shevchenko
2022-01-27 16:23 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2022-01-27 16:22 UTC (permalink / raw)
To: Kai-Heng Feng
Cc: Jonathan Cameron, Eddie James, Lars-Peter Clausen, linux-iio,
Linux Kernel Mailing List
On Thu, Jan 27, 2022 at 4:38 PM Kai-Heng Feng
<kai.heng.feng@canonical.com> wrote:
>
> x86 boards may use ACPI HID "IFX3100" for dps310 device.
the dps310
> Vendor told us feel free to add the ID and contact
> "Saumitra.Chafekar@infineon.com" for any further question.
questions
> So add an ACPI match table for that accordingly.
I have checked the official PNP registry and may confirm IFX is for
Infineon, since they are aware
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Thanks for all your efforts, appreciate it!
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> ---
> v2:
> - Drop ACPI_PTR().
> - Add info from vendor.
>
> drivers/iio/pressure/dps310.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/iio/pressure/dps310.c b/drivers/iio/pressure/dps310.c
> index 0730380ceb692..7e6fcb32212a2 100644
> --- a/drivers/iio/pressure/dps310.c
> +++ b/drivers/iio/pressure/dps310.c
> @@ -812,9 +812,17 @@ static const struct i2c_device_id dps310_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, dps310_id);
>
> +static const struct acpi_device_id dps310_acpi_match[] = {
> + { "IFX3100" },
> + { },
> +};
> +
This is redundant, I hope Jonathan may remove it when applying.
> +MODULE_DEVICE_TABLE(acpi, dps310_acpi_match);
> +
> static struct i2c_driver dps310_driver = {
> .driver = {
> .name = DPS310_DEV_NAME,
> + .acpi_match_table = dps310_acpi_match,
> },
> .probe = dps310_probe,
> .id_table = dps310_id,
> --
> 2.33.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] iio: dps310: Add ACPI HID table
2022-01-27 16:22 ` Andy Shevchenko
@ 2022-01-27 16:23 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2022-01-27 16:23 UTC (permalink / raw)
To: Kai-Heng Feng
Cc: Jonathan Cameron, Eddie James, Lars-Peter Clausen, linux-iio,
Linux Kernel Mailing List
On Thu, Jan 27, 2022 at 6:22 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Thu, Jan 27, 2022 at 4:38 PM Kai-Heng Feng
> <kai.heng.feng@canonical.com> wrote:
...
> > +static const struct acpi_device_id dps310_acpi_match[] = {
> > + { "IFX3100" },
> > + { },
And no comma needed here.
> > +};
>
> > +
>
> This is redundant, I hope Jonathan may remove it when applying.
>
> > +MODULE_DEVICE_TABLE(acpi, dps310_acpi_match);
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-27 16:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-27 14:38 [PATCH v2] iio: dps310: Add ACPI HID table Kai-Heng Feng
2022-01-27 16:22 ` Andy Shevchenko
2022-01-27 16:23 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).