From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Hans de Goede <hdegoede@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] software node: Add software_node_find_by_name()
Date: Thu, 15 Aug 2019 15:55:40 +0300 [thread overview]
Message-ID: <CAHp75VduJ2VQ-4r-vrARMyL6WAnsppwMtLRD-g4f-GEnew8m2g@mail.gmail.com> (raw)
In-Reply-To: <20190815112826.81785-2-heikki.krogerus@linux.intel.com>
On Thu, Aug 15, 2019 at 2:32 PM Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> Function that searches software nodes by node name.
> +/**
> + * software_node_find_by_name - Find software node by name
> + * @parent: Parent of the software node
> + * @name: Name of the software node
> + *
> + * The function will find a node that is child of @parent and that is named
> + * @name. If no node is found, the function returns NULL.
Shouldn't we add that the caller responsible of putting kobject?
> + */
> +const struct software_node *
> +software_node_find_by_name(const struct software_node *parent, const char *name)
> +{
> + struct swnode *swnode;
> + struct kobject *k;
> +
> + if (!name)
> + return NULL;
> +
> + spin_lock(&swnode_kset->list_lock);
> +
> + list_for_each_entry(k, &swnode_kset->list, entry) {
> + swnode = kobj_to_swnode(k);
> + if (parent == swnode->node->parent && swnode->node->name &&
> + !strcmp(name, swnode->node->name)) {
> + kobject_get(&swnode->kobj);
> + break;
> + }
> + swnode = NULL;
> + }
> +
> + spin_unlock(&swnode_kset->list_lock);
> +
> + return swnode ? swnode->node : NULL;
> +}
> +EXPORT_SYMBOL_GPL(software_node_find_by_name);
> +
> static int
> software_node_register_properties(struct software_node *node,
> const struct property_entry *properties)
> diff --git a/include/linux/property.h b/include/linux/property.h
> index 5a910ad79591..9b3d4ca3a73a 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -421,6 +421,10 @@ bool is_software_node(const struct fwnode_handle *fwnode);
> const struct software_node *to_software_node(struct fwnode_handle *fwnode);
> struct fwnode_handle *software_node_fwnode(const struct software_node *node);
>
> +const struct software_node *
> +software_node_find_by_name(const struct software_node *parent,
> + const char *name);
> +
> int software_node_register_nodes(const struct software_node *nodes);
> void software_node_unregister_nodes(const struct software_node *nodes);
>
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2019-08-15 12:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 11:28 [PATCH 0/3] software node: Introduce software_node_find_by_name() Heikki Krogerus
2019-08-15 11:28 ` [PATCH 1/3] software node: Add software_node_find_by_name() Heikki Krogerus
2019-08-15 12:55 ` Andy Shevchenko [this message]
2019-08-15 13:33 ` Heikki Krogerus
2019-08-15 11:28 ` [PATCH 2/3] usb: roles: intel_xhci: Supplying software node for the role mux Heikki Krogerus
2019-08-15 12:57 ` Andy Shevchenko
2019-08-15 11:28 ` [PATCH 3/3] platform/x86: intel_cht_int33fe: Use new API to gain access to the role switch Heikki Krogerus
2019-08-15 12:53 ` Andy Shevchenko
2019-08-15 19:16 ` [PATCH 0/3] software node: Introduce software_node_find_by_name() Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VduJ2VQ-4r-vrARMyL6WAnsppwMtLRD-g4f-GEnew8m2g@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).