linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Darren Hart <dvhart@infradead.org>,
	Andy Shevchenko <andy@infradead.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] usb: roles: intel_xhci: Supplying software node for the role mux
Date: Thu, 15 Aug 2019 15:57:02 +0300	[thread overview]
Message-ID: <CAHp75Ve6PXtP3D94B1iDB5TcO6etqX9uCrQ7HSn1wSes-B3FPQ@mail.gmail.com> (raw)
In-Reply-To: <20190815112826.81785-3-heikki.krogerus@linux.intel.com>

On Thu, Aug 15, 2019 at 2:28 PM Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> The primary purpose for this node will be to allow linking
> the users of the switch to it. The users will be for example
> USB Type-C connectors. By supplying a reference to this
> node in the software nodes representing the USB Type-C
> controllers or connectors, the drivers for those devices can
> access the switch.

> -static const struct usb_role_switch_desc sw_desc = {
> +static struct usb_role_switch_desc sw_desc = {

I dunno what is better, but usual approach I'm using in other drivers
is to kmemdup() input constant structures in order to have originals
untouched.

-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2019-08-15 12:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-15 11:28 [PATCH 0/3] software node: Introduce software_node_find_by_name() Heikki Krogerus
2019-08-15 11:28 ` [PATCH 1/3] software node: Add software_node_find_by_name() Heikki Krogerus
2019-08-15 12:55   ` Andy Shevchenko
2019-08-15 13:33     ` Heikki Krogerus
2019-08-15 11:28 ` [PATCH 2/3] usb: roles: intel_xhci: Supplying software node for the role mux Heikki Krogerus
2019-08-15 12:57   ` Andy Shevchenko [this message]
2019-08-15 11:28 ` [PATCH 3/3] platform/x86: intel_cht_int33fe: Use new API to gain access to the role switch Heikki Krogerus
2019-08-15 12:53   ` Andy Shevchenko
2019-08-15 19:16 ` [PATCH 0/3] software node: Introduce software_node_find_by_name() Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHp75Ve6PXtP3D94B1iDB5TcO6etqX9uCrQ7HSn1wSes-B3FPQ@mail.gmail.com \
    --to=andy.shevchenko@gmail.com \
    --cc=andy@infradead.org \
    --cc=dvhart@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).