[PATCH] x86/intel_mid_thermal: Fix suspend handlers unused warning

[PATCH] x86/intel_mid_thermal: Fix suspend handlers unused warning

[Borislav Petkov]

From: Borislav Petkov <bp@suse.de>

Fix:

  drivers/platform/x86/intel_mid_thermal.c:424:12: warning: ‘mid_thermal_resume’
  defined but not used [-Wunused-function]
   static int mid_thermal_resume(struct device *dev)
              ^
  drivers/platform/x86/intel_mid_thermal.c:436:12: warning: ‘mid_thermal_suspend’
  defined but not used [-Wunused-function]
   static int mid_thermal_suspend(struct device *dev)
              ^

which I see during randbuilds here.

Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: Darren Hart <dvhart@infradead.org>
Cc: platform-driver-x86@vger.kernel.org
---
 drivers/platform/x86/intel_mid_thermal.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/platform/x86/intel_mid_thermal.c b/drivers/platform/x86/intel_mid_thermal.c
index 9f713b832ba3..0df3c9d37509 100644
--- a/drivers/platform/x86/intel_mid_thermal.c
+++ b/drivers/platform/x86/intel_mid_thermal.c
@@ -415,6 +415,7 @@ static struct thermal_device_info *initialize_sensor(int index)
 	return td_info;
 }
 
+#ifdef CONFIG_PM_SLEEP
 /**
  * mid_thermal_resume - resume routine
  * @dev: device structure
@@ -442,6 +443,7 @@ static int mid_thermal_suspend(struct device *dev)
 	 */
 	return configure_adc(0);
 }
+#endif
 
 static SIMPLE_DEV_PM_OPS(mid_thermal_pm,
 			 mid_thermal_suspend, mid_thermal_resume);
-- 
2.10.0

Re: [PATCH] x86/intel_mid_thermal: Fix suspend handlers unused warning

[Andy Shevchenko]

On Sat, Nov 26, 2016 at 6:01 PM, Borislav Petkov <bp@alien8.de> wrote:
> From: Borislav Petkov <bp@suse.de>
>
> Fix:
>
>   drivers/platform/x86/intel_mid_thermal.c:424:12: warning: ‘mid_thermal_resume’
>   defined but not used [-Wunused-function]
>    static int mid_thermal_resume(struct device *dev)
>               ^
>   drivers/platform/x86/intel_mid_thermal.c:436:12: warning: ‘mid_thermal_suspend’
>   defined but not used [-Wunused-function]
>    static int mid_thermal_suspend(struct device *dev)
>               ^
>
> which I see during randbuilds here.

Thanks!
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Darren Hart <dvhart@infradead.org>
> Cc: platform-driver-x86@vger.kernel.org
> ---
>  drivers/platform/x86/intel_mid_thermal.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/platform/x86/intel_mid_thermal.c b/drivers/platform/x86/intel_mid_thermal.c
> index 9f713b832ba3..0df3c9d37509 100644
> --- a/drivers/platform/x86/intel_mid_thermal.c
> +++ b/drivers/platform/x86/intel_mid_thermal.c
> @@ -415,6 +415,7 @@ static struct thermal_device_info *initialize_sensor(int index)
>         return td_info;
>  }
>
> +#ifdef CONFIG_PM_SLEEP
>  /**
>   * mid_thermal_resume - resume routine
>   * @dev: device structure
> @@ -442,6 +443,7 @@ static int mid_thermal_suspend(struct device *dev)
>          */
>         return configure_adc(0);
>  }
> +#endif
>
>  static SIMPLE_DEV_PM_OPS(mid_thermal_pm,
>                          mid_thermal_suspend, mid_thermal_resume);
> --
> 2.10.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe platform-driver-x86" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
With Best Regards,
Andy Shevchenko