From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Trent Piepho <tpiepho@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
Daniel Latypov <dlatypov@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andy@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Oskar Schirmer <oskar@scara.com>, Yiyuan Guo <yguoaz@gmail.com>
Subject: Re: [PATCH] lib/math/rational.c: Fix divide by zero
Date: Tue, 25 May 2021 15:03:15 +0300 [thread overview]
Message-ID: <CAHp75VeNvp2NHORiN-X+ohYdvLmADYBEOJ2_0+-eOZ+kznA_FQ@mail.gmail.com> (raw)
In-Reply-To: <CA+7tXihtuzw3+7boMFqmvHcpe-hr2qF0TnaduskbXUbfsFwb=A@mail.gmail.com>
On Tue, May 25, 2021 at 12:21 PM Trent Piepho <tpiepho@gmail.com> wrote:
> On Tue, May 25, 2021 at 2:02 AM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> >
> > On Mon, May 24, 2021 at 01:17:48PM -0700, Trent Piepho wrote:
> > > On Mon, May 24, 2021 at 3:51 AM Andy Shevchenko
> > > <andriy.shevchenko@intel.com> wrote:
> > > > On Sat, May 22, 2021 at 05:18:06PM -0700, Trent Piepho wrote:
> > > >
> > > > This misses the test cases (*). Please, develop them with Daniel.
> > > >
> > > > *) We usually don't accept changes in the generic libraries without test cases.
> > > >
> > > > Fixes tag?
> > >
> > > Is there a bug report on a tracker? I just got the email from Yigua.
> >
> > Fixes tag refers to the existing commit that brought the bug.
> > Also you may need to add Reported-by tag since Yigua reported it.
>
> I did add a Reported-by tag.
Oh, I haven't seen it in the context left, but yes, I see it in the
original mail, thanks!
> Wasn't clear to me fixing a specific
> commit was entirely appropriate since not handling out of range values
> correctly has been there all along.
Daniel proposed one, wouldn't it be good enough?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-05-25 12:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-23 0:18 [PATCH] lib/math/rational.c: Fix divide by zero Trent Piepho
2021-05-24 10:51 ` Andy Shevchenko
2021-05-24 16:55 ` Daniel Latypov
2021-05-24 22:04 ` Randy Dunlap
2021-05-24 22:56 ` Daniel Latypov
2021-05-24 23:30 ` Randy Dunlap
2021-05-24 23:38 ` Daniel Latypov
2021-05-25 0:42 ` David Gow
2021-05-25 1:49 ` Randy Dunlap
2021-05-25 1:57 ` David Gow
2021-05-25 5:08 ` Trent Piepho
2021-05-24 20:17 ` Trent Piepho
2021-05-24 20:35 ` Daniel Latypov
2021-05-25 9:02 ` Andy Shevchenko
2021-05-25 9:21 ` Trent Piepho
2021-05-25 12:03 ` Andy Shevchenko [this message]
2021-05-25 17:10 ` Daniel Latypov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeNvp2NHORiN-X+ohYdvLmADYBEOJ2_0+-eOZ+kznA_FQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlatypov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oskar@scara.com \
--cc=tpiepho@gmail.com \
--cc=yguoaz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).