From: Trent Piepho <tpiepho@gmail.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: David Gow <davidgow@google.com>,
Daniel Latypov <dlatypov@google.com>,
Brendan Higgins <brendanhiggins@google.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
andy@kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Oskar Schirmer <oskar@scara.com>, Yiyuan Guo <yguoaz@gmail.com>
Subject: Re: [PATCH] lib/math/rational.c: Fix divide by zero
Date: Mon, 24 May 2021 22:08:27 -0700 [thread overview]
Message-ID: <CA+7tXihZZy8i48aLAKAPptFc3Ktggve3V-8b1ugB9Ch1khMOJQ@mail.gmail.com> (raw)
In-Reply-To: <caaab2dd-b1b6-b105-6b2f-9a2bc8438a82@infradead.org>
On Mon, May 24, 2021 at 6:49 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> > Personally, I think that RATIONAL is probably an okay thing to select
> > here: it's not as heavyweight as drivers/filesystems/etc, and our
> > general guidance here is "avoid select where sensible to do so", not
> > "don't use it under any circumstances".
>
> RATIONAL does not have a prompt string, so depending on it would not
> be reliable. I.e., it is meant to be selected.
Yes, there are no out of tree or userspace users of it. The only
possible way to use it, is if some code in the kernel uses it. So
that code can select it.
If it could be used by out of tree modules, then there should be an
entry for it, like some of the compression and crc routines got so
they could be turned on for out of tree modules when nothing in the
kernel config used them.
next prev parent reply other threads:[~2021-05-25 5:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-23 0:18 [PATCH] lib/math/rational.c: Fix divide by zero Trent Piepho
2021-05-24 10:51 ` Andy Shevchenko
2021-05-24 16:55 ` Daniel Latypov
2021-05-24 22:04 ` Randy Dunlap
2021-05-24 22:56 ` Daniel Latypov
2021-05-24 23:30 ` Randy Dunlap
2021-05-24 23:38 ` Daniel Latypov
2021-05-25 0:42 ` David Gow
2021-05-25 1:49 ` Randy Dunlap
2021-05-25 1:57 ` David Gow
2021-05-25 5:08 ` Trent Piepho [this message]
2021-05-24 20:17 ` Trent Piepho
2021-05-24 20:35 ` Daniel Latypov
2021-05-25 9:02 ` Andy Shevchenko
2021-05-25 9:21 ` Trent Piepho
2021-05-25 12:03 ` Andy Shevchenko
2021-05-25 17:10 ` Daniel Latypov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+7tXihZZy8i48aLAKAPptFc3Ktggve3V-8b1ugB9Ch1khMOJQ@mail.gmail.com \
--to=tpiepho@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=dlatypov@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oskar@scara.com \
--cc=rdunlap@infradead.org \
--cc=yguoaz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).