* [PATCH] platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items
@ 2018-09-26 5:21 Nathan Chancellor
2018-09-26 7:43 ` Vadim Pasternak
0 siblings, 1 reply; 3+ messages in thread
From: Nathan Chancellor @ 2018-09-26 5:21 UTC (permalink / raw)
To: Vadim Pasternak, Darren Hart, Andy Shevchenko
Cc: platform-driver-x86, linux-kernel, Nathan Chancellor
Clang warns that mlxplat_mlxcpld_msn201x_items is not going to be
emitted in the final assembly because it's only used in ARRAY_SIZE right
now, which is a compile time evaluation since the array's size is known.
drivers/platform/x86/mlx-platform.c:555:32: warning: variable
'mlxplat_mlxcpld_msn201x_items' is not needed and will not be emitted
[-Wunneeded-internal-declaration]
static struct mlxreg_core_item mlxplat_mlxcpld_msn201x_items[] = {
^
1 warning generated.
It appears this was a copy and paste mistake from when this item was
first added. Use the definition in mlxplat_mlxcpld_msn201x_data so that
Clang no longer warns.
Link: https://github.com/ClangBuiltLinux/linux/issues/141
Fixes: a49a41482f61 ("platform/x86: mlx-platform: Add support for new msn201x system type")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/platform/x86/mlx-platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
index d89936c93ba0..c2c3a1a19879 100644
--- a/drivers/platform/x86/mlx-platform.c
+++ b/drivers/platform/x86/mlx-platform.c
@@ -575,7 +575,7 @@ static struct mlxreg_core_item mlxplat_mlxcpld_msn201x_items[] = {
static
struct mlxreg_core_hotplug_platform_data mlxplat_mlxcpld_msn201x_data = {
- .items = mlxplat_mlxcpld_msn21xx_items,
+ .items = mlxplat_mlxcpld_msn201x_items,
.counter = ARRAY_SIZE(mlxplat_mlxcpld_msn201x_items),
.cell = MLXPLAT_CPLD_LPC_REG_AGGR_OFFSET,
.mask = MLXPLAT_CPLD_AGGR_MASK_DEF,
--
2.19.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items
2018-09-26 5:21 [PATCH] platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items Nathan Chancellor
@ 2018-09-26 7:43 ` Vadim Pasternak
2018-10-19 11:38 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Vadim Pasternak @ 2018-09-26 7:43 UTC (permalink / raw)
To: Nathan Chancellor, Darren Hart, Andy Shevchenko
Cc: platform-driver-x86, linux-kernel
> -----Original Message-----
> From: Nathan Chancellor <natechancellor@gmail.com>
> Sent: Wednesday, September 26, 2018 8:21 AM
> To: Vadim Pasternak <vadimp@mellanox.com>; Darren Hart
> <dvhart@infradead.org>; Andy Shevchenko <andy@infradead.org>
> Cc: platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org; Nathan
> Chancellor <natechancellor@gmail.com>
> Subject: [PATCH] platform/x86: mlx-platform: Properly use
> mlxplat_mlxcpld_msn201x_items
>
> Clang warns that mlxplat_mlxcpld_msn201x_items is not going to be emitted in
> the final assembly because it's only used in ARRAY_SIZE right now, which is a
> compile time evaluation since the array's size is known.
>
> drivers/platform/x86/mlx-platform.c:555:32: warning: variable
> 'mlxplat_mlxcpld_msn201x_items' is not needed and will not be emitted [-
> Wunneeded-internal-declaration] static struct mlxreg_core_item
> mlxplat_mlxcpld_msn201x_items[] = {
> ^
> 1 warning generated.
>
> It appears this was a copy and paste mistake from when this item was first
> added. Use the definition in mlxplat_mlxcpld_msn201x_data so that Clang no
> longer warns.
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/141
> Fixes: a49a41482f61 ("platform/x86: mlx-platform: Add support for new
> msn201x system type")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
> drivers/platform/x86/mlx-platform.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-
> platform.c
> index d89936c93ba0..c2c3a1a19879 100644
> --- a/drivers/platform/x86/mlx-platform.c
> +++ b/drivers/platform/x86/mlx-platform.c
> @@ -575,7 +575,7 @@ static struct mlxreg_core_item
> mlxplat_mlxcpld_msn201x_items[] = {
>
> static
> struct mlxreg_core_hotplug_platform_data mlxplat_mlxcpld_msn201x_data = {
> - .items = mlxplat_mlxcpld_msn21xx_items,
> + .items = mlxplat_mlxcpld_msn201x_items,
> .counter = ARRAY_SIZE(mlxplat_mlxcpld_msn201x_items),
> .cell = MLXPLAT_CPLD_LPC_REG_AGGR_OFFSET,
> .mask = MLXPLAT_CPLD_AGGR_MASK_DEF,
> --
> 2.19.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items
2018-09-26 7:43 ` Vadim Pasternak
@ 2018-10-19 11:38 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2018-10-19 11:38 UTC (permalink / raw)
To: Vadim Pasternak
Cc: natechancellor, Darren Hart, Andy Shevchenko, Platform Driver,
Linux Kernel Mailing List
On Wed, Sep 26, 2018 at 10:43 AM Vadim Pasternak <vadimp@mellanox.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Nathan Chancellor <natechancellor@gmail.com>
> > Sent: Wednesday, September 26, 2018 8:21 AM
> > To: Vadim Pasternak <vadimp@mellanox.com>; Darren Hart
> > <dvhart@infradead.org>; Andy Shevchenko <andy@infradead.org>
> > Cc: platform-driver-x86@vger.kernel.org; linux-kernel@vger.kernel.org; Nathan
> > Chancellor <natechancellor@gmail.com>
> > Subject: [PATCH] platform/x86: mlx-platform: Properly use
> > mlxplat_mlxcpld_msn201x_items
> >
> > Clang warns that mlxplat_mlxcpld_msn201x_items is not going to be emitted in
> > the final assembly because it's only used in ARRAY_SIZE right now, which is a
> > compile time evaluation since the array's size is known.
> >
> > drivers/platform/x86/mlx-platform.c:555:32: warning: variable
> > 'mlxplat_mlxcpld_msn201x_items' is not needed and will not be emitted [-
> > Wunneeded-internal-declaration] static struct mlxreg_core_item
> > mlxplat_mlxcpld_msn201x_items[] = {
> > ^
> > 1 warning generated.
> >
> > It appears this was a copy and paste mistake from when this item was first
> > added. Use the definition in mlxplat_mlxcpld_msn201x_data so that Clang no
> > longer warns.
> >
Pushed and applied, thanks!
> > Link: https://github.com/ClangBuiltLinux/linux/issues/141
> > Fixes: a49a41482f61 ("platform/x86: mlx-platform: Add support for new
> > msn201x system type")
> > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> > ---
>
> Acked-by: Vadim Pasternak <vadimp@mellanox.com>
>
> > drivers/platform/x86/mlx-platform.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-
> > platform.c
> > index d89936c93ba0..c2c3a1a19879 100644
> > --- a/drivers/platform/x86/mlx-platform.c
> > +++ b/drivers/platform/x86/mlx-platform.c
> > @@ -575,7 +575,7 @@ static struct mlxreg_core_item
> > mlxplat_mlxcpld_msn201x_items[] = {
> >
> > static
> > struct mlxreg_core_hotplug_platform_data mlxplat_mlxcpld_msn201x_data = {
> > - .items = mlxplat_mlxcpld_msn21xx_items,
> > + .items = mlxplat_mlxcpld_msn201x_items,
> > .counter = ARRAY_SIZE(mlxplat_mlxcpld_msn201x_items),
> > .cell = MLXPLAT_CPLD_LPC_REG_AGGR_OFFSET,
> > .mask = MLXPLAT_CPLD_AGGR_MASK_DEF,
> > --
> > 2.19.0
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-19 11:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-26 5:21 [PATCH] platform/x86: mlx-platform: Properly use mlxplat_mlxcpld_msn201x_items Nathan Chancellor
2018-09-26 7:43 ` Vadim Pasternak
2018-10-19 11:38 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).