From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Paul Cercueil <paul@crapouillou.net>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <michael.hennerich@analog.com>,
linux-iio <linux-iio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] iio: core: Support removing extended name in attribute filename
Date: Thu, 10 Jun 2021 16:14:21 +0300 [thread overview]
Message-ID: <CAHp75VeT+xGprpX9tAf2fNQgcWNHhWYZwXkm5MHb=DjtUB5Qzw@mail.gmail.com> (raw)
In-Reply-To: <20210610141057.00007361@Huawei.com>
On Thu, Jun 10, 2021 at 4:11 PM Jonathan Cameron
<Jonathan.Cameron@huawei.com> wrote:
> On Thu, 10 Jun 2021 14:05:53 +0100
> Paul Cercueil <paul@crapouillou.net> wrote:
> > Le jeu., juin 10 2021 at 15:58:51 +0300, Andy Shevchenko
> > <andy.shevchenko@gmail.com> a écrit :
> > > On Thu, Jun 10, 2021 at 3:47 PM Paul Cercueil <paul@crapouillou.net>
> > > wrote:
...
> > > I'm afraid, NAK. Otherwise, please put an explanation that clearly
> > > shows that it will be no ABI breakage.
> > > I.o.w. users for the existing drivers and devices will always get
> > > those attributes at the same platform configuration(s).
> >
> > Well, the commit message says that I'm adding a mechanism to disable
> > the feature. If it was actually doing anything else (like actually
> > disabling it for any attribute) then I'd mention it in the commit
> > message.
> >
> > I don't see how that possibly can be a ABI breakage.
>
> Ah. Both Andy and I got taken in by 'removing' in the title.
Yep. I have read the patch first and my impression was that we are
going to disable *existing* attributes, reading the complete series
suggests it's not true. That's why I recommend to massage the commit
message to avoid this confusion.
> What you really mean is identifying the extended name. That's
> much more acceptable :)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-06-10 13:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 12:45 [PATCH 0/2] iio: Add "extended_name" attribute Paul Cercueil
2021-06-10 12:45 ` [PATCH 1/2] iio: core: Support removing extended name in attribute filename Paul Cercueil
2021-06-10 12:58 ` Andy Shevchenko
2021-06-10 13:02 ` Andy Shevchenko
2021-06-10 13:04 ` Jonathan Cameron
2021-06-10 13:07 ` Paul Cercueil
2021-06-10 13:05 ` Paul Cercueil
2021-06-10 13:10 ` Jonathan Cameron
2021-06-10 13:14 ` Andy Shevchenko [this message]
2021-06-10 12:45 ` [PATCH 2/2] iio: core: Add "extended_name" attribute to all channels Paul Cercueil
2021-06-10 14:34 ` Jonathan Cameron
2021-06-10 14:49 ` Paul Cercueil
2021-06-11 17:50 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VeT+xGprpX9tAf2fNQgcWNHhWYZwXkm5MHb=DjtUB5Qzw@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).