linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <michael.hennerich@analog.com>,
	linux-iio <linux-iio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] iio: core: Support removing extended name in attribute filename
Date: Thu, 10 Jun 2021 14:07:35 +0100	[thread overview]
Message-ID: <NSLHUQ.V23ZTO77JGST3@crapouillou.net> (raw)
In-Reply-To: <20210610140412.000054ac@Huawei.com>

Hi Jonathan,

Le jeu., juin 10 2021 at 14:04:12 +0100, Jonathan Cameron 
<Jonathan.Cameron@Huawei.com> a écrit :
> On Thu, 10 Jun 2021 15:58:51 +0300
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> 
>>  On Thu, Jun 10, 2021 at 3:47 PM Paul Cercueil 
>> <paul@crapouillou.net> wrote:
>>  >
>>  > By default, when a channel has an extended name, it will appear 
>> in the
>>  > filename of channel attributes. E.g. if the extended name is 
>> "aux", the
>>  > filename of a "sample_rate" attribute will be something like:
>>  > in_voltage0_aux_sample_rate
>>  >
>>  > Add a mechanism to disable this feature. This will be used to add 
>> a
>>  > "extended_name" channel attribute.
>> 
>>  I'm afraid, NAK. Otherwise, please put an explanation that clearly
>>  shows that it will be no ABI breakage.
>>  I.o.w. users for the existing drivers and devices will always get
>>  those attributes at the same platform configuration(s).
>> 
> 
> What Andy said.  This was a bad design decision a long time back, but
> we are stuck with it.
> 
> We have the _label attribute today that is the preferred route 
> forwards
> for new drivers but we can't touch the old ones however annoying it 
> might
> be.

You're missing the point here. This patchset only adds a new channel 
attribute and doesn't change anything else.

The "label" is good to have, but that doesn't help me in any way. The 
problem here is parseability.

Cheers,
-Paul



  reply	other threads:[~2021-06-10 13:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10 12:45 [PATCH 0/2] iio: Add "extended_name" attribute Paul Cercueil
2021-06-10 12:45 ` [PATCH 1/2] iio: core: Support removing extended name in attribute filename Paul Cercueil
2021-06-10 12:58   ` Andy Shevchenko
2021-06-10 13:02     ` Andy Shevchenko
2021-06-10 13:04     ` Jonathan Cameron
2021-06-10 13:07       ` Paul Cercueil [this message]
2021-06-10 13:05     ` Paul Cercueil
2021-06-10 13:10       ` Jonathan Cameron
2021-06-10 13:14         ` Andy Shevchenko
2021-06-10 12:45 ` [PATCH 2/2] iio: core: Add "extended_name" attribute to all channels Paul Cercueil
2021-06-10 14:34   ` Jonathan Cameron
2021-06-10 14:49     ` Paul Cercueil
2021-06-11 17:50       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=NSLHUQ.V23ZTO77JGST3@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=Jonathan.Cameron@Huawei.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.hennerich@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).