[PATCH] platform/x86: dell-wmi: Add a better description for "stealth mode"

[PATCH] platform/x86: dell-wmi: Add a better description for "stealth mode"

[Darren Hart]

From: Andy Lutomirski <luto@kernel.org>

This is based on Mario's explanation and observation of my laptop.

Suggested-by: "Pali Rohár" <pali.rohar@gmail.com>
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Cc: Mario Limonciello <mario_limonciello@dell.com>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Andy Shevchenko <andy@infradead.org>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
---
 drivers/platform/x86/dell-wmi.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index 24467b1..73aee0d 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -272,7 +272,12 @@ static const struct key_entry dell_wmi_keymap_type_0010[] __initconst = {
 	/* RGB keyboard backlight control */
 	{ KE_IGNORE, 0x154, { KEY_RESERVED } },
 
-	/* Stealth mode toggle */
+	/*
+	 * Stealth mode toggle. This will "disable all lights and sounds".
+	 * The action is performed by the BIOS and EC; the WMI event is just
+	 * a notification. On the XPS 13 9350, this is Fn+F7, and there's
+	 * a BIOS setting to enable and disable the hotkey.
+	 */
 	{ KE_IGNORE, 0x155, { KEY_RESERVED } },
 
 	/* Rugged magnetic dock attach/detach events */
-- 
2.9.4

Re: [PATCH] platform/x86: dell-wmi: Add a better description for "stealth mode"

[Andy Shevchenko]

On Sat, May 27, 2017 at 8:16 AM, Darren Hart <dvhart@infradead.org> wrote:
> From: Andy Lutomirski <luto@kernel.org>
>
> This is based on Mario's explanation and observation of my laptop.
>

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Suggested-by: "Pali Rohár" <pali.rohar@gmail.com>
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> Cc: Mario Limonciello <mario_limonciello@dell.com>
> Cc: Matthew Garrett <mjg59@srcf.ucam.org>
> Cc: Andy Shevchenko <andy@infradead.org>
> Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
> ---
>  drivers/platform/x86/dell-wmi.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 24467b1..73aee0d 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -272,7 +272,12 @@ static const struct key_entry dell_wmi_keymap_type_0010[] __initconst = {
>         /* RGB keyboard backlight control */
>         { KE_IGNORE, 0x154, { KEY_RESERVED } },
>
> -       /* Stealth mode toggle */
> +       /*
> +        * Stealth mode toggle. This will "disable all lights and sounds".
> +        * The action is performed by the BIOS and EC; the WMI event is just
> +        * a notification. On the XPS 13 9350, this is Fn+F7, and there's
> +        * a BIOS setting to enable and disable the hotkey.
> +        */
>         { KE_IGNORE, 0x155, { KEY_RESERVED } },
>
>         /* Rugged magnetic dock attach/detach events */
> --
> 2.9.4
>



-- 
With Best Regards,
Andy Shevchenko