From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Darren Hart" <dvhart@infradead.org>,
"Andy Shevchenko" <andy@infradead.org>,
"Platform Driver" <platform-driver-x86@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data
Date: Tue, 31 Oct 2017 15:47:58 +0200 [thread overview]
Message-ID: <CAHp75Vec3Hjd_keMid-x6ub5ZJqUmq1nUFiHPsxuWt8V+vzrnQ@mail.gmail.com> (raw)
In-Reply-To: <20171031110318.20985-1-colin.king@canonical.com>
On Tue, Oct 31, 2017 at 1:03 PM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable byte_data is being initialized and re-assigned with values that
> are never read. Remove these as these redundant assignments. Cleans up
> clang warning:
>
> drivers/platform/x86/dell-smo8800.c:106:2: warning: Value stored to 'byte_data'
> is never read
Thanks for the patch.
As I read a code it was from the beginning like this. I dunno what was
a motivation of this pieces, thus I would like to hear Pali.
Per se patch looks pretty much good to me.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-10-31 13:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 11:03 [PATCH] platform: x86: dell-smo8800: remove redundant assignments to byte_data Colin King
2017-10-31 13:47 ` Andy Shevchenko [this message]
2017-10-31 13:55 ` Pali Rohár
2017-10-31 14:07 ` Andy Shevchenko
2017-10-31 14:13 ` Pali Rohár
2017-10-31 18:08 ` Andy Shevchenko
2017-10-31 18:41 ` Pali Rohár
2017-11-03 12:37 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vec3Hjd_keMid-x6ub5ZJqUmq1nUFiHPsxuWt8V+vzrnQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=colin.king@canonical.com \
--cc=dvhart@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).