* [PATCH] gpio: Add gpio alias support
@ 2022-03-21 8:05 haibo.chen
2022-03-21 16:41 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: haibo.chen @ 2022-03-21 8:05 UTC (permalink / raw)
To: linus.walleij, brgl; +Cc: linux-gpio, linux-kernel, linux-imx, haibo.chen
From: Haibo Chen <haibo.chen@nxp.com>
This patch allow setting gpio device id via device tree alias.
Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
drivers/gpio/gpiolib.c | 22 ++++++++++++++++------
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 56d090258d62..3d24351a33db 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -495,7 +495,7 @@ static void gpiodevice_release(struct device *dev)
list_del(&gdev->list);
spin_unlock_irqrestore(&gpio_lock, flags);
- ida_free(&gpio_ida, gdev->id);
+ ida_simple_remove(&gpio_ida, gdev->id);
kfree_const(gdev->label);
kfree(gdev->descs);
kfree(gdev);
@@ -594,6 +594,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
unsigned long flags;
int base = gc->base;
unsigned int i;
+ int alias_id, first_dynamic;
int ret = 0;
u32 ngpios;
@@ -623,11 +624,20 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
*/
gdev->dev.fwnode = dev_fwnode(&gdev->dev) ?: fwnode;
- gdev->id = ida_alloc(&gpio_ida, GFP_KERNEL);
- if (gdev->id < 0) {
- ret = gdev->id;
- goto err_free_gdev;
+ alias_id = of_alias_get_id(gdev->dev.of_node, "gpio");
+ if (alias_id < 0) {
+ first_dynamic = of_alias_get_highest_id("gpio");
+ if (first_dynamic < 0)
+ first_dynamic = 0;
+ else
+ first_dynamic++;
+ alias_id = ida_simple_get(&gpio_ida, first_dynamic, 0, GFP_KERNEL);
+ if (alias_id < 0) {
+ ret = alias_id;
+ goto err_free_gdev;
+ }
}
+ gdev->id = alias_id;
ret = dev_set_name(&gdev->dev, GPIOCHIP_NAME "%d", gdev->id);
if (ret)
@@ -821,7 +831,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
err_free_dev_name:
kfree(dev_name(&gdev->dev));
err_free_ida:
- ida_free(&gpio_ida, gdev->id);
+ ida_simple_remove(&gpio_ida, gdev->id);
err_free_gdev:
/* failures here can mean systems won't boot... */
if (ret != -EPROBE_DEFER) {
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: Add gpio alias support
2022-03-21 8:05 [PATCH] gpio: Add gpio alias support haibo.chen
@ 2022-03-21 16:41 ` Andy Shevchenko
2022-03-22 2:12 ` Bough Chen
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2022-03-21 16:41 UTC (permalink / raw)
To: BOUGH CHEN
Cc: Linus Walleij, Bartosz Golaszewski, open list:GPIO SUBSYSTEM,
Linux Kernel Mailing List, dl-linux-imx
On Mon, Mar 21, 2022 at 11:22 AM <haibo.chen@nxp.com> wrote:
>
> From: Haibo Chen <haibo.chen@nxp.com>
>
> This patch allow setting gpio device id via device tree alias.
allows
But read the Submitting Patches document about imperative mode.
Moreover, this commit message is quite bad. Please, read [1] for
making your commit messages meaningful and useful.
[1]: https://cbea.ms/git-commit/
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] gpio: Add gpio alias support
2022-03-21 16:41 ` Andy Shevchenko
@ 2022-03-22 2:12 ` Bough Chen
0 siblings, 0 replies; 3+ messages in thread
From: Bough Chen @ 2022-03-22 2:12 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linus Walleij, Bartosz Golaszewski, open list:GPIO SUBSYSTEM,
Linux Kernel Mailing List, dl-linux-imx
[-- Attachment #1: Type: text/plain, Size: 1500 bytes --]
> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@gmail.com]
> Sent: 2022年3月22日 0:41
> To: Bough Chen <haibo.chen@nxp.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>; Bartosz Golaszewski
> <brgl@bgdev.pl>; open list:GPIO SUBSYSTEM <linux-gpio@vger.kernel.org>;
> Linux Kernel Mailing List <linux-kernel@vger.kernel.org>; dl-linux-imx
> <linux-imx@nxp.com>
> Subject: Re: [PATCH] gpio: Add gpio alias support
>
> On Mon, Mar 21, 2022 at 11:22 AM <haibo.chen@nxp.com> wrote:
> >
> > From: Haibo Chen <haibo.chen@nxp.com>
> >
> > This patch allow setting gpio device id via device tree alias.
>
> allows
>
> But read the Submitting Patches document about imperative mode.
>
> Moreover, this commit message is quite bad. Please, read [1] for making
your
> commit messages meaningful and useful.
Thanks for your suggestion, I will add some info to explain why I involve
this change,
and the benefit of this patch.
Best Regards
Haibo Chen
>
> [1]:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcbea.m
> s%2Fgit-commit%2F&data=04%7C01%7Chaibo.chen%40nxp.com%7C365
> e24600aee43b3310508da0b59c5b3%7C686ea1d3bc2b4c6fa92cd99c5c301635
> %7C0%7C0%7C637834777437333289%7CUnknown%7CTWFpbGZsb3d8eyJWIj
> oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C30
> 00&sdata=JuJrBC1M079h5%2Bpc3i10eVqpL%2BXJLd4rt%2BjSPeIys4U%3
> D&reserved=0
>
> --
> With Best Regards,
> Andy Shevchenko
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 9551 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-22 2:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-21 8:05 [PATCH] gpio: Add gpio alias support haibo.chen
2022-03-21 16:41 ` Andy Shevchenko
2022-03-22 2:12 ` Bough Chen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).