From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Mario Limonciello <mario_limonciello@dell.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "dvhart@infradead.org" <dvhart@infradead.org>,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dell-wmi: Add events created by Dell Rugged 2-in-1s
Date: Sat, 3 Dec 2016 14:41:54 +0200 [thread overview]
Message-ID: <CAHp75Vew2qvsgyiihbfpw43kNRu81-QQTQ9SGuPdcyswUuS5_w@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Vd3bJOv7Cpp9xYXDV3s1pFpdS0-yvKPasY85g0TNK8X7A@mail.gmail.com>
On Sat, Nov 19, 2016 at 6:33 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Thu, Jul 28, 2016 at 8:53 PM, Mario Limonciello
> <mario_limonciello@dell.com> wrote:
>> The Dell Rugged 7202 has 3 programmable buttons (labeled P1, P2, P3)
>> and a detachable keyboard/mouse dock.
>>
>> Signed-off-by: Mario Limonciello <mario_limonciello@dell.com>
>
> There was a long discussion in the past. Just to get it clear. Are we
> all okay with version 2 of this series?
Darren, FWIW:
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
>> ---
>> drivers/platform/x86/dell-wmi.c | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
>> index 866bf73..28ec17a 100644
>> --- a/drivers/platform/x86/dell-wmi.c
>> +++ b/drivers/platform/x86/dell-wmi.c
>> @@ -274,6 +274,16 @@ static const struct key_entry dell_wmi_keymap_type_0010[] __initconst = {
>>
>> /* Stealth mode toggle */
>> { KE_IGNORE, 0x155, { KEY_RESERVED } },
>> +
>> + /* Rugged magnetic dock attach/detach events */
>> + { KE_IGNORE, 0x156, { KEY_RESERVED } },
>> + { KE_IGNORE, 0x157, { KEY_RESERVED } },
>> +
>> + /* Rugged programmable (P1/P2/P3 keys) */
>> + { KE_KEY, 0x850, { KEY_PROG1 } },
>> + { KE_KEY, 0x851, { KEY_PROG2 } },
>> + { KE_KEY, 0x852, { KEY_PROG3 } },
>> +
>> };
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2016-12-03 12:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 17:53 [PATCH v2 1/2] dell-wmi: Adjust wifi catcher to emit KEY_WLAN Mario Limonciello
2016-07-28 17:53 ` [PATCH v2 2/2] dell-wmi: Add events created by Dell Rugged 2-in-1s Mario Limonciello
2016-11-19 16:33 ` Andy Shevchenko
2016-12-03 12:41 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vew2qvsgyiihbfpw43kNRu81-QQTQ9SGuPdcyswUuS5_w@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario_limonciello@dell.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).