From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Andrea Merello <andrea.merello@gmail.com>
Cc: jic23@kernel.org, mchehab+huawei@kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, lars@metafoo.de, robh+dt@kernel.org,
matt.ranostay@konsulko.com, ardeleanalex@gmail.com,
jacopo@jmondi.org, Andrea Merello <andrea.merello@iit.it>
Subject: Re: [v3 12/13] iio: imu: add BNO055 I2C driver
Date: Mon, 21 Feb 2022 21:32:00 +0100 [thread overview]
Message-ID: <CAHp75Vezc+ieFE23unzNdcz5YeuduOO7OJWyS=HvEUAE4=x7Ag@mail.gmail.com> (raw)
In-Reply-To: <20220217162710.33615-13-andrea.merello@gmail.com>
On Thu, Feb 17, 2022 at 5:27 PM Andrea Merello <andrea.merello@gmail.com> wrote:
>
> This path adds an I2C driver for communicating to a BNO055 IMU via I2C
> bus and it enables the BNO055 core driver to work in this scenario.
...
> +#include <linux/i2c.h>
> +#include <linux/regmap.h>
> +#include <linux/module.h>
Keep it sorted?
...
> +static int bno055_i2c_probe(struct i2c_client *client,
> + const struct i2c_device_id *id)
You may switch it to use ->probe_new() (you may leave I2C ID table for
possibility to instantiate this via user space).
...
> + struct regmap *regmap =
> + devm_regmap_init_i2c(client, &bno055_regmap_config);
Please, split the definition and assignment.
> + if (IS_ERR(regmap)) {
> + dev_err(&client->dev, "Unable to init register map");
> + return PTR_ERR(regmap);
return dev_err_probe(...);
...
> + .probe = bno055_i2c_probe,
> + .id_table = bno055_i2c_id
Missed comma.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-02-21 20:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 16:26 [v3 00/13] Add support for Bosch BNO055 IMU Andrea Merello
2022-02-17 16:26 ` [v3 01/13] iio: add modifiers for linear acceleration Andrea Merello
2022-02-17 16:26 ` [v3 02/13] iio: document linear acceleration modifiers Andrea Merello
2022-02-19 16:08 ` Jonathan Cameron
2022-02-17 16:27 ` [v3 03/13] iio: event_monitor: add " Andrea Merello
2022-02-17 16:27 ` [v3 04/13] iio: add modifers for pitch, yaw, roll Andrea Merello
2022-02-17 16:27 ` [v3 05/13] iio: document pitch, yaw, roll modifiers Andrea Merello
2022-02-19 16:31 ` Jonathan Cameron
2022-02-17 16:27 ` [v3 06/13] iio: event_monitor: add pitch, yaw and " Andrea Merello
2022-02-17 16:27 ` [v3 07/13] iio: imu: add Bosch Sensortec BNO055 core driver Andrea Merello
2022-02-17 16:27 ` [v3 08/13] iio: document bno055 private sysfs attributes Andrea Merello
2022-02-19 16:50 ` Jonathan Cameron
2022-02-17 16:27 ` [v3 09/13] iio: document "serial_number" sysfs attribute Andrea Merello
2022-02-19 16:52 ` Jonathan Cameron
2022-02-17 16:27 ` [v3 10/13] dt-bindings: iio: imu: add documentation for Bosch BNO055 bindings Andrea Merello
2022-02-24 19:54 ` Rob Herring
2022-02-17 16:27 ` [v3 11/13] iio: imu: add BNO055 serdev driver Andrea Merello
2022-02-17 19:47 ` kernel test robot
2022-02-18 5:20 ` kernel test robot
2022-02-21 20:27 ` Andy Shevchenko
2022-03-22 10:37 ` Andrea Merello
2022-02-17 16:27 ` [v3 12/13] iio: imu: add BNO055 I2C driver Andrea Merello
2022-02-19 17:03 ` Jonathan Cameron
2022-02-21 20:32 ` Andy Shevchenko [this message]
2022-02-17 16:27 ` [v3 13/13] docs: iio: add documentation for BNO055 driver Andrea Merello
2022-02-19 17:06 ` Jonathan Cameron
2022-03-22 10:30 ` Andrea Merello
2022-03-22 20:32 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vezc+ieFE23unzNdcz5YeuduOO7OJWyS=HvEUAE4=x7Ag@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=andrea.merello@gmail.com \
--cc=andrea.merello@iit.it \
--cc=ardeleanalex@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jacopo@jmondi.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.ranostay@konsulko.com \
--cc=mchehab+huawei@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).