From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: "Darren Hart" <dvhart@infradead.org>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Matthew Garrett" <mjg59@srcf.ucam.org>,
"Andy Shevchenko" <andy@infradead.org>,
"Mario Limonciello" <mario.limonciello@dell.com>,
"Platform Driver" <platform-driver-x86@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: dell-wmi: Ignore new keyboard backlight change event
Date: Tue, 5 Feb 2019 19:35:27 +0200 [thread overview]
Message-ID: <CAHp75VfA+UYPGBZVxUqk90dsifrs-LkN_vDDrrq-rcMMeH6tdw@mail.gmail.com> (raw)
In-Reply-To: <60649833-A007-4821-9A35-8F420B5F9714@canonical.com>
On Thu, Jan 24, 2019 at 8:27 AM Kai-Heng Feng
<kai.heng.feng@canonical.com> wrote:
>
> Hi Darren,
>
> > On Dec 12, 2018, at 22:06, Pali Rohár <pali.rohar@gmail.com> wrote:
> >
> > On Wednesday 12 December 2018 14:41:25 Kai-Heng Feng wrote:
> >> There's a new wmi event generated by dell-wmi when pressing keyboard
> >> backlight hotkey:
> >> [ 3285.474172] dell_wmi: Unknown key with type 0x0010 and code 0x003f pressed
> >>
> >> This event is for notification purpose, let's ignore it. The keyboard
> >> backlight hotkey uses another event so it still works without event
> >> 0x3f.
Pushed to my review and testing queue, thanks!
> >>
> >> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
> >> ---
> >> drivers/platform/x86/dell-wmi.c | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> >> index 16c7f3d9a335..c3166ba73e9a 100644
> >> --- a/drivers/platform/x86/dell-wmi.c
> >> +++ b/drivers/platform/x86/dell-wmi.c
> >> @@ -267,6 +267,9 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
> >> /* Fn-lock switched to multimedia keys */
> >> { KE_IGNORE, 0x1, { KEY_RESERVED } },
> >>
> >> + /* Keyboard backlight change notification */
> >> + { KE_IGNORE, 0x3f, { KEY_RESERVED } },
> >> +
> >> /* Mic mute */
> >> { KE_KEY, 0x150, { KEY_MICMUTE } },
> >>
> >
> > Looks good.
> >
> > Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
>
> Please merge this patch, thanks.
>
> Kai-Heng
>
> >
> > --
> > Pali Rohár
> > pali.rohar@gmail.com
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2019-02-05 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 6:41 [PATCH] platform/x86: dell-wmi: Ignore new keyboard backlight change event Kai-Heng Feng
2018-12-12 14:06 ` Pali Rohár
2019-01-24 6:25 ` Kai-Heng Feng
2019-02-05 17:35 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfA+UYPGBZVxUqk90dsifrs-LkN_vDDrrq-rcMMeH6tdw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@dell.com \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).