Re: [PATCH] platform/x86: dell-wmi: Ignore new keyboard backlight change event - Kai-Heng Feng

From: Kai-Heng Feng <kai.heng.feng@canonical.com>
To: dvhart@infradead.org
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
	mjg59@srcf.ucam.org, andy@infradead.org,
	"Mario Limonciello" <mario.limonciello@dell.com>,
	platform-driver-x86@vger.kernel.org,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: dell-wmi: Ignore new keyboard backlight change event
Date: Thu, 24 Jan 2019 14:25:43 +0800	[thread overview]
Message-ID: <60649833-A007-4821-9A35-8F420B5F9714@canonical.com> (raw)
In-Reply-To: <20181212140607.nrawhff2rgn5ykja@pali>

Hi Darren,

> On Dec 12, 2018, at 22:06, Pali Rohár <pali.rohar@gmail.com> wrote:
> 
> On Wednesday 12 December 2018 14:41:25 Kai-Heng Feng wrote:
>> There's a new wmi event generated by dell-wmi when pressing keyboard
>> backlight hotkey:
>> [ 3285.474172] dell_wmi: Unknown key with type 0x0010 and code 0x003f pressed
>> 
>> This event is for notification purpose, let's ignore it. The keyboard
>> backlight hotkey uses another event so it still works without event
>> 0x3f.
>> 
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
>> ---
>> drivers/platform/x86/dell-wmi.c | 3 +++
>> 1 file changed, 3 insertions(+)
>> 
>> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
>> index 16c7f3d9a335..c3166ba73e9a 100644
>> --- a/drivers/platform/x86/dell-wmi.c
>> +++ b/drivers/platform/x86/dell-wmi.c
>> @@ -267,6 +267,9 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = {
>> 	/* Fn-lock switched to multimedia keys */
>> 	{ KE_IGNORE, 0x1, { KEY_RESERVED } },
>> 
>> +	/* Keyboard backlight change notification */
>> +	{ KE_IGNORE, 0x3f, { KEY_RESERVED } },
>> +
>> 	/* Mic mute */
>> 	{ KE_KEY, 0x150, { KEY_MICMUTE } },
>> 
> 
> Looks good.
> 
> Reviewed-by: Pali Rohár <pali.rohar@gmail.com>

Please merge this patch, thanks.

Kai-Heng

> 
> -- 
> Pali Rohár
> pali.rohar@gmail.com