* pinctrl: intel: Fix a glitch when updating IRQ flags on a preconfigured line
[not found] <20220119181915.27519-1>
@ 2022-01-21 9:34 ` Grace Kao
2022-01-21 10:27 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Grace Kao @ 2022-01-21 9:34 UTC (permalink / raw)
To: linux-gpio, linux-kernel
Cc: Mika Westerberg, Andy Shevchenko, Linus Walleij, Kane Chen,
grace.kao, Andy Shevchenko
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
The commit af7e3eeb84e2 ("pinctrl: intel: Disable input and output buffer
when switching to GPIO") hadn't taken into account an update of the IRQ
flags scenario.
When updating the IRQ flags on the preconfigured line the ->irq_set_type()
is called again. In such case the sequential Rx buffer configuration
changes may trigger a falling or rising edge interrupt that may lead,
on some platforms, to an undesired event.
This may happen because each of intel_gpio_set_gpio_mode() and
__intel_gpio_set_direction() updates the pad configuration with a different
value of the GPIORXDIS bit. Notable, that the intel_gpio_set_gpio_mode() is
called only for the pads that are configured as an input. Due to this fact,
integrate the logic of __intel_gpio_set_direction() call into the
intel_gpio_set_gpio_mode() so that the Rx buffer won't be disabled and
immediately re-enabled.
Fixes: af7e3eeb84e2 ("pinctrl: intel: Disable input and output buffer when switching to GPIO")
Reported-by: Kane Chen <kane.chen@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Tested-by: Grace Kao <grace.kao@intel.com>
Change-Id: I6ff5cf0c42a76dce709a445c1820c8f3a84d6d89
---
drivers/pinctrl/intel/pinctrl-intel.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index 85750974d182..afd35e6999cc 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -451,8 +451,8 @@ static void intel_gpio_set_gpio_mode(void __iomem *padcfg0)
value &= ~PADCFG0_PMODE_MASK;
value |= PADCFG0_PMODE_GPIO;
- /* Disable input and output buffers */
- value |= PADCFG0_GPIORXDIS;
+ /* Disable TX buffer and enable RX (this will be input) */
+ value &= ~PADCFG0_GPIORXDIS;
value |= PADCFG0_GPIOTXDIS;
/* Disable SCI/SMI/NMI generation */
@@ -497,9 +497,6 @@ static int intel_gpio_request_enable(struct pinctrl_dev *pctldev,
intel_gpio_set_gpio_mode(padcfg0);
- /* Disable TX buffer and enable RX (this will be input) */
- __intel_gpio_set_direction(padcfg0, true);
-
raw_spin_unlock_irqrestore(&pctrl->lock, flags);
return 0;
@@ -1115,9 +1112,6 @@ static int intel_gpio_irq_type(struct irq_data *d, unsigned int type)
intel_gpio_set_gpio_mode(reg);
- /* Disable TX buffer and enable RX (this will be input) */
- __intel_gpio_set_direction(reg, true);
-
value = readl(reg);
value &= ~(PADCFG0_RXEVCFG_MASK | PADCFG0_RXINV);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: pinctrl: intel: Fix a glitch when updating IRQ flags on a preconfigured line
2022-01-21 9:34 ` pinctrl: intel: Fix a glitch when updating IRQ flags on a preconfigured line Grace Kao
@ 2022-01-21 10:27 ` Andy Shevchenko
2022-01-24 13:45 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2022-01-21 10:27 UTC (permalink / raw)
To: Grace Kao
Cc: open list:GPIO SUBSYSTEM, Linux Kernel Mailing List,
Mika Westerberg, Andy Shevchenko, Linus Walleij, Kane Chen,
Andy Shevchenko
On Fri, Jan 21, 2022 at 11:35 AM Grace Kao <grace.kao@intel.com> wrote:
> Tested-by: Grace Kao <grace.kao@intel.com>
Thanks for testing. I will apply the tag to the original patch. The
idea that you simply reply to the original message with the line above
and that's it, no need to resend a full patch.
> Change-Id: I6ff5cf0c42a76dce709a445c1820c8f3a84d6d89
I see it comes from the internal tree.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: pinctrl: intel: Fix a glitch when updating IRQ flags on a preconfigured line
2022-01-21 10:27 ` Andy Shevchenko
@ 2022-01-24 13:45 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2022-01-24 13:45 UTC (permalink / raw)
To: Grace Kao
Cc: open list:GPIO SUBSYSTEM, Linux Kernel Mailing List,
Mika Westerberg, Andy Shevchenko, Linus Walleij, Kane Chen
On Fri, Jan 21, 2022 at 12:27:40PM +0200, Andy Shevchenko wrote:
> On Fri, Jan 21, 2022 at 11:35 AM Grace Kao <grace.kao@intel.com> wrote:
>
> > Tested-by: Grace Kao <grace.kao@intel.com>
>
> Thanks for testing. I will apply the tag to the original patch. The
> idea that you simply reply to the original message with the line above
> and that's it, no need to resend a full patch.
>
> > Change-Id: I6ff5cf0c42a76dce709a445c1820c8f3a84d6d89
>
> I see it comes from the internal tree.
Original patch with your tag has been pushed to my review and testing queue, thanks!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-24 13:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220119181915.27519-1>
2022-01-21 9:34 ` pinctrl: intel: Fix a glitch when updating IRQ flags on a preconfigured line Grace Kao
2022-01-21 10:27 ` Andy Shevchenko
2022-01-24 13:45 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).