* [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios
@ 2017-01-04 12:59 Jean Delvare
2017-01-04 13:14 ` Andy Shevchenko
2017-01-05 8:59 ` Pali Rohár
0 siblings, 2 replies; 7+ messages in thread
From: Jean Delvare @ 2017-01-04 12:59 UTC (permalink / raw)
To: Darren Hart, platform-driver-x86
Cc: LKML, Michał Kępień, Pali Rohár
Dell-smbios is a helper module, it serves no purpose on its own, so
do not present it as an option to the user. Instead, select it
automatically whenever a driver which needs it is selected.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Michał Kępień <kernel@kempniu.pl>
Cc: Pali Rohár <pali.rohar@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>
---
Changes since v1:
* Select DCDBAS instead of depending on it. This is more
user-friendly and avoids the confusing transitive dependencies
which Pali didn't like.
drivers/platform/x86/Kconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- linux-4.10-rc2.orig/drivers/platform/x86/Kconfig 2017-01-01 23:31:53.000000000 +0100
+++ linux-4.10-rc2/drivers/platform/x86/Kconfig 2017-01-04 13:53:41.691262664 +0100
@@ -92,8 +92,8 @@ config ASUS_LAPTOP
If you have an ACPI-compatible ASUS laptop, say Y or M here.
config DELL_SMBIOS
- tristate "Dell SMBIOS Support"
- depends on DCDBAS
+ tristate
+ select DCDBAS
default n
---help---
This module provides common functions for kernel modules using
@@ -103,12 +103,12 @@ config DELL_SMBIOS
config DELL_LAPTOP
tristate "Dell Laptop Extras"
- depends on DELL_SMBIOS
depends on DMI
depends on BACKLIGHT_CLASS_DEVICE
depends on ACPI_VIDEO || ACPI_VIDEO = n
depends on RFKILL || RFKILL = n
depends on SERIO_I8042
+ select DELL_SMBIOS
select POWER_SUPPLY
select LEDS_CLASS
select NEW_LEDS
@@ -123,7 +123,7 @@ config DELL_WMI
depends on DMI
depends on INPUT
depends on ACPI_VIDEO || ACPI_VIDEO = n
- depends on DELL_SMBIOS
+ select DELL_SMBIOS
select INPUT_SPARSEKMAP
---help---
Say Y here if you want to support WMI-based hotkeys on Dell laptops.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios
2017-01-04 12:59 [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Jean Delvare
@ 2017-01-04 13:14 ` Andy Shevchenko
2017-01-05 8:12 ` Jean Delvare
2017-01-05 8:59 ` Pali Rohár
1 sibling, 1 reply; 7+ messages in thread
From: Andy Shevchenko @ 2017-01-04 13:14 UTC (permalink / raw)
To: Jean Delvare
Cc: Darren Hart, Platform Driver, LKML, Michał Kępień,
Pali Rohár
On Wed, Jan 4, 2017 at 2:59 PM, Jean Delvare <jdelvare@suse.de> wrote:
> Dell-smbios is a helper module, it serves no purpose on its own, so
> do not present it as an option to the user. Instead, select it
> automatically whenever a driver which needs it is selected.
>
Please, use prefix "platform/x86: ".
Perhaps, use just "dell_smbios: " as second one.
> config DELL_SMBIOS
> - tristate "Dell SMBIOS Support"
> - depends on DCDBAS
> + tristate
> + select DCDBAS
> default n
Do we need this one?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios
2017-01-04 13:14 ` Andy Shevchenko
@ 2017-01-05 8:12 ` Jean Delvare
0 siblings, 0 replies; 7+ messages in thread
From: Jean Delvare @ 2017-01-05 8:12 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Darren Hart, Platform Driver, LKML, Michał Kępień,
Pali Rohár
Hi Andy,
Thanks for the review.
On Wed, 4 Jan 2017 15:14:10 +0200, Andy Shevchenko wrote:
> On Wed, Jan 4, 2017 at 2:59 PM, Jean Delvare <jdelvare@suse.de> wrote:
> > Dell-smbios is a helper module, it serves no purpose on its own, so
> > do not present it as an option to the user. Instead, select it
> > automatically whenever a driver which needs it is selected.
> >
>
> Please, use prefix "platform/x86: ".
> Perhaps, use just "dell_smbios: " as second one.
OK, will change.
> > config DELL_SMBIOS
> > - tristate "Dell SMBIOS Support"
> > - depends on DCDBAS
> > + tristate
> > + select DCDBAS
>
> > default n
>
> Do we need this one?
Probably not. "n" being the default default, I guess the 844
occurrences of "default n" in the Kconfig tree are pointless ;-)
I'll post v3 of the patch in a minute.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios
2017-01-04 12:59 [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Jean Delvare
2017-01-04 13:14 ` Andy Shevchenko
@ 2017-01-05 8:59 ` Pali Rohár
2017-01-05 9:09 ` Jean Delvare
1 sibling, 1 reply; 7+ messages in thread
From: Pali Rohár @ 2017-01-05 8:59 UTC (permalink / raw)
To: Jean Delvare
Cc: Darren Hart, platform-driver-x86, LKML, Michał Kępień
On Wednesday 04 January 2017 13:59:17 Jean Delvare wrote:
> Dell-smbios is a helper module, it serves no purpose on its own, so
> do not present it as an option to the user. Instead, select it
> automatically whenever a driver which needs it is selected.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Michał Kępień <kernel@kempniu.pl>
> Cc: Pali Rohár <pali.rohar@gmail.com>
> Cc: Darren Hart <dvhart@infradead.org>
> ---
> Changes since v1:
> * Select DCDBAS instead of depending on it. This is more
> user-friendly and avoids the confusing transitive dependencies
> which Pali didn't like.
Hi! I see that in previous email you CCed Yann and linux-kbuild, but I
do not see any response in my mailbox. Have you got some answer?
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios
2017-01-05 8:59 ` Pali Rohár
@ 2017-01-05 9:09 ` Jean Delvare
2017-01-05 9:10 ` Pali Rohár
0 siblings, 1 reply; 7+ messages in thread
From: Jean Delvare @ 2017-01-05 9:09 UTC (permalink / raw)
To: Pali Rohár
Cc: Darren Hart, platform-driver-x86, LKML, Michał Kępień
Hi Pali,
On Thu, 5 Jan 2017 09:59:39 +0100, Pali Rohár wrote:
> On Wednesday 04 January 2017 13:59:17 Jean Delvare wrote:
> > Dell-smbios is a helper module, it serves no purpose on its own, so
> > do not present it as an option to the user. Instead, select it
> > automatically whenever a driver which needs it is selected.
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: Michał Kępień <kernel@kempniu.pl>
> > Cc: Pali Rohár <pali.rohar@gmail.com>
> > Cc: Darren Hart <dvhart@infradead.org>
> > ---
> > Changes since v1:
> > * Select DCDBAS instead of depending on it. This is more
> > user-friendly and avoids the confusing transitive dependencies
> > which Pali didn't like.
>
> Hi! I see that in previous email you CCed Yann and linux-kbuild, (...)
No, I did not. What are you talking about? I'm confused.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios
2017-01-05 9:09 ` Jean Delvare
@ 2017-01-05 9:10 ` Pali Rohár
2017-01-05 21:12 ` Andy Shevchenko
0 siblings, 1 reply; 7+ messages in thread
From: Pali Rohár @ 2017-01-05 9:10 UTC (permalink / raw)
To: Jean Delvare
Cc: Darren Hart, platform-driver-x86, LKML, Michał Kępień
On Thursday 05 January 2017 10:09:03 Jean Delvare wrote:
> Hi Pali,
>
> On Thu, 5 Jan 2017 09:59:39 +0100, Pali Rohár wrote:
> > On Wednesday 04 January 2017 13:59:17 Jean Delvare wrote:
> > > Dell-smbios is a helper module, it serves no purpose on its own, so
> > > do not present it as an option to the user. Instead, select it
> > > automatically whenever a driver which needs it is selected.
> > >
> > > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > > Cc: Michał Kępień <kernel@kempniu.pl>
> > > Cc: Pali Rohár <pali.rohar@gmail.com>
> > > Cc: Darren Hart <dvhart@infradead.org>
> > > ---
> > > Changes since v1:
> > > * Select DCDBAS instead of depending on it. This is more
> > > user-friendly and avoids the confusing transitive dependencies
> > > which Pali didn't like.
> >
> > Hi! I see that in previous email you CCed Yann and linux-kbuild, (...)
>
> No, I did not. What are you talking about? I'm confused.
Ah, Darren (not you) CCed linux-kbuild under thread for v1 of your patches.
--
Pali Rohár
pali.rohar@gmail.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios
2017-01-05 9:10 ` Pali Rohár
@ 2017-01-05 21:12 ` Andy Shevchenko
0 siblings, 0 replies; 7+ messages in thread
From: Andy Shevchenko @ 2017-01-05 21:12 UTC (permalink / raw)
To: Pali Rohár
Cc: Jean Delvare, Darren Hart, Platform Driver, LKML,
Michał Kępień
On Thu, Jan 5, 2017 at 11:10 AM, Pali Rohár <pali.rohar@gmail.com> wrote:
> On Thursday 05 January 2017 10:09:03 Jean Delvare wrote:
>> > Hi! I see that in previous email you CCed Yann and linux-kbuild, (...)
>>
>> No, I did not. What are you talking about? I'm confused.
>
> Ah, Darren (not you) CCed linux-kbuild under thread for v1 of your patches.
I have pushed v3 to testing and it passes kbuild bot tests.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-01-05 21:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-04 12:59 [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Jean Delvare
2017-01-04 13:14 ` Andy Shevchenko
2017-01-05 8:12 ` Jean Delvare
2017-01-05 8:59 ` Pali Rohár
2017-01-05 9:09 ` Jean Delvare
2017-01-05 9:10 ` Pali Rohár
2017-01-05 21:12 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).