From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Alexandru Ardelean <alexandru.ardelean@analog.com>,
linux-iio <linux-iio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 1/3] iio: adc: ad7887: convert dual-channel mode to DT/ACPI
Date: Tue, 17 Nov 2020 13:08:18 +0200 [thread overview]
Message-ID: <CAHp75VfKDSsiWqK0Bkkbe1ChntsRAFP5C_2qEzw+YE_qPjhJcQ@mail.gmail.com> (raw)
In-Reply-To: <20201117104126.00000516@Huawei.com>
On Tue, Nov 17, 2020 at 12:42 PM Jonathan Cameron
<Jonathan.Cameron@huawei.com> wrote:
>
> On Tue, 17 Nov 2020 09:52:52 +0200
> Alexandru Ardelean <alexandru.ardelean@analog.com> wrote:
>
> > This change converts the configuration of the dual-channel mode from the
> > old platform-data, to the device_property_present() function, which
> > supports both device-tree and ACPI configuration setups.
> >
> > With this change the old platform_data include of the driver can be
> > removed.
> >
> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Hi Alex,
>
> I'm a bit in too minds about device_property_present()
> vs device_property_read_bool() which are the same thing under the hood.
>
> Not sure which one conveys the correct semantics here.
> I don't feel strongly enough about it though to do more than raise
> eyebrows (i.e. not blocking this series).
The idea as I understand it is that the 'present' can be run against
any type of property, while 'bool' is specifically for boolean (the
similarities is a detail of implementation).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-11-17 11:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 7:52 [PATCH 1/3] iio: adc: ad7887: convert dual-channel mode to DT/ACPI Alexandru Ardelean
2020-11-17 7:52 ` [PATCH 2/3] iio: adc: ad7887: convert driver to full DT probing Alexandru Ardelean
2020-11-17 11:01 ` Jonathan Cameron
2020-11-17 11:04 ` Jonathan Cameron
2020-11-17 15:03 ` Alexandru Ardelean
2020-11-17 16:02 ` Jonathan Cameron
2020-11-18 12:59 ` Alexandru Ardelean
2020-11-18 16:06 ` Jonathan Cameron
2020-11-17 11:05 ` Andy Shevchenko
2020-11-17 7:52 ` [PATCH 3/3] dt-bindings: adc: ad7887: add binding doc for AD7887 Alexandru Ardelean
2020-11-17 11:03 ` Jonathan Cameron
2020-11-17 10:41 ` [PATCH 1/3] iio: adc: ad7887: convert dual-channel mode to DT/ACPI Jonathan Cameron
2020-11-17 11:08 ` Andy Shevchenko [this message]
2020-11-18 12:52 ` Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfKDSsiWqK0Bkkbe1ChntsRAFP5C_2qEzw+YE_qPjhJcQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alexandru.ardelean@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).