From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [RFT PATCH 5/7] gpio: exar: unduplicate address and offset computation
Date: Mon, 2 Nov 2020 12:58:36 +0200 [thread overview]
Message-ID: <CAHp75VfNy4j73nFd2nGSsuGdn0Yat_ENGaaARP_8R9CQKHnnZg@mail.gmail.com> (raw)
In-Reply-To: <20201026141839.28536-6-brgl@bgdev.pl>
On Mon, Oct 26, 2020 at 4:23 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
...
> +static unsigned int
> +exar_offset_to_sel_addr(struct exar_gpio_chip *exar_gpio, unsigned int offset)
> +{
> + return (offset + exar_gpio->first_pin) / 8 ? EXAR_OFFSET_MPIOSEL_HI
> + : EXAR_OFFSET_MPIOSEL_LO;
> +}
> +
> +static unsigned int
> +exar_offset_to_lvl_addr(struct exar_gpio_chip *exar_gpio, unsigned int offset)
> +{
> + return (offset + exar_gpio->first_pin) / 8 ? EXAR_OFFSET_MPIOLVL_HI
> + : EXAR_OFFSET_MPIOLVL_LO;
> +}
> +
> +static unsigned int
> +exar_offset_to_bit(struct exar_gpio_chip *exar_gpio, unsigned int offset)
> +{
> + return (offset + exar_gpio->first_pin) % 8;
> +}
Answering to your question...
It can be done line this:
static unsigned int exar_offset_to_bank_and_bit(..., *bit)
{
*bit = (offset + exar_gpio->first_pin) % 8;
return (offset + exar_gpio->first_pin) / 8;
}
static unsigned int exar_offset_to_lvl_addr_and_bit(, *bit)
{
return exar_offset_to_bank_and_bit(..., bit) ?
EXAR_OFFSET_MPIOLVL_HI : EXAR_OFFSET_MPIOLVL_LO;
}
...
> + unsigned int addr = exar_offset_to_lvl_addr(exar_gpio, offset);
> + unsigned int bit = exar_offset_to_bit(exar_gpio, offset);
unsigned int addr, bit;
addr = exar_offset_to_lvl_addr_and_bit(..., &bit);
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-11-02 10:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 14:18 [PATCH 0/7] gpio: exar: refactor the driver Bartosz Golaszewski
2020-10-26 14:18 ` [PATCH 1/7] gpio: exar: add a newline after the copyright notice Bartosz Golaszewski
2020-10-26 14:18 ` [PATCH 2/7] gpio: exar: include idr.h Bartosz Golaszewski
2020-10-26 14:18 ` [PATCH 3/7] gpio: exar: switch to a simpler IDA interface Bartosz Golaszewski
2020-10-26 14:18 ` [PATCH 4/7] gpio: exar: use a helper variable for &pdev->dev Bartosz Golaszewski
2020-10-26 14:18 ` [RFT PATCH 5/7] gpio: exar: unduplicate address and offset computation Bartosz Golaszewski
2020-10-26 14:52 ` Andy Shevchenko
2020-11-02 10:16 ` Bartosz Golaszewski
2020-11-02 10:58 ` Andy Shevchenko [this message]
2020-11-02 11:27 ` David Laight
2020-10-26 14:18 ` [RFT PATCH 6/7] gpio: exar: switch to using regmap Bartosz Golaszewski
2020-10-26 14:59 ` Andy Shevchenko
2020-11-04 16:32 ` Bartosz Golaszewski
2020-10-26 14:18 ` [PATCH 7/7] gpio: exar: use devm action for freeing the IDA and drop remove() Bartosz Golaszewski
2020-10-26 15:03 ` Andy Shevchenko
2020-10-26 15:12 ` Bartosz Golaszewski
2020-10-26 14:46 ` [PATCH 0/7] gpio: exar: refactor the driver Andy Shevchenko
2020-10-26 15:05 ` Andy Shevchenko
2020-10-27 15:12 ` Jan Kiszka
2020-11-04 13:57 ` Jan Kiszka
2020-11-04 14:52 ` Andy Shevchenko
2020-11-04 16:23 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfNy4j73nFd2nGSsuGdn0Yat_ENGaaARP_8R9CQKHnnZg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).