linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
	Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 0/7] gpio: exar: refactor the driver
Date: Wed, 4 Nov 2020 17:23:29 +0100	[thread overview]
Message-ID: <CAMRc=MfDvtb13NLnwZNPNnP8NtWZRnok-Rd664LviUryqKAJvg@mail.gmail.com> (raw)
In-Reply-To: <CAHp75VdRNFqDySL6D-7BzBMRu1+aPgeT=kxWtcthYH3pVWRycg@mail.gmail.com>

On Wed, Nov 4, 2020 at 3:51 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Wed, Nov 4, 2020 at 3:57 PM Jan Kiszka <jan.kiszka@siemens.com> wrote:
> > On 27.10.20 16:12, Jan Kiszka wrote:
> > > On 26.10.20 15:46, Andy Shevchenko wrote:
> > >> On Mon, Oct 26, 2020 at 4:22 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >>>
> > >>> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > >>>
> > >>> I just wanted to convert the driver to using simpler IDA API but ended up
> > >>> quickly converting it to using regmap. Unfortunately I don't have the HW
> > >>> to test it so marking the patches that introduce functional change as RFT
> > >>> and Cc'ing the original author.
> > >>
> > >> +Cc: Jan, AFAIR their devices are using Exar UART.
> > >>
> > >
> > > Thanks for CC'ing. I cannot promise testing this soon, but I will try my
> > > best.
> > >
> >
> > Finally tested, unfortunately with bad news:
>
> > Code: Unable to access opcode bytes at RIP 0xffffffd6.
>
> I guess it is due to missed error pointer handling somewhere, as above
> is equal to -ENOMSG.
>

Yeah I'd guess it's the regmap pointer but we do check the return
value of regmap init with IS_ERR(). :/

Bartosz

      reply	other threads:[~2020-11-04 16:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 14:18 [PATCH 0/7] gpio: exar: refactor the driver Bartosz Golaszewski
2020-10-26 14:18 ` [PATCH 1/7] gpio: exar: add a newline after the copyright notice Bartosz Golaszewski
2020-10-26 14:18 ` [PATCH 2/7] gpio: exar: include idr.h Bartosz Golaszewski
2020-10-26 14:18 ` [PATCH 3/7] gpio: exar: switch to a simpler IDA interface Bartosz Golaszewski
2020-10-26 14:18 ` [PATCH 4/7] gpio: exar: use a helper variable for &pdev->dev Bartosz Golaszewski
2020-10-26 14:18 ` [RFT PATCH 5/7] gpio: exar: unduplicate address and offset computation Bartosz Golaszewski
2020-10-26 14:52   ` Andy Shevchenko
2020-11-02 10:16     ` Bartosz Golaszewski
2020-11-02 10:58   ` Andy Shevchenko
2020-11-02 11:27     ` David Laight
2020-10-26 14:18 ` [RFT PATCH 6/7] gpio: exar: switch to using regmap Bartosz Golaszewski
2020-10-26 14:59   ` Andy Shevchenko
2020-11-04 16:32   ` Bartosz Golaszewski
2020-10-26 14:18 ` [PATCH 7/7] gpio: exar: use devm action for freeing the IDA and drop remove() Bartosz Golaszewski
2020-10-26 15:03   ` Andy Shevchenko
2020-10-26 15:12     ` Bartosz Golaszewski
2020-10-26 14:46 ` [PATCH 0/7] gpio: exar: refactor the driver Andy Shevchenko
2020-10-26 15:05   ` Andy Shevchenko
2020-10-27 15:12   ` Jan Kiszka
2020-11-04 13:57     ` Jan Kiszka
2020-11-04 14:52       ` Andy Shevchenko
2020-11-04 16:23         ` Bartosz Golaszewski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMRc=MfDvtb13NLnwZNPNnP8NtWZRnok-Rd664LviUryqKAJvg@mail.gmail.com' \
    --to=brgl@bgdev.pl \
    --cc=andy.shevchenko@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=jan.kiszka@siemens.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sudipm.mukherjee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).