From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@intel.com>
Cc: Michal Simek <michal.simek@xilinx.com>,
"Hunter, Adrian" <adrian.hunter@intel.com>,
"Shevchenko, Andriy" <andriy.shevchenko@intel.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Raja Subramanian,
Lakshmi Bai" <lakshmi.bai.raja.subramanian@intel.com>,
"Wan Mohamad,
Wan Ahmad Zainie" <wan.ahmad.zainie.wan.mohamad@intel.com>,
"arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH v4 3/4] mmc: sdhci-of-arasan: Add structure device pointer in probe
Date: Thu, 8 Oct 2020 14:12:29 +0300 [thread overview]
Message-ID: <CAHp75VfRF75uCGD3uAuYBvKi1LZOtVDAfiOHKxDhKr=9LP+nEg@mail.gmail.com> (raw)
In-Reply-To: <DM6PR11MB28769233CEC9023E3D9720F9B80B0@DM6PR11MB2876.namprd11.prod.outlook.com>
On Thu, Oct 8, 2020 at 1:36 PM Zulkifli, Muhammad Husaini
<muhammad.husaini.zulkifli@intel.com> wrote:
> >From: Michal Simek <michal.simek@xilinx.com>
> >Sent: Thursday, October 8, 2020 3:35 PM
> >On 08. 10. 20 4:09, muhammad.husaini.zulkifli@intel.com wrote:
> >> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
...
> >> @@ -1521,6 +1521,7 @@ static int sdhci_arasan_probe(struct
> >platform_device *pdev)
> >> struct sdhci_pltfm_host *pltfm_host;
> >> struct sdhci_arasan_data *sdhci_arasan;
> >> struct device_node *np = pdev->dev.of_node;
> >> + struct device *dev = &pdev->dev;
> >> const struct sdhci_arasan_of_data *data;
> >>
> >> match = of_match_node(sdhci_arasan_of_match, pdev->dev.of_node);
> >>
> >
> >This is not what we discussed. You create new variable and you should just use it
> >in that function.
> >
> >s/pdev->dev\./dev->/g
>
> For widely used in future, we plan to put it here and not specific to Keembay function only.
> Any comment on this @Andy Shevchenko?
I'm not sure what comment from me is needed. I'm on the same page with
Michal, i.e. replace current users of &pdev->dev with a new temporary
variable.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-10-08 11:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 2:09 [PATCH v4 0/4] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC muhammad.husaini.zulkifli
2020-10-08 2:09 ` [PATCH v4 1/4] firmware: keembay: Add support for Arm Trusted Firmware Service call muhammad.husaini.zulkifli
2020-10-08 7:35 ` Michal Simek
2020-10-08 8:46 ` Andy Shevchenko
2020-10-08 10:39 ` Zulkifli, Muhammad Husaini
2020-10-08 9:45 ` Sudeep Holla
2020-10-08 12:34 ` Zulkifli, Muhammad Husaini
2020-10-08 2:09 ` [PATCH v4 2/4] dt-bindings: mmc: Add uhs-gpio for Keem Bay UHS-1 Support muhammad.husaini.zulkifli
2020-10-08 7:36 ` Michal Simek
2020-10-08 2:09 ` [PATCH v4 3/4] mmc: sdhci-of-arasan: Add structure device pointer in probe muhammad.husaini.zulkifli
2020-10-08 7:34 ` Michal Simek
2020-10-08 10:36 ` Zulkifli, Muhammad Husaini
2020-10-08 11:12 ` Andy Shevchenko [this message]
2020-10-08 2:09 ` [PATCH v4 4/4] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC muhammad.husaini.zulkifli
2020-10-08 7:36 ` Michal Simek
2020-10-08 9:27 ` Ulf Hansson
2020-10-08 10:54 ` Zulkifli, Muhammad Husaini
2020-10-08 15:19 ` Ulf Hansson
2020-10-08 17:21 ` Zulkifli, Muhammad Husaini
2020-10-09 6:56 ` Ulf Hansson
2020-10-09 7:25 ` Michal Simek
2020-10-09 17:50 ` Zulkifli, Muhammad Husaini
2020-10-13 8:12 ` Zulkifli, Muhammad Husaini
2020-10-13 8:41 ` Ulf Hansson
2020-10-16 7:23 ` Zulkifli, Muhammad Husaini
2020-10-16 10:50 ` Ulf Hansson
2020-11-06 7:16 ` Zulkifli, Muhammad Husaini
2020-11-09 13:36 ` Zulkifli, Muhammad Husaini
2020-10-08 10:58 ` Adrian Hunter
2020-10-08 15:12 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VfRF75uCGD3uAuYBvKi1LZOtVDAfiOHKxDhKr=9LP+nEg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=ulf.hansson@linaro.org \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).