From: Michal Simek <michal.simek@xilinx.com>
To: muhammad.husaini.zulkifli@intel.com, adrian.hunter@intel.com,
michal.simek@xilinx.com, andriy.shevchenko@intel.com,
ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: lakshmi.bai.raja.subramanian@intel.com,
wan.ahmad.zainie.wan.mohamad@intel.com, arnd@arndb.de
Subject: Re: [PATCH v4 1/4] firmware: keembay: Add support for Arm Trusted Firmware Service call
Date: Thu, 8 Oct 2020 09:35:33 +0200 [thread overview]
Message-ID: <f268c578-69f4-3ee4-f5b2-f8b00dd21265@xilinx.com> (raw)
In-Reply-To: <20201008020936.19894-2-muhammad.husaini.zulkifli@intel.com>
On 08. 10. 20 4:09, muhammad.husaini.zulkifli@intel.com wrote:
> From: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
>
> Add header file to handle API function for device driver to communicate
> with Arm Trusted Firmware.
>
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> ---
> .../linux/firmware/intel/keembay_firmware.h | 47 +++++++++++++++++++
> 1 file changed, 47 insertions(+)
> create mode 100644 include/linux/firmware/intel/keembay_firmware.h
>
> diff --git a/include/linux/firmware/intel/keembay_firmware.h b/include/linux/firmware/intel/keembay_firmware.h
> new file mode 100644
> index 000000000000..8a62abcdfead
> --- /dev/null
> +++ b/include/linux/firmware/intel/keembay_firmware.h
> @@ -0,0 +1,47 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Intel Keembay SOC Firmware API Layer
> + *
> + * Copyright (C) 2020-2021, Intel Corporation
> + *
> + * Muhammad Husaini Zulkifli <Muhammad.Husaini.Zulkifli@intel.com>
> + */
> +
> +#ifndef __FIRMWARE_KEEMBAY_SMC_H__
> +#define __FIRMWARE_KEEMBAY_SMC_H__
> +
> +#include <linux/arm-smccc.h>
> +
> +/*
> + * This file defines API function that can be called by device driver in order to
> + * communicate with Arm Trusted Firmware.
> + */
> +
> +/* Setting for Keem Bay IO Pad Line Voltage Selection */
> +#define ARM_SMCCC_SIP_KEEMBAY_SET_SD_VOLTAGE \
> + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, \
> + ARM_SMCCC_SMC_32, \
> + ARM_SMCCC_OWNER_SIP, \
> + 0xFF26)
> +
> +#define KEEMBAY_SET_1V8_VOLT 1
> +#define KEEMBAY_SET_3V3_VOLT 0
> +
> +#if IS_ENABLED(CONFIG_HAVE_ARM_SMCCC_DISCOVERY)
> +static inline int keembay_sd_voltage_selection(int volt)
> +{
> + struct arm_smccc_res res;
> +
> + arm_smccc_1_1_invoke(ARM_SMCCC_SIP_KEEMBAY_SET_SD_VOLTAGE, volt, &res);
> + if ((int)res.a0 < 0)
> + return -EINVAL;
> +
> + return 0;
> +}
> +#else
> +static inline int keembay_sd_voltage_selection(int volt)
> +{
> + return -ENODEV;
> +}
> +#endif
> +#endif /* __FIRMWARE_KEEMBAY_SMC_H__ */
>
This looks good to me.
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
next prev parent reply other threads:[~2020-10-08 7:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 2:09 [PATCH v4 0/4] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC muhammad.husaini.zulkifli
2020-10-08 2:09 ` [PATCH v4 1/4] firmware: keembay: Add support for Arm Trusted Firmware Service call muhammad.husaini.zulkifli
2020-10-08 7:35 ` Michal Simek [this message]
2020-10-08 8:46 ` Andy Shevchenko
2020-10-08 10:39 ` Zulkifli, Muhammad Husaini
2020-10-08 9:45 ` Sudeep Holla
2020-10-08 12:34 ` Zulkifli, Muhammad Husaini
2020-10-08 2:09 ` [PATCH v4 2/4] dt-bindings: mmc: Add uhs-gpio for Keem Bay UHS-1 Support muhammad.husaini.zulkifli
2020-10-08 7:36 ` Michal Simek
2020-10-08 2:09 ` [PATCH v4 3/4] mmc: sdhci-of-arasan: Add structure device pointer in probe muhammad.husaini.zulkifli
2020-10-08 7:34 ` Michal Simek
2020-10-08 10:36 ` Zulkifli, Muhammad Husaini
2020-10-08 11:12 ` Andy Shevchenko
2020-10-08 2:09 ` [PATCH v4 4/4] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC muhammad.husaini.zulkifli
2020-10-08 7:36 ` Michal Simek
2020-10-08 9:27 ` Ulf Hansson
2020-10-08 10:54 ` Zulkifli, Muhammad Husaini
2020-10-08 15:19 ` Ulf Hansson
2020-10-08 17:21 ` Zulkifli, Muhammad Husaini
2020-10-09 6:56 ` Ulf Hansson
2020-10-09 7:25 ` Michal Simek
2020-10-09 17:50 ` Zulkifli, Muhammad Husaini
2020-10-13 8:12 ` Zulkifli, Muhammad Husaini
2020-10-13 8:41 ` Ulf Hansson
2020-10-16 7:23 ` Zulkifli, Muhammad Husaini
2020-10-16 10:50 ` Ulf Hansson
2020-11-06 7:16 ` Zulkifli, Muhammad Husaini
2020-11-09 13:36 ` Zulkifli, Muhammad Husaini
2020-10-08 10:58 ` Adrian Hunter
2020-10-08 15:12 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f268c578-69f4-3ee4-f5b2-f8b00dd21265@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=adrian.hunter@intel.com \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=ulf.hansson@linaro.org \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).