From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Luke Jones <luke@ljones.dev>
Cc: Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/5] asus-wmi: Add support for RGB keyboards
Date: Sat, 6 Aug 2022 13:16:48 +0200 [thread overview]
Message-ID: <CAHp75Vfas8mhAFBt2W002qFx7LCQLVs93v2tRmysS5E28Qiadg@mail.gmail.com> (raw)
In-Reply-To: <DPW6GR.725XHI643Y0N2@ljones.dev>
On Sat, Aug 6, 2022 at 12:49 PM Luke Jones <luke@ljones.dev> wrote:
Please, do not top-post! It's not appreciated in the OSS community(ies).
> I do agree. It's what I meant by prepped. I think I've addressed
> everything you've raised, so I'll leave it to bake a few days with my
> testing then submit new version on Tuesday (Hans please wait for v2).
We are now at the merge window, it means you have enough time to take
review comments and address them carefully, no need to rush. Your
series at the best can be in v6.0, which is 2 months ahead, which
means we have somewhat 6-7 weeks for you to clean up and make the
series better.
> Many thanks for your time taken to review this. I'm not an expert at C
> or the kernel by any stretch so reviews are critical for me. Also thank
> you for the link on git messages - I'll go through each patch and
> ensure they're better.
You are welcome!
> On Sat, Aug 6 2022 at 12:02:19 +0200, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> > On Sat, Aug 6, 2022 at 11:33 AM Luke Jones <luke@ljones.dev> wrote:
> >> On Sat, Aug 6 2022 at 11:10:37 +0200, Andy Shevchenko
> >> <andy.shevchenko@gmail.com> wrote:
...
> >> I do have another version already prepped
> >
> > Hold on and try to address many more review comments. It seems the
> > series needs much more work, otherwise it will be spam in the mailing
> > list and demotivating reviewers to continue.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-08-06 11:17 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 8:19 [PATCH 0/5] asus-wmi: Add support for RGB keyboards Luke D. Jones
2022-08-05 8:19 ` [PATCH 1/5] asus-wmi: Add basic support for TUF laptop keyboard RGB Luke D. Jones
2022-08-06 9:44 ` Andy Shevchenko
2022-08-06 10:16 ` Luke Jones
2022-08-06 10:27 ` Andy Shevchenko
2022-08-06 10:27 ` Andy Shevchenko
2022-08-06 17:30 ` Barnabás Pőcze
2022-08-07 1:54 ` Luke Jones
2022-08-05 8:19 ` [PATCH 2/5] asus-wmi: Add support for TUF laptop keyboard RGB mode control Luke D. Jones
2022-08-06 9:56 ` Andy Shevchenko
2022-08-06 10:33 ` Luke Jones
2022-08-06 11:12 ` Andy Shevchenko
2022-08-05 8:19 ` [PATCH 3/5] asus-wmi: Add support for TUF laptop keyboard states Luke D. Jones
2022-08-05 12:08 ` Pavel Machek
2022-08-05 21:29 ` Luke Jones
2022-08-07 7:44 ` Luke Jones
2022-08-07 12:41 ` Pavel Machek
2022-08-09 23:03 ` Luke Jones
2022-08-05 8:19 ` [PATCH 4/5] asus-wmi: Document many of the undocumented API Luke D. Jones
2022-08-05 21:43 ` kernel test robot
2022-08-06 10:00 ` Andy Shevchenko
2022-08-05 8:19 ` [PATCH 5/5] asus-wmi: Convert all attr _show to use sysfs_emit Luke D. Jones
2022-08-06 10:05 ` Andy Shevchenko
2022-08-05 12:05 ` [PATCH 0/5] asus-wmi: Add support for RGB keyboards Pavel Machek
2022-08-05 21:30 ` Luke Jones
2022-08-06 9:10 ` Andy Shevchenko
2022-08-06 9:32 ` Luke Jones
2022-08-06 9:48 ` Andy Shevchenko
2022-08-06 10:02 ` Andy Shevchenko
2022-08-06 10:48 ` Luke Jones
2022-08-06 11:16 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vfas8mhAFBt2W002qFx7LCQLVs93v2tRmysS5E28Qiadg@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).