From: Luke Jones <luke@ljones.dev>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/5] asus-wmi: Add support for RGB keyboards
Date: Sat, 06 Aug 2022 21:32:43 +1200 [thread overview]
Message-ID: <J6T6GR.SW0RXSJSYG9R1@ljones.dev> (raw)
In-Reply-To: <CAHp75Vd4iEGkAE1Ds_Zyqi0P+gQbOyqvGoJctpOHNmMD7cUG0g@mail.gmail.com>
Hi,
On Sat, Aug 6 2022 at 11:10:37 +0200, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Fri, Aug 5, 2022 at 10:20 AM Luke D. Jones <luke@ljones.dev> wrote:
>>
>> This is a patch series to add RGB support for ASUS laptops.
>> The laptops with this RGB tend to be the TUF series of gamer
>> laptops.
>>
>> The first step is initial bringup of support using the multicolor
>> LED API.
>>
>> These types of keyboards implement a slightly more complex
>> interface than
>> just RGB control however - they also have modes with can be static
>> LED,
>> blinking, rainbow, color cycles, and more. They also have some
>> custom
>> animations that can play depending on device state, such as
>> suspended
>> playing a fancy colour cycle, or playing a "wave" animation.
>>
>> Two of the patches add support for these features.
>>
>> The last patch adds documentation in:
>> Documentation/ABI/testing/sysfs-platform-asus-wmi
>>
>> Some notes:
>>
>> - this patch series obsoletes the previous RGB patches by myself
>>
>> - it is not possible to add attribute groups to multicolor LED as
>> they get overwritten by `led_multicolor_groups` in
>> `led_classdev_multicolor_register_ext`.
>>
>> - the methods for RGB control do not provide a way to fetch
>> exisiting
>> state, so these methods are WO.
>>
>> - There is an existing `asus::kbd_backlight`, this provides a 4-step
>> brightness to the RGB (off,low,med,high) individually to
>> multicolor.
>> I was unsure of the effect of adding a similar path so have used
>> the
>> `asus::multicolour::kbd_backlight` name to be clear about purpose.
>> If the `asus::kbd_backlight` is off, then no RGB is shown at all.\
>>
>> I'm hopeful that this patch series addresses all previous feedback
>> related
>> to the obsoleted patches.
>
> There are so many patches
This is what Hans requested that I do after the previous submissions,
> and versioning of all of this is completely
> broken.
I was unsure how to handle this as the previous patches were
individual, I thought perhaps this patch series is a good place to
restart since the work done is a bit different.
I will try to better track what I do in future.
> You really have to clean up the mess and realize what version
> of this is. To me it looks like this series is v5 or so of the
> previously sent patch(es). Also you missed the changelog between
> versions so we can see what you have done from vX to vX+1 for the
> whole range (1 ... X+1).
As described before I thought this would hopefully be a good point at
which to reset due to the changes requested by Hans which meant that
the underlying structure is different.
I do have another version already prepped, so I will do my best to
address the previous submissions and your concerns in the cover letter
along with a changelog.
>
> --
> With Best Regards,
> Andy Shevchenko
next prev parent reply other threads:[~2022-08-06 9:33 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 8:19 [PATCH 0/5] asus-wmi: Add support for RGB keyboards Luke D. Jones
2022-08-05 8:19 ` [PATCH 1/5] asus-wmi: Add basic support for TUF laptop keyboard RGB Luke D. Jones
2022-08-06 9:44 ` Andy Shevchenko
2022-08-06 10:16 ` Luke Jones
2022-08-06 10:27 ` Andy Shevchenko
2022-08-06 10:27 ` Andy Shevchenko
2022-08-06 17:30 ` Barnabás Pőcze
2022-08-07 1:54 ` Luke Jones
2022-08-05 8:19 ` [PATCH 2/5] asus-wmi: Add support for TUF laptop keyboard RGB mode control Luke D. Jones
2022-08-06 9:56 ` Andy Shevchenko
2022-08-06 10:33 ` Luke Jones
2022-08-06 11:12 ` Andy Shevchenko
2022-08-05 8:19 ` [PATCH 3/5] asus-wmi: Add support for TUF laptop keyboard states Luke D. Jones
2022-08-05 12:08 ` Pavel Machek
2022-08-05 21:29 ` Luke Jones
2022-08-07 7:44 ` Luke Jones
2022-08-07 12:41 ` Pavel Machek
2022-08-09 23:03 ` Luke Jones
2022-08-05 8:19 ` [PATCH 4/5] asus-wmi: Document many of the undocumented API Luke D. Jones
2022-08-05 21:43 ` kernel test robot
2022-08-06 10:00 ` Andy Shevchenko
2022-08-05 8:19 ` [PATCH 5/5] asus-wmi: Convert all attr _show to use sysfs_emit Luke D. Jones
2022-08-06 10:05 ` Andy Shevchenko
2022-08-05 12:05 ` [PATCH 0/5] asus-wmi: Add support for RGB keyboards Pavel Machek
2022-08-05 21:30 ` Luke Jones
2022-08-06 9:10 ` Andy Shevchenko
2022-08-06 9:32 ` Luke Jones [this message]
2022-08-06 9:48 ` Andy Shevchenko
2022-08-06 10:02 ` Andy Shevchenko
2022-08-06 10:48 ` Luke Jones
2022-08-06 11:16 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=J6T6GR.SW0RXSJSYG9R1@ljones.dev \
--to=luke@ljones.dev \
--cc=andy.shevchenko@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).