From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Johan Hovold <johan@kernel.org>,
Finn Thain <fthain@telegraphics.com.au>,
Barry Song <song.bao.hua@hisilicon.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Linux Samsung SOC <linux-samsung-soc@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hector Martin <marcan@marcan.st>, Arnd Bergmann <arnd@kernel.org>
Subject: Re: [PATCH] tty: serial: samsung_tty: remove spinlock flags in interrupt handlers
Date: Tue, 16 Mar 2021 11:40:57 +0200 [thread overview]
Message-ID: <CAHp75VfcbC63t_eZeBOA0NY28BtGBD0YyLR6nSNuKAnKhXTSzA@mail.gmail.com> (raw)
In-Reply-To: <YFB0OcBg3Vj555eA@hovoldconsulting.com>
On Tue, Mar 16, 2021 at 11:02 AM Johan Hovold <johan@kernel.org> wrote:
>
> On Mon, Mar 15, 2021 at 07:12:12PM +0100, Krzysztof Kozlowski wrote:
> > Since interrupt handler is called with disabled local interrupts, there
> > is no need to use the spinlock primitives disabling interrupts as well.
>
> This isn't generally true due to "threadirqs" and that can lead to
> deadlocks if the console code is called from hard irq context.
>
> Now, this is *not* the case for this particular driver since it doesn't
> even bother to take the port lock in console_write(). That should
> probably be fixed instead.
>
> See https://lore.kernel.org/r/X7kviiRwuxvPxC8O@localhost.
Finn, Barry, something to check I think?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-03-16 9:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 18:12 [PATCH] tty: serial: samsung_tty: remove spinlock flags in interrupt handlers Krzysztof Kozlowski
2021-03-15 18:16 ` Andy Shevchenko
2021-03-16 9:02 ` Johan Hovold
2021-03-16 9:40 ` Andy Shevchenko [this message]
2021-03-19 6:36 ` Song Bao Hua (Barry Song)
2021-03-19 8:10 ` Johan Hovold
2021-03-19 10:09 ` Andy Shevchenko
2021-03-19 15:05 ` Johan Hovold
2021-03-16 9:47 ` Krzysztof Kozlowski
2021-03-16 9:56 ` Johan Hovold
2021-03-16 10:11 ` Krzysztof Kozlowski
2021-03-16 11:25 ` Johan Hovold
2021-03-22 11:23 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VfcbC63t_eZeBOA0NY28BtGBD0YyLR6nSNuKAnKhXTSzA@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=arnd@kernel.org \
--cc=fthain@telegraphics.com.au \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=song.bao.hua@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).