* [PATCH v5 1/6] mfd: simple-mfd-i2c: Add Delta TN48M CPLD support
@ 2021-06-07 10:51 Robert Marko
2021-06-07 10:51 ` [PATCH v5 2/6] gpio: Add Delta TN48M CPLD GPIO driver Robert Marko
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Robert Marko @ 2021-06-07 10:51 UTC (permalink / raw)
To: linus.walleij, robh+dt, lee.jones, p.zabel, linux-gpio,
devicetree, linux-kernel, bgolaszewski
Cc: luka.perkov, jmp, pmenzel, buczek, Robert Marko
Delta TN48M switches have a Lattice CPLD that serves
multiple purposes including being a GPIO expander.
So, lets use the simple I2C MFD driver to provide the MFD core.
Also add a virtual symbol which pulls in the simple-mfd-i2c driver and
provide a common symbol on which the subdevice drivers can depend on.
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
---
Changes in v2:
* Drop the custom MFD driver and header
* Use simple I2C MFD driver
drivers/mfd/Kconfig | 10 ++++++++++
drivers/mfd/simple-mfd-i2c.c | 1 +
2 files changed, 11 insertions(+)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index b74efa469e90..733c2f9adb15 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -297,6 +297,16 @@ config MFD_ASIC3
This driver supports the ASIC3 multifunction chip found on many
PDAs (mainly iPAQ and HTC based ones)
+config MFD_TN48M_CPLD
+ tristate "Delta Networks TN48M switch CPLD driver"
+ depends on I2C
+ select MFD_SIMPLE_MFD_I2C
+ help
+ Select this option to enable support for Delta Networks TN48M switch
+ CPLD. It consists of reset and GPIO drivers. CPLD provides GPIOS-s
+ for the SFP slots as well as power supply related information.
+ SFP support depends on the GPIO driver being selected.
+
config PMIC_DA903X
bool "Dialog Semiconductor DA9030/DA9034 PMIC Support"
depends on I2C=y
diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
index 87f684cff9a1..af8e91781417 100644
--- a/drivers/mfd/simple-mfd-i2c.c
+++ b/drivers/mfd/simple-mfd-i2c.c
@@ -39,6 +39,7 @@ static int simple_mfd_i2c_probe(struct i2c_client *i2c)
static const struct of_device_id simple_mfd_i2c_of_match[] = {
{ .compatible = "kontron,sl28cpld" },
+ { .compatible = "delta,tn48m-cpld" },
{}
};
MODULE_DEVICE_TABLE(of, simple_mfd_i2c_of_match);
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v5 2/6] gpio: Add Delta TN48M CPLD GPIO driver
2021-06-07 10:51 [PATCH v5 1/6] mfd: simple-mfd-i2c: Add Delta TN48M CPLD support Robert Marko
@ 2021-06-07 10:51 ` Robert Marko
2021-06-07 12:06 ` Andy Shevchenko
2021-06-07 10:51 ` [PATCH v5 3/6] dt-bindings: reset: Add Delta TN48M Robert Marko
` (3 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Robert Marko @ 2021-06-07 10:51 UTC (permalink / raw)
To: linus.walleij, robh+dt, lee.jones, p.zabel, linux-gpio,
devicetree, linux-kernel, bgolaszewski
Cc: luka.perkov, jmp, pmenzel, buczek, Robert Marko, Andy Shevchenko
Delta TN48M CPLD is used as a GPIO expander for the SFP GPIOs.
It is a mix of input only and output only pins.
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
---
Changes in v2:
* Rewrite to use simple I2C MFD and GPIO regmap
* Drop DT bindings for pin numbering
drivers/gpio/Kconfig | 12 ++++++
drivers/gpio/Makefile | 1 +
drivers/gpio/gpio-tn48m.c | 89 +++++++++++++++++++++++++++++++++++++++
3 files changed, 102 insertions(+)
create mode 100644 drivers/gpio/gpio-tn48m.c
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index e3607ec4c2e8..472f7764508e 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -1310,6 +1310,18 @@ config GPIO_TIMBERDALE
help
Add support for the GPIO IP in the timberdale FPGA.
+config GPIO_TN48M_CPLD
+ tristate "Delta Networks TN48M switch CPLD GPIO driver"
+ depends on MFD_TN48M_CPLD
+ select GPIO_REGMAP
+ help
+ This enables support for the GPIOs found on the Delta
+ Networks TN48M switch CPLD.
+ They are used for inputs and outputs on the SFP slots.
+
+ This driver can also be built as a module. If so, the
+ module will be called gpio-tn48m.
+
config GPIO_TPS65086
tristate "TI TPS65086 GPO"
depends on MFD_TPS65086
diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
index c58a90a3c3b1..271fb806475e 100644
--- a/drivers/gpio/Makefile
+++ b/drivers/gpio/Makefile
@@ -145,6 +145,7 @@ obj-$(CONFIG_GPIO_TEGRA186) += gpio-tegra186.o
obj-$(CONFIG_GPIO_TEGRA) += gpio-tegra.o
obj-$(CONFIG_GPIO_THUNDERX) += gpio-thunderx.o
obj-$(CONFIG_GPIO_TIMBERDALE) += gpio-timberdale.o
+obj-$(CONFIG_GPIO_TN48M_CPLD) += gpio-tn48m.o
obj-$(CONFIG_GPIO_TPIC2810) += gpio-tpic2810.o
obj-$(CONFIG_GPIO_TPS65086) += gpio-tps65086.o
obj-$(CONFIG_GPIO_TPS65218) += gpio-tps65218.o
diff --git a/drivers/gpio/gpio-tn48m.c b/drivers/gpio/gpio-tn48m.c
new file mode 100644
index 000000000000..41484c002826
--- /dev/null
+++ b/drivers/gpio/gpio-tn48m.c
@@ -0,0 +1,89 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Delta TN48M CPLD GPIO driver
+ *
+ * Copyright 2021 Sartura Ltd
+ *
+ * Author: Robert Marko <robert.marko@sartura.hr>
+ */
+
+#include <linux/device.h>
+#include <linux/gpio/driver.h>
+#include <linux/gpio/regmap.h>
+#include <linux/kernel.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+
+enum tn48m_gpio_type {
+ TN48M_SFP_TX_DISABLE = 1,
+ TN48M_SFP_PRESENT,
+ TN48M_SFP_LOS,
+};
+
+static int tn48m_gpio_probe(struct platform_device *pdev)
+{
+ struct gpio_regmap_config config = {0};
+ enum tn48m_gpio_type type;
+ struct regmap *regmap;
+ u32 base;
+ int ret;
+
+ if (!pdev->dev.parent)
+ return -ENODEV;
+
+ type = (uintptr_t)device_get_match_data(&pdev->dev);
+ if (!type)
+ return -ENODEV;
+
+ ret = device_property_read_u32(&pdev->dev, "reg", &base);
+ if (ret)
+ return -EINVAL;
+
+ regmap = dev_get_regmap(pdev->dev.parent, NULL);
+ if (!regmap)
+ return -ENODEV;
+
+ config.regmap = regmap;
+ config.parent = &pdev->dev;
+ config.ngpio = 4;
+
+ switch (type) {
+ case TN48M_SFP_TX_DISABLE:
+ config.reg_set_base = base;
+ break;
+ case TN48M_SFP_PRESENT:
+ config.reg_dat_base = base;
+ break;
+ case TN48M_SFP_LOS:
+ config.reg_dat_base = base;
+ break;
+ default:
+ dev_err(&pdev->dev, "unknown type %d\n", type);
+ return -ENODEV;
+ }
+
+ return PTR_ERR_OR_ZERO(devm_gpio_regmap_register(&pdev->dev, &config));
+}
+
+static const struct of_device_id tn48m_gpio_of_match[] = {
+ { .compatible = "delta,tn48m-gpio-sfp-tx-disable", .data = (void *)TN48M_SFP_TX_DISABLE },
+ { .compatible = "delta,tn48m-gpio-sfp-present", .data = (void *)TN48M_SFP_PRESENT },
+ { .compatible = "delta,tn48m-gpio-sfp-los", .data = (void *)TN48M_SFP_LOS },
+ { }
+};
+MODULE_DEVICE_TABLE(of, tn48m_gpio_of_match);
+
+static struct platform_driver tn48m_gpio_driver = {
+ .driver = {
+ .name = "delta-tn48m-gpio",
+ .of_match_table = tn48m_gpio_of_match,
+ },
+ .probe = tn48m_gpio_probe,
+};
+module_platform_driver(tn48m_gpio_driver);
+
+MODULE_AUTHOR("Robert Marko <robert.marko@sartura.hr>");
+MODULE_DESCRIPTION("Delta TN48M CPLD GPIO driver");
+MODULE_LICENSE("GPL");
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v5 3/6] dt-bindings: reset: Add Delta TN48M
2021-06-07 10:51 [PATCH v5 1/6] mfd: simple-mfd-i2c: Add Delta TN48M CPLD support Robert Marko
2021-06-07 10:51 ` [PATCH v5 2/6] gpio: Add Delta TN48M CPLD GPIO driver Robert Marko
@ 2021-06-07 10:51 ` Robert Marko
2021-06-07 10:51 ` [PATCH v5 4/6] reset: Add Delta TN48M CPLD reset controller Robert Marko
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Robert Marko @ 2021-06-07 10:51 UTC (permalink / raw)
To: linus.walleij, robh+dt, lee.jones, p.zabel, linux-gpio,
devicetree, linux-kernel, bgolaszewski
Cc: luka.perkov, jmp, pmenzel, buczek, Robert Marko
Add header for the Delta TN48M CPLD provided
resets.
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
include/dt-bindings/reset/delta,tn48m-reset.h | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
create mode 100644 include/dt-bindings/reset/delta,tn48m-reset.h
diff --git a/include/dt-bindings/reset/delta,tn48m-reset.h b/include/dt-bindings/reset/delta,tn48m-reset.h
new file mode 100644
index 000000000000..659a3f6c4d47
--- /dev/null
+++ b/include/dt-bindings/reset/delta,tn48m-reset.h
@@ -0,0 +1,20 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Delta TN48M CPLD GPIO driver
+ *
+ * Copyright 2021 Sartura Ltd
+ *
+ * Author: Robert Marko <robert.marko@sartura.hr>
+ */
+
+#ifndef _DT_BINDINGS_RESET_TN48M_H
+#define _DT_BINDINGS_RESET_TN48M_H
+
+#define CPU_88F7040_RESET 0
+#define CPU_88F6820_RESET 1
+#define MAC_98DX3265_RESET 2
+#define PHY_88E1680_RESET 3
+#define PHY_88E1512_RESET 4
+#define POE_RESET 5
+
+#endif /* _DT_BINDINGS_RESET_TN48M_H */
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v5 4/6] reset: Add Delta TN48M CPLD reset controller
2021-06-07 10:51 [PATCH v5 1/6] mfd: simple-mfd-i2c: Add Delta TN48M CPLD support Robert Marko
2021-06-07 10:51 ` [PATCH v5 2/6] gpio: Add Delta TN48M CPLD GPIO driver Robert Marko
2021-06-07 10:51 ` [PATCH v5 3/6] dt-bindings: reset: Add Delta TN48M Robert Marko
@ 2021-06-07 10:51 ` Robert Marko
2021-06-07 10:51 ` [PATCH v5 5/6] dt-bindings: mfd: Add Delta TN48M CPLD drivers bindings Robert Marko
2021-06-07 10:51 ` [PATCH v5 6/6] MAINTAINERS: Add Delta Networks TN48M CPLD drivers Robert Marko
4 siblings, 0 replies; 8+ messages in thread
From: Robert Marko @ 2021-06-07 10:51 UTC (permalink / raw)
To: linus.walleij, robh+dt, lee.jones, p.zabel, linux-gpio,
devicetree, linux-kernel, bgolaszewski
Cc: luka.perkov, jmp, pmenzel, buczek, Robert Marko
Delta TN48M CPLD exposes resets for the following:
* 88F7040 SoC
* 88F6820 SoC
* 98DX3265 switch MAC-s
* 88E1680 PHY-s
* 88E1512 PHY
* PoE PSE controller
Controller supports only self clearing resets.
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
---
Changes in v5:
* Allow COMPILE_TEST as well
* Default to MFD_TN48M_CPLD
Changes in v4:
* Drop assert and deassert as only self-clearing
resets are support by the HW
* Make sure that reset is cleared before returning
from reset.
drivers/reset/Kconfig | 10 +++
drivers/reset/Makefile | 1 +
drivers/reset/reset-tn48m.c | 128 ++++++++++++++++++++++++++++++++++++
3 files changed, 139 insertions(+)
create mode 100644 drivers/reset/reset-tn48m.c
diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig
index 4171c6f76385..b647bb945597 100644
--- a/drivers/reset/Kconfig
+++ b/drivers/reset/Kconfig
@@ -237,6 +237,16 @@ config RESET_TI_SYSCON
you wish to use the reset framework for such memory-mapped devices,
say Y here. Otherwise, say N.
+config RESET_TN48M_CPLD
+ tristate "Delta Networks TN48M switch CPLD reset controller"
+ depends on MFD_TN48M_CPLD || COMPILE_TEST
+ default MFD_TN48M_CPLD
+ help
+ This enables the reset controller driver for the Delta TN48M CPLD.
+ It provides reset signals for Armada 7040 and 385 SoC-s, Alleycat 3X
+ switch MAC-s, Alaska OOB ethernet PHY, Quad Alaska ethernet PHY-s and
+ Microchip PD69200 PoE PSE controller.
+
config RESET_UNIPHIER
tristate "Reset controller driver for UniPhier SoCs"
depends on ARCH_UNIPHIER || COMPILE_TEST
diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile
index 65a118a91b27..d048498e6566 100644
--- a/drivers/reset/Makefile
+++ b/drivers/reset/Makefile
@@ -31,6 +31,7 @@ obj-$(CONFIG_RESET_SOCFPGA) += reset-socfpga.o
obj-$(CONFIG_RESET_SUNXI) += reset-sunxi.o
obj-$(CONFIG_RESET_TI_SCI) += reset-ti-sci.o
obj-$(CONFIG_RESET_TI_SYSCON) += reset-ti-syscon.o
+obj-$(CONFIG_RESET_TN48M_CPLD) += reset-tn48m.o
obj-$(CONFIG_RESET_UNIPHIER) += reset-uniphier.o
obj-$(CONFIG_RESET_UNIPHIER_GLUE) += reset-uniphier-glue.o
obj-$(CONFIG_RESET_ZYNQ) += reset-zynq.o
diff --git a/drivers/reset/reset-tn48m.c b/drivers/reset/reset-tn48m.c
new file mode 100644
index 000000000000..fa6fd7ddbdfb
--- /dev/null
+++ b/drivers/reset/reset-tn48m.c
@@ -0,0 +1,128 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Delta TN48M CPLD reset driver
+ *
+ * Copyright 2021 Sartura Ltd
+ *
+ * Author: Robert Marko <robert.marko@sartura.hr>
+ */
+
+#include <linux/device.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/platform_device.h>
+#include <linux/regmap.h>
+#include <linux/reset-controller.h>
+
+#include <dt-bindings/reset/delta,tn48m-reset.h>
+
+#define TN48M_RESET_REG 0x10
+
+#define TN48M_RESET_TIMEOUT 125000
+#define TN48M_RESET_SLEEP 10
+
+struct tn48_reset_map {
+ u8 bit;
+};
+
+struct tn48_reset_data {
+ struct reset_controller_dev rcdev;
+ struct regmap *regmap;
+};
+
+static const struct tn48_reset_map tn48m_resets[] = {
+ [CPU_88F7040_RESET] = {0},
+ [CPU_88F6820_RESET] = {1},
+ [MAC_98DX3265_RESET] = {2},
+ [PHY_88E1680_RESET] = {4},
+ [PHY_88E1512_RESET] = {6},
+ [POE_RESET] = {7},
+};
+
+static inline struct tn48_reset_data *to_tn48_reset_data(
+ struct reset_controller_dev *rcdev)
+{
+ return container_of(rcdev, struct tn48_reset_data, rcdev);
+}
+
+static int tn48m_control_reset(struct reset_controller_dev *rcdev,
+ unsigned long id)
+{
+ struct tn48_reset_data *data = to_tn48_reset_data(rcdev);
+ unsigned int val;
+
+ regmap_update_bits(data->regmap, TN48M_RESET_REG,
+ BIT(tn48m_resets[id].bit), 0);
+
+ return regmap_read_poll_timeout(data->regmap,
+ TN48M_RESET_REG,
+ val,
+ val & BIT(tn48m_resets[id].bit),
+ TN48M_RESET_SLEEP,
+ TN48M_RESET_TIMEOUT);
+}
+
+static int tn48m_control_status(struct reset_controller_dev *rcdev,
+ unsigned long id)
+{
+ struct tn48_reset_data *data = to_tn48_reset_data(rcdev);
+ unsigned int regval;
+ int ret;
+
+ ret = regmap_read(data->regmap, TN48M_RESET_REG, ®val);
+ if (ret < 0)
+ return ret;
+
+ if (BIT(tn48m_resets[id].bit) & regval)
+ return 0;
+ else
+ return 1;
+}
+
+static const struct reset_control_ops tn48_reset_ops = {
+ .reset = tn48m_control_reset,
+ .status = tn48m_control_status,
+};
+
+static int tn48m_reset_probe(struct platform_device *pdev)
+{
+ struct tn48_reset_data *data;
+ struct regmap *regmap;
+
+ regmap = dev_get_regmap(pdev->dev.parent, NULL);
+ if (!regmap)
+ return -ENODEV;
+
+ data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
+ if (!data)
+ return -ENOMEM;
+
+ data->regmap = regmap;
+
+ data->rcdev.owner = THIS_MODULE;
+ data->rcdev.ops = &tn48_reset_ops;
+ data->rcdev.nr_resets = ARRAY_SIZE(tn48m_resets);
+ data->rcdev.of_node = pdev->dev.of_node;
+
+ return devm_reset_controller_register(&pdev->dev, &data->rcdev);
+}
+
+static const struct of_device_id tn48m_reset_of_match[] = {
+ { .compatible = "delta,tn48m-reset", },
+ { }
+};
+MODULE_DEVICE_TABLE(of, tn48m_reset_of_match);
+
+static struct platform_driver tn48m_reset_driver = {
+ .driver = {
+ .name = "delta-tn48m-reset",
+ .of_match_table = tn48m_reset_of_match,
+ },
+ .probe = tn48m_reset_probe,
+};
+module_platform_driver(tn48m_reset_driver);
+
+MODULE_AUTHOR("Robert Marko <robert.marko@sartura.hr>");
+MODULE_DESCRIPTION("Delta TN48M CPLD reset driver");
+MODULE_LICENSE("GPL");
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v5 5/6] dt-bindings: mfd: Add Delta TN48M CPLD drivers bindings
2021-06-07 10:51 [PATCH v5 1/6] mfd: simple-mfd-i2c: Add Delta TN48M CPLD support Robert Marko
` (2 preceding siblings ...)
2021-06-07 10:51 ` [PATCH v5 4/6] reset: Add Delta TN48M CPLD reset controller Robert Marko
@ 2021-06-07 10:51 ` Robert Marko
2021-06-07 10:51 ` [PATCH v5 6/6] MAINTAINERS: Add Delta Networks TN48M CPLD drivers Robert Marko
4 siblings, 0 replies; 8+ messages in thread
From: Robert Marko @ 2021-06-07 10:51 UTC (permalink / raw)
To: linus.walleij, robh+dt, lee.jones, p.zabel, linux-gpio,
devicetree, linux-kernel, bgolaszewski
Cc: luka.perkov, jmp, pmenzel, buczek, Robert Marko
Add binding documents for the Delta TN48M CPLD drivers.
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
Changes in v3:
* Include bindings for reset driver
Changes in v2:
* Implement MFD as a simple I2C MFD
* Add GPIO bindings as separate
.../bindings/gpio/delta,tn48m-gpio.yaml | 42 +++++++++
.../bindings/mfd/delta,tn48m-cpld.yaml | 90 +++++++++++++++++++
.../bindings/reset/delta,tn48m-reset.yaml | 35 ++++++++
3 files changed, 167 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/delta,tn48m-gpio.yaml
create mode 100644 Documentation/devicetree/bindings/mfd/delta,tn48m-cpld.yaml
create mode 100644 Documentation/devicetree/bindings/reset/delta,tn48m-reset.yaml
diff --git a/Documentation/devicetree/bindings/gpio/delta,tn48m-gpio.yaml b/Documentation/devicetree/bindings/gpio/delta,tn48m-gpio.yaml
new file mode 100644
index 000000000000..aca646aecb12
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/delta,tn48m-gpio.yaml
@@ -0,0 +1,42 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/delta,tn48m-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Delta Networks TN48M CPLD GPIO controller
+
+maintainers:
+ - Robert Marko <robert.marko@sartura.hr>
+
+description: |
+ This module is part of the Delta TN48M multi-function device. For more
+ details see ../mfd/delta,tn48m-cpld.yaml.
+
+ GPIO controller module provides GPIO-s for the SFP slots.
+ It is split into 3 controllers, one output only for the SFP TX disable
+ pins, one input only for the SFP present pins and one input only for
+ the SFP LOS pins.
+
+properties:
+ compatible:
+ enum:
+ - delta,tn48m-gpio-sfp-tx-disable
+ - delta,tn48m-gpio-sfp-present
+ - delta,tn48m-gpio-sfp-los
+
+ reg:
+ maxItems: 1
+
+ "#gpio-cells":
+ const: 2
+
+ gpio-controller: true
+
+required:
+ - compatible
+ - reg
+ - "#gpio-cells"
+ - gpio-controller
+
+additionalProperties: false
diff --git a/Documentation/devicetree/bindings/mfd/delta,tn48m-cpld.yaml b/Documentation/devicetree/bindings/mfd/delta,tn48m-cpld.yaml
new file mode 100644
index 000000000000..2c6e2adf73ca
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/delta,tn48m-cpld.yaml
@@ -0,0 +1,90 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/delta,tn48m-cpld.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Delta Networks TN48M CPLD controller
+
+maintainers:
+ - Robert Marko <robert.marko@sartura.hr>
+
+description: |
+ Lattice CPLD onboard the TN48M switches is used for system
+ management.
+
+ It provides information about the hardware model, revision,
+ PSU status etc.
+
+ It is also being used as a GPIO expander for the SFP slots and
+ reset controller for the switch MAC-s and other peripherals.
+
+properties:
+ compatible:
+ const: delta,tn48m-cpld
+
+ reg:
+ description:
+ I2C device address.
+ maxItems: 1
+
+ "#address-cells":
+ const: 1
+
+ "#size-cells":
+ const: 0
+
+required:
+ - compatible
+ - reg
+ - "#address-cells"
+ - "#size-cells"
+
+patternProperties:
+ "^gpio(@[0-9a-f]+)?$":
+ $ref: ../gpio/delta,tn48m-gpio.yaml
+
+ "^reset-controller?$":
+ $ref: ../reset/delta,tn48m-reset.yaml
+
+additionalProperties: false
+
+examples:
+ - |
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ cpld@41 {
+ compatible = "delta,tn48m-cpld";
+ reg = <0x41>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ gpio@31 {
+ compatible = "delta,tn48m-gpio-sfp-tx-disable";
+ reg = <0x31>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ gpio@3a {
+ compatible = "delta,tn48m-gpio-sfp-present";
+ reg = <0x3a>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ gpio@40 {
+ compatible = "delta,tn48m-gpio-sfp-los";
+ reg = <0x40>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ reset-controller {
+ compatible = "delta,tn48m-reset";
+ #reset-cells = <1>;
+ };
+ };
+ };
diff --git a/Documentation/devicetree/bindings/reset/delta,tn48m-reset.yaml b/Documentation/devicetree/bindings/reset/delta,tn48m-reset.yaml
new file mode 100644
index 000000000000..0e5ee8decc0d
--- /dev/null
+++ b/Documentation/devicetree/bindings/reset/delta,tn48m-reset.yaml
@@ -0,0 +1,35 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/reset/delta,tn48m-reset.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Delta Networks TN48M CPLD reset controller
+
+maintainers:
+ - Robert Marko <robert.marko@sartura.hr>
+
+description: |
+ This module is part of the Delta TN48M multi-function device. For more
+ details see ../mfd/delta,tn48m-cpld.yaml.
+
+ Reset controller modules provides resets for the following:
+ * 88F7040 SoC
+ * 88F6820 SoC
+ * 98DX3265 switch MAC-s
+ * 88E1680 PHY-s
+ * 88E1512 PHY
+ * PoE PSE controller
+
+properties:
+ compatible:
+ const: delta,tn48m-reset
+
+ "#reset-cells":
+ const: 1
+
+required:
+ - compatible
+ - "#reset-cells"
+
+additionalProperties: false
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v5 6/6] MAINTAINERS: Add Delta Networks TN48M CPLD drivers
2021-06-07 10:51 [PATCH v5 1/6] mfd: simple-mfd-i2c: Add Delta TN48M CPLD support Robert Marko
` (3 preceding siblings ...)
2021-06-07 10:51 ` [PATCH v5 5/6] dt-bindings: mfd: Add Delta TN48M CPLD drivers bindings Robert Marko
@ 2021-06-07 10:51 ` Robert Marko
4 siblings, 0 replies; 8+ messages in thread
From: Robert Marko @ 2021-06-07 10:51 UTC (permalink / raw)
To: linus.walleij, robh+dt, lee.jones, p.zabel, linux-gpio,
devicetree, linux-kernel, bgolaszewski
Cc: luka.perkov, jmp, pmenzel, buczek, Robert Marko
Add maintainers entry for the Delta Networks TN48M
CPLD MFD drivers.
Signed-off-by: Robert Marko <robert.marko@sartura.hr>
---
Changes in v3:
* Add reset driver documentation
Changes in v2:
* Drop no more existing files
MAINTAINERS | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 9450e052f1b1..82d9c2943c34 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5096,6 +5096,15 @@ W: https://linuxtv.org
T: git git://linuxtv.org/media_tree.git
F: drivers/media/platform/sti/delta
+DELTA NETWORKS TN48M CPLD DRIVERS
+M: Robert Marko <robert.marko@sartura.hr>
+S: Maintained
+F: Documentation/devicetree/bindings/gpio/delta,tn48m-gpio.yaml
+F: Documentation/devicetree/bindings/mfd/delta,tn48m-cpld.yaml
+F: Documentation/devicetree/bindings/reset/delta,tn48m-reset.yaml
+F: drivers/gpio/gpio-tn48m.c
+F: include/dt-bindings/reset/delta,tn48m-reset.h
+
DENALI NAND DRIVER
L: linux-mtd@lists.infradead.org
S: Orphan
--
2.31.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v5 2/6] gpio: Add Delta TN48M CPLD GPIO driver
2021-06-07 10:51 ` [PATCH v5 2/6] gpio: Add Delta TN48M CPLD GPIO driver Robert Marko
@ 2021-06-07 12:06 ` Andy Shevchenko
2021-06-07 12:23 ` Robert Marko
0 siblings, 1 reply; 8+ messages in thread
From: Andy Shevchenko @ 2021-06-07 12:06 UTC (permalink / raw)
To: Robert Marko
Cc: Linus Walleij, Rob Herring, Lee Jones, Philipp Zabel,
open list:GPIO SUBSYSTEM, devicetree, Linux Kernel Mailing List,
Bartosz Golaszewski, Luka Perkov, jmp, Paul Menzel, buczek
On Mon, Jun 7, 2021 at 1:51 PM Robert Marko <robert.marko@sartura.hr> wrote:
>
> Delta TN48M CPLD is used as a GPIO expander for the SFP GPIOs.
>
> It is a mix of input only and output only pins.
>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Couple of small issues below.
Otherwise looks good!
> ---
> Changes in v2:
> * Rewrite to use simple I2C MFD and GPIO regmap
> * Drop DT bindings for pin numbering
>
> drivers/gpio/Kconfig | 12 ++++++
> drivers/gpio/Makefile | 1 +
> drivers/gpio/gpio-tn48m.c | 89 +++++++++++++++++++++++++++++++++++++++
> 3 files changed, 102 insertions(+)
> create mode 100644 drivers/gpio/gpio-tn48m.c
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index e3607ec4c2e8..472f7764508e 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1310,6 +1310,18 @@ config GPIO_TIMBERDALE
> help
> Add support for the GPIO IP in the timberdale FPGA.
>
> +config GPIO_TN48M_CPLD
> + tristate "Delta Networks TN48M switch CPLD GPIO driver"
> + depends on MFD_TN48M_CPLD
> + select GPIO_REGMAP
> + help
> + This enables support for the GPIOs found on the Delta
> + Networks TN48M switch CPLD.
> + They are used for inputs and outputs on the SFP slots.
> +
> + This driver can also be built as a module. If so, the
> + module will be called gpio-tn48m.
> +
> config GPIO_TPS65086
> tristate "TI TPS65086 GPO"
> depends on MFD_TPS65086
> diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
> index c58a90a3c3b1..271fb806475e 100644
> --- a/drivers/gpio/Makefile
> +++ b/drivers/gpio/Makefile
> @@ -145,6 +145,7 @@ obj-$(CONFIG_GPIO_TEGRA186) += gpio-tegra186.o
> obj-$(CONFIG_GPIO_TEGRA) += gpio-tegra.o
> obj-$(CONFIG_GPIO_THUNDERX) += gpio-thunderx.o
> obj-$(CONFIG_GPIO_TIMBERDALE) += gpio-timberdale.o
> +obj-$(CONFIG_GPIO_TN48M_CPLD) += gpio-tn48m.o
> obj-$(CONFIG_GPIO_TPIC2810) += gpio-tpic2810.o
> obj-$(CONFIG_GPIO_TPS65086) += gpio-tps65086.o
> obj-$(CONFIG_GPIO_TPS65218) += gpio-tps65218.o
> diff --git a/drivers/gpio/gpio-tn48m.c b/drivers/gpio/gpio-tn48m.c
> new file mode 100644
> index 000000000000..41484c002826
> --- /dev/null
> +++ b/drivers/gpio/gpio-tn48m.c
> @@ -0,0 +1,89 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Delta TN48M CPLD GPIO driver
> + *
> + * Copyright 2021 Sartura Ltd
> + *
> + * Author: Robert Marko <robert.marko@sartura.hr>
> + */
> +
> +#include <linux/device.h>
> +#include <linux/gpio/driver.h>
> +#include <linux/gpio/regmap.h>
> +#include <linux/kernel.h>
What is this header for?
> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
> +
> +enum tn48m_gpio_type {
> + TN48M_SFP_TX_DISABLE = 1,
> + TN48M_SFP_PRESENT,
> + TN48M_SFP_LOS,
> +};
> +
> +static int tn48m_gpio_probe(struct platform_device *pdev)
> +{
> + struct gpio_regmap_config config = {0};
> + enum tn48m_gpio_type type;
> + struct regmap *regmap;
> + u32 base;
> + int ret;
> +
> + if (!pdev->dev.parent)
> + return -ENODEV;
> +
> + type = (uintptr_t)device_get_match_data(&pdev->dev);
> + if (!type)
> + return -ENODEV;
> +
> + ret = device_property_read_u32(&pdev->dev, "reg", &base);
> + if (ret)
> + return -EINVAL;
return ret;
> + regmap = dev_get_regmap(pdev->dev.parent, NULL);
> + if (!regmap)
> + return -ENODEV;
> +
> + config.regmap = regmap;
> + config.parent = &pdev->dev;
> + config.ngpio = 4;
> +
> + switch (type) {
> + case TN48M_SFP_TX_DISABLE:
> + config.reg_set_base = base;
> + break;
> + case TN48M_SFP_PRESENT:
> + config.reg_dat_base = base;
> + break;
> + case TN48M_SFP_LOS:
> + config.reg_dat_base = base;
> + break;
> + default:
> + dev_err(&pdev->dev, "unknown type %d\n", type);
> + return -ENODEV;
> + }
> +
> + return PTR_ERR_OR_ZERO(devm_gpio_regmap_register(&pdev->dev, &config));
> +}
> +
> +static const struct of_device_id tn48m_gpio_of_match[] = {
> + { .compatible = "delta,tn48m-gpio-sfp-tx-disable", .data = (void *)TN48M_SFP_TX_DISABLE },
> + { .compatible = "delta,tn48m-gpio-sfp-present", .data = (void *)TN48M_SFP_PRESENT },
> + { .compatible = "delta,tn48m-gpio-sfp-los", .data = (void *)TN48M_SFP_LOS },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, tn48m_gpio_of_match);
> +
> +static struct platform_driver tn48m_gpio_driver = {
> + .driver = {
> + .name = "delta-tn48m-gpio",
> + .of_match_table = tn48m_gpio_of_match,
> + },
> + .probe = tn48m_gpio_probe,
> +};
> +module_platform_driver(tn48m_gpio_driver);
> +
> +MODULE_AUTHOR("Robert Marko <robert.marko@sartura.hr>");
> +MODULE_DESCRIPTION("Delta TN48M CPLD GPIO driver");
> +MODULE_LICENSE("GPL");
> --
> 2.31.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v5 2/6] gpio: Add Delta TN48M CPLD GPIO driver
2021-06-07 12:06 ` Andy Shevchenko
@ 2021-06-07 12:23 ` Robert Marko
0 siblings, 0 replies; 8+ messages in thread
From: Robert Marko @ 2021-06-07 12:23 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Linus Walleij, Rob Herring, Lee Jones, Philipp Zabel,
open list:GPIO SUBSYSTEM, devicetree, Linux Kernel Mailing List,
Bartosz Golaszewski, Luka Perkov, jmp, Paul Menzel,
Donald Buczek
On Mon, Jun 7, 2021 at 2:06 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> On Mon, Jun 7, 2021 at 1:51 PM Robert Marko <robert.marko@sartura.hr> wrote:
> >
> > Delta TN48M CPLD is used as a GPIO expander for the SFP GPIOs.
> >
> > It is a mix of input only and output only pins.
> >
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>
> Couple of small issues below.
> Otherwise looks good!
>
> > ---
> > Changes in v2:
> > * Rewrite to use simple I2C MFD and GPIO regmap
> > * Drop DT bindings for pin numbering
> >
> > drivers/gpio/Kconfig | 12 ++++++
> > drivers/gpio/Makefile | 1 +
> > drivers/gpio/gpio-tn48m.c | 89 +++++++++++++++++++++++++++++++++++++++
> > 3 files changed, 102 insertions(+)
> > create mode 100644 drivers/gpio/gpio-tn48m.c
> >
> > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> > index e3607ec4c2e8..472f7764508e 100644
> > --- a/drivers/gpio/Kconfig
> > +++ b/drivers/gpio/Kconfig
> > @@ -1310,6 +1310,18 @@ config GPIO_TIMBERDALE
> > help
> > Add support for the GPIO IP in the timberdale FPGA.
> >
> > +config GPIO_TN48M_CPLD
> > + tristate "Delta Networks TN48M switch CPLD GPIO driver"
> > + depends on MFD_TN48M_CPLD
> > + select GPIO_REGMAP
> > + help
> > + This enables support for the GPIOs found on the Delta
> > + Networks TN48M switch CPLD.
> > + They are used for inputs and outputs on the SFP slots.
> > +
> > + This driver can also be built as a module. If so, the
> > + module will be called gpio-tn48m.
> > +
> > config GPIO_TPS65086
> > tristate "TI TPS65086 GPO"
> > depends on MFD_TPS65086
> > diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
> > index c58a90a3c3b1..271fb806475e 100644
> > --- a/drivers/gpio/Makefile
> > +++ b/drivers/gpio/Makefile
> > @@ -145,6 +145,7 @@ obj-$(CONFIG_GPIO_TEGRA186) += gpio-tegra186.o
> > obj-$(CONFIG_GPIO_TEGRA) += gpio-tegra.o
> > obj-$(CONFIG_GPIO_THUNDERX) += gpio-thunderx.o
> > obj-$(CONFIG_GPIO_TIMBERDALE) += gpio-timberdale.o
> > +obj-$(CONFIG_GPIO_TN48M_CPLD) += gpio-tn48m.o
> > obj-$(CONFIG_GPIO_TPIC2810) += gpio-tpic2810.o
> > obj-$(CONFIG_GPIO_TPS65086) += gpio-tps65086.o
> > obj-$(CONFIG_GPIO_TPS65218) += gpio-tps65218.o
> > diff --git a/drivers/gpio/gpio-tn48m.c b/drivers/gpio/gpio-tn48m.c
> > new file mode 100644
> > index 000000000000..41484c002826
> > --- /dev/null
> > +++ b/drivers/gpio/gpio-tn48m.c
> > @@ -0,0 +1,89 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/*
> > + * Delta TN48M CPLD GPIO driver
> > + *
> > + * Copyright 2021 Sartura Ltd
> > + *
> > + * Author: Robert Marko <robert.marko@sartura.hr>
> > + */
> > +
> > +#include <linux/device.h>
> > +#include <linux/gpio/driver.h>
> > +#include <linux/gpio/regmap.h>
>
> > +#include <linux/kernel.h>
>
> What is this header for?
Its not being actually used,
I will drop it.
>
> > +#include <linux/mod_devicetable.h>
> > +#include <linux/module.h>
> > +#include <linux/platform_device.h>
> > +#include <linux/regmap.h>
> > +
> > +enum tn48m_gpio_type {
> > + TN48M_SFP_TX_DISABLE = 1,
> > + TN48M_SFP_PRESENT,
> > + TN48M_SFP_LOS,
> > +};
> > +
> > +static int tn48m_gpio_probe(struct platform_device *pdev)
> > +{
> > + struct gpio_regmap_config config = {0};
> > + enum tn48m_gpio_type type;
> > + struct regmap *regmap;
> > + u32 base;
> > + int ret;
> > +
> > + if (!pdev->dev.parent)
> > + return -ENODEV;
> > +
> > + type = (uintptr_t)device_get_match_data(&pdev->dev);
> > + if (!type)
> > + return -ENODEV;
> > +
> > + ret = device_property_read_u32(&pdev->dev, "reg", &base);
> > + if (ret)
>
> > + return -EINVAL;
>
> return ret;
Will fix this and send v6 in a couple of minutes.
Thanks,
Robert
>
> > + regmap = dev_get_regmap(pdev->dev.parent, NULL);
> > + if (!regmap)
> > + return -ENODEV;
> > +
> > + config.regmap = regmap;
> > + config.parent = &pdev->dev;
> > + config.ngpio = 4;
> > +
> > + switch (type) {
> > + case TN48M_SFP_TX_DISABLE:
> > + config.reg_set_base = base;
> > + break;
> > + case TN48M_SFP_PRESENT:
> > + config.reg_dat_base = base;
> > + break;
> > + case TN48M_SFP_LOS:
> > + config.reg_dat_base = base;
> > + break;
> > + default:
> > + dev_err(&pdev->dev, "unknown type %d\n", type);
> > + return -ENODEV;
> > + }
> > +
> > + return PTR_ERR_OR_ZERO(devm_gpio_regmap_register(&pdev->dev, &config));
> > +}
> > +
> > +static const struct of_device_id tn48m_gpio_of_match[] = {
> > + { .compatible = "delta,tn48m-gpio-sfp-tx-disable", .data = (void *)TN48M_SFP_TX_DISABLE },
> > + { .compatible = "delta,tn48m-gpio-sfp-present", .data = (void *)TN48M_SFP_PRESENT },
> > + { .compatible = "delta,tn48m-gpio-sfp-los", .data = (void *)TN48M_SFP_LOS },
> > + { }
> > +};
> > +MODULE_DEVICE_TABLE(of, tn48m_gpio_of_match);
> > +
> > +static struct platform_driver tn48m_gpio_driver = {
> > + .driver = {
> > + .name = "delta-tn48m-gpio",
> > + .of_match_table = tn48m_gpio_of_match,
> > + },
> > + .probe = tn48m_gpio_probe,
> > +};
> > +module_platform_driver(tn48m_gpio_driver);
> > +
> > +MODULE_AUTHOR("Robert Marko <robert.marko@sartura.hr>");
> > +MODULE_DESCRIPTION("Delta TN48M CPLD GPIO driver");
> > +MODULE_LICENSE("GPL");
> > --
> > 2.31.1
> >
>
>
> --
> With Best Regards,
> Andy Shevchenko
--
Robert Marko
Staff Embedded Linux Engineer
Sartura Ltd.
Lendavska ulica 16a
10000 Zagreb, Croatia
Email: robert.marko@sartura.hr
Web: www.sartura.hr
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-06-07 12:24 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-07 10:51 [PATCH v5 1/6] mfd: simple-mfd-i2c: Add Delta TN48M CPLD support Robert Marko
2021-06-07 10:51 ` [PATCH v5 2/6] gpio: Add Delta TN48M CPLD GPIO driver Robert Marko
2021-06-07 12:06 ` Andy Shevchenko
2021-06-07 12:23 ` Robert Marko
2021-06-07 10:51 ` [PATCH v5 3/6] dt-bindings: reset: Add Delta TN48M Robert Marko
2021-06-07 10:51 ` [PATCH v5 4/6] reset: Add Delta TN48M CPLD reset controller Robert Marko
2021-06-07 10:51 ` [PATCH v5 5/6] dt-bindings: mfd: Add Delta TN48M CPLD drivers bindings Robert Marko
2021-06-07 10:51 ` [PATCH v5 6/6] MAINTAINERS: Add Delta Networks TN48M CPLD drivers Robert Marko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).