* Re: PVPANIC PCI driver
[not found] <faa7532b-e345-c125-4db9-13d3b6bc372f@oracle.com>
@ 2021-01-20 17:08 ` Andy Shevchenko
0 siblings, 0 replies; only message in thread
From: Andy Shevchenko @ 2021-01-20 17:08 UTC (permalink / raw)
To: Mihai Carabas, Linux Kernel Mailing List, Peng Hao
+Cc: LKML and Peng
On Wed, Jan 20, 2021 at 6:48 PM Mihai Carabas <mihai.carabas@oracle.com> wrote:
>
> Hello Andy,
>
> Some time ago you have created a patchset where you have combined
> ACPI/MMIO into a single driver for pvpanic:
>
> commit f104060813fe79350565b68c1098fcea050a6504
> Author: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Date: Wed Dec 9 22:36:41 2020 +0200
>
> misc: pvpanic: Combine ACPI and platform drivers
>
> I also have sent some patches where I created a driver framework for
> adding a PCI driver. These being said, I want to send again another
> patchset to add a PVPANIC PCI driver, but I am not sure what is the
> right approach you would like to see:
> - create a totally different driver for pvpanic pci and naming it
> pvpanic-pci.c with its config PVPANIC_PCI
> - create the framework I have sent before but having only two buses
> (ACPI/MMIO in one file and PCI in another)
Generic approach is to have three files:
- core part
- platform driver
- PCI driver
in this case.
> In qemu they are basically two different devices (one is -device pvpanic
> and the other is -device pvpanic-pci)
>
> I could not find any precedence in other drivers. Your input is welcome.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-01-20 17:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <faa7532b-e345-c125-4db9-13d3b6bc372f@oracle.com>
2021-01-20 17:08 ` PVPANIC PCI driver Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).