* [PATCH] media: atomisp: Fix runtime PM imbalance in atomisp_pci_probe
@ 2021-04-08 8:18 Dinghao Liu
2021-04-08 9:50 ` Andy Shevchenko
0 siblings, 1 reply; 2+ messages in thread
From: Dinghao Liu @ 2021-04-08 8:18 UTC (permalink / raw)
To: dinghao.liu, kjlu
Cc: Mauro Carvalho Chehab, Sakari Ailus, Greg Kroah-Hartman,
Andy Shevchenko, linux-media, linux-staging, linux-kernel
When hmm_pool_register() fails, a pairing PM usage counter
increment is needed to keep the counter balanced. It's the
same for the following error paths.
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
index 0295e2e32d79..02f774ed80c8 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
@@ -1815,6 +1815,7 @@ static int atomisp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
hmm_cleanup();
hmm_pool_unregister(HMM_POOL_TYPE_RESERVED);
hmm_pool_fail:
+ pm_runtime_get_noresume(&pdev->dev);
destroy_workqueue(isp->wdt_work_queue);
wdt_work_queue_fail:
atomisp_acc_cleanup(isp);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: atomisp: Fix runtime PM imbalance in atomisp_pci_probe
2021-04-08 8:18 [PATCH] media: atomisp: Fix runtime PM imbalance in atomisp_pci_probe Dinghao Liu
@ 2021-04-08 9:50 ` Andy Shevchenko
0 siblings, 0 replies; 2+ messages in thread
From: Andy Shevchenko @ 2021-04-08 9:50 UTC (permalink / raw)
To: Dinghao Liu
Cc: Kangjie Lu, Mauro Carvalho Chehab, Sakari Ailus,
Greg Kroah-Hartman, Andy Shevchenko, Linux Media Mailing List,
linux-staging, Linux Kernel Mailing List
On Thu, Apr 8, 2021 at 11:19 AM Dinghao Liu <dinghao.liu@zju.edu.cn> wrote:
>
> When hmm_pool_register() fails, a pairing PM usage counter
> increment is needed to keep the counter balanced. It's the
> same for the following error paths.
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
> drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> index 0295e2e32d79..02f774ed80c8 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c
> @@ -1815,6 +1815,7 @@ static int atomisp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
> hmm_cleanup();
> hmm_pool_unregister(HMM_POOL_TYPE_RESERVED);
> hmm_pool_fail:
> + pm_runtime_get_noresume(&pdev->dev);
> destroy_workqueue(isp->wdt_work_queue);
> wdt_work_queue_fail:
> atomisp_acc_cleanup(isp);
> --
> 2.17.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-08 9:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 8:18 [PATCH] media: atomisp: Fix runtime PM imbalance in atomisp_pci_probe Dinghao Liu
2021-04-08 9:50 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).