* [PATCH] platform/x86: intel_pmc_core: Mark local function static
@ 2019-03-26 20:29 Guenter Roeck
2019-03-27 12:46 ` Bhardwaj, Rajneesh
0 siblings, 1 reply; 5+ messages in thread
From: Guenter Roeck @ 2019-03-26 20:29 UTC (permalink / raw)
To: Rajneesh Bhardwaj
Cc: Vishwanath Somayaji, Darren Hart, Andy Shevchenko,
platform-driver-x86, linux-kernel, Guenter Roeck,
Rajneesh Bhardwaj
0day reports:
drivers/platform/x86/intel_pmc_core.c:833:5: sparse:
symbol 'quirk_xtal_ignore' was not declared. Should it be static?
Mark the function static since it is indeed only called locally.
Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
Fixes: 238f9c11351f ("platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/platform/x86/intel_pmc_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
index f2c621b55f49..9908d233305e 100644
--- a/drivers/platform/x86/intel_pmc_core.c
+++ b/drivers/platform/x86/intel_pmc_core.c
@@ -828,7 +828,7 @@ static const struct pci_device_id pmc_pci_ids[] = {
* the platform BIOS enforces 24Mhx Crystal to shutdown
* before PMC can assert SLP_S0#.
*/
-int quirk_xtal_ignore(const struct dmi_system_id *id)
+static int quirk_xtal_ignore(const struct dmi_system_id *id)
{
struct pmc_dev *pmcdev = &pmc;
u32 value;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] platform/x86: intel_pmc_core: Mark local function static
2019-03-26 20:29 [PATCH] platform/x86: intel_pmc_core: Mark local function static Guenter Roeck
@ 2019-03-27 12:46 ` Bhardwaj, Rajneesh
2019-04-05 14:45 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Bhardwaj, Rajneesh @ 2019-03-27 12:46 UTC (permalink / raw)
To: Guenter Roeck, Rajneesh Bhardwaj
Cc: Vishwanath Somayaji, Darren Hart, Andy Shevchenko,
platform-driver-x86, linux-kernel
On 27-Mar-19 1:59 AM, Guenter Roeck wrote:
> 0day reports:
>
> drivers/platform/x86/intel_pmc_core.c:833:5: sparse:
> symbol 'quirk_xtal_ignore' was not declared. Should it be static?
Looks good to me.
> Mark the function static since it is indeed only called locally.
>
> Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
> Fixes: 238f9c11351f ("platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown")
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/platform/x86/intel_pmc_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
> index f2c621b55f49..9908d233305e 100644
> --- a/drivers/platform/x86/intel_pmc_core.c
> +++ b/drivers/platform/x86/intel_pmc_core.c
> @@ -828,7 +828,7 @@ static const struct pci_device_id pmc_pci_ids[] = {
> * the platform BIOS enforces 24Mhx Crystal to shutdown
> * before PMC can assert SLP_S0#.
> */
> -int quirk_xtal_ignore(const struct dmi_system_id *id)
> +static int quirk_xtal_ignore(const struct dmi_system_id *id)
> {
> struct pmc_dev *pmcdev = &pmc;
> u32 value;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] platform/x86: intel_pmc_core: Mark local function static
2019-03-27 12:46 ` Bhardwaj, Rajneesh
@ 2019-04-05 14:45 ` Andy Shevchenko
2019-04-05 14:49 ` Bhardwaj, Rajneesh
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2019-04-05 14:45 UTC (permalink / raw)
To: Bhardwaj, Rajneesh
Cc: Guenter Roeck, Rajneesh Bhardwaj, Vishwanath Somayaji,
Darren Hart, Andy Shevchenko, Platform Driver,
Linux Kernel Mailing List
On Wed, Mar 27, 2019 at 2:47 PM Bhardwaj, Rajneesh
<rajneesh.bhardwaj@linux.intel.com> wrote:
>
>
> On 27-Mar-19 1:59 AM, Guenter Roeck wrote:
> > 0day reports:
> >
> > drivers/platform/x86/intel_pmc_core.c:833:5: sparse:
> > symbol 'quirk_xtal_ignore' was not declared. Should it be static?
>
> Looks good to me.
Please, give a corresponding tag.
Meanwhile I will apply it to my review and testing queue for robots to
play with, thanks!
>
> > Mark the function static since it is indeed only called locally.
> >
> > Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
> > Fixes: 238f9c11351f ("platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown")
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> > drivers/platform/x86/intel_pmc_core.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
> > index f2c621b55f49..9908d233305e 100644
> > --- a/drivers/platform/x86/intel_pmc_core.c
> > +++ b/drivers/platform/x86/intel_pmc_core.c
> > @@ -828,7 +828,7 @@ static const struct pci_device_id pmc_pci_ids[] = {
> > * the platform BIOS enforces 24Mhx Crystal to shutdown
> > * before PMC can assert SLP_S0#.
> > */
> > -int quirk_xtal_ignore(const struct dmi_system_id *id)
> > +static int quirk_xtal_ignore(const struct dmi_system_id *id)
> > {
> > struct pmc_dev *pmcdev = &pmc;
> > u32 value;
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] platform/x86: intel_pmc_core: Mark local function static
2019-04-05 14:45 ` Andy Shevchenko
@ 2019-04-05 14:49 ` Bhardwaj, Rajneesh
2019-04-05 16:23 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Bhardwaj, Rajneesh @ 2019-04-05 14:49 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Guenter Roeck, Rajneesh Bhardwaj, Vishwanath Somayaji,
Darren Hart, Andy Shevchenko, Platform Driver,
Linux Kernel Mailing List
Sending again as i got delivery failure notification from the mailing
list for some reason.
On 05-Apr-19 8:15 PM, Andy Shevchenko wrote:
> On Wed, Mar 27, 2019 at 2:47 PM Bhardwaj, Rajneesh
> <rajneesh.bhardwaj@linux.intel.com> wrote:
>>
>> On 27-Mar-19 1:59 AM, Guenter Roeck wrote:
>>> 0day reports:
>>>
>>> drivers/platform/x86/intel_pmc_core.c:833:5: sparse:
>>> symbol 'quirk_xtal_ignore' was not declared. Should it be static?
>> Looks good to me.
> Please, give a corresponding tag.
> Meanwhile I will apply it to my review and testing queue for robots to
> play with, thanks!
Sure.
Acked-by: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
>>> Mark the function static since it is indeed only called locally.
>>>
>>> Cc: Rajneesh Bhardwaj <rajneesh.bhardwaj@linux.intel.com>
>>> Fixes: 238f9c11351f ("platform/x86: intel_pmc_core: Quirk to ignore XTAL shutdown")
>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>> ---
>>> drivers/platform/x86/intel_pmc_core.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
>>> index f2c621b55f49..9908d233305e 100644
>>> --- a/drivers/platform/x86/intel_pmc_core.c
>>> +++ b/drivers/platform/x86/intel_pmc_core.c
>>> @@ -828,7 +828,7 @@ static const struct pci_device_id pmc_pci_ids[] = {
>>> * the platform BIOS enforces 24Mhx Crystal to shutdown
>>> * before PMC can assert SLP_S0#.
>>> */
>>> -int quirk_xtal_ignore(const struct dmi_system_id *id)
>>> +static int quirk_xtal_ignore(const struct dmi_system_id *id)
>>> {
>>> struct pmc_dev *pmcdev = &pmc;
>>> u32 value;
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] platform/x86: intel_pmc_core: Mark local function static
2019-04-05 14:49 ` Bhardwaj, Rajneesh
@ 2019-04-05 16:23 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2019-04-05 16:23 UTC (permalink / raw)
To: Bhardwaj, Rajneesh
Cc: Guenter Roeck, Rajneesh Bhardwaj, Vishwanath Somayaji,
Darren Hart, Andy Shevchenko, Platform Driver,
Linux Kernel Mailing List
On Fri, Apr 5, 2019 at 5:49 PM Bhardwaj, Rajneesh
<rajneesh.bhardwaj@linux.intel.com> wrote:
> Sending again as i got delivery failure notification from the mailing
> list for some reason.
Mailing list doesn't accept HTML as was your previous message.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-04-05 16:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-26 20:29 [PATCH] platform/x86: intel_pmc_core: Mark local function static Guenter Roeck
2019-03-27 12:46 ` Bhardwaj, Rajneesh
2019-04-05 14:45 ` Andy Shevchenko
2019-04-05 14:49 ` Bhardwaj, Rajneesh
2019-04-05 16:23 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).