linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhi Li <lznuaa@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
	Frank Li <Frank.Li@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	acme@kernel.org, alexander.shishkin@linux.intel.com,
	Mark Rutland <mark.rutland@arm.com>,
	jerry shen <jerry.zhengyu.shen@gmail.com>,
	Zhengyu Shen <zhengyu.shen@nxp.com>
Subject: Re: [PATCH 1/1 v7] ARM: imx: Added perf functionality to mmdc driver
Date: Tue, 8 Nov 2016 14:18:42 -0600	[thread overview]
Message-ID: <CAHrpEqSxhsemUFLB1AQ1xAaOZ14jdtsUFiMPyky1i+g7SuuRUg@mail.gmail.com> (raw)
In-Reply-To: <20161108201114.GQ3117@twins.programming.kicks-ass.net>

On Tue, Nov 8, 2016 at 2:11 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> On Tue, Nov 08, 2016 at 01:21:47PM -0600, Zhi Li wrote:
>> On Tue, Nov 8, 2016 at 1:00 PM, Paul Gortmaker
>> > I just noticed this commit now that linux-next is back after the week off.
>> >
>> > This should probably use core_param or setup_param since the Kconfig
>> > for this is bool and not tristate.
>
>
>> I think pmu_pmu_poll_period_us should be removed because no benefit to
>> change it.
>> I can delete .remove
>
> Why not make it tristate ?

The based code provided a function, which need by suspend and resume.

best regards
Frank Li

      reply	other threads:[~2016-11-08 20:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-19 17:47 [PATCH 1/1 v7] ARM: imx: Added perf functionality to mmdc driver Frank Li
2016-11-08 19:00 ` Paul Gortmaker
2016-11-08 19:21   ` Zhi Li
2016-11-08 20:11     ` Peter Zijlstra
2016-11-08 20:18       ` Zhi Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHrpEqSxhsemUFLB1AQ1xAaOZ14jdtsUFiMPyky1i+g7SuuRUg@mail.gmail.com \
    --to=lznuaa@gmail.com \
    --cc=Frank.Li@nxp.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jerry.zhengyu.shen@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=peterz@infradead.org \
    --cc=shawnguo@kernel.org \
    --cc=zhengyu.shen@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).