* [PATCH v2 bpf-next] samples/bpf: xdpsock: order memory on AArch64
@ 2018-07-25 21:08 Brian Brooks
2018-07-26 12:18 ` Björn Töpel
2018-07-27 1:48 ` Daniel Borkmann
0 siblings, 2 replies; 3+ messages in thread
From: Brian Brooks @ 2018-07-25 21:08 UTC (permalink / raw)
To: ast, daniel, bjorn.topel, magnus.karlsson
Cc: netdev, linux-kernel, Brian Brooks
Define u_smp_rmb() and u_smp_wmb() to respective barrier instructions.
This ensures the processor will order accesses to queue indices against
accesses to queue ring entries.
Signed-off-by: Brian Brooks <brian.brooks@linaro.org>
---
samples/bpf/xdpsock_user.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c
index 5904b1543831..1e82f7c617c3 100644
--- a/samples/bpf/xdpsock_user.c
+++ b/samples/bpf/xdpsock_user.c
@@ -145,8 +145,13 @@ static void dump_stats(void);
} while (0)
#define barrier() __asm__ __volatile__("": : :"memory")
+#ifdef __aarch64__
+#define u_smp_rmb() __asm__ __volatile__("dmb ishld": : :"memory")
+#define u_smp_wmb() __asm__ __volatile__("dmb ishst": : :"memory")
+#else
#define u_smp_rmb() barrier()
#define u_smp_wmb() barrier()
+#endif
#define likely(x) __builtin_expect(!!(x), 1)
#define unlikely(x) __builtin_expect(!!(x), 0)
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 bpf-next] samples/bpf: xdpsock: order memory on AArch64
2018-07-25 21:08 [PATCH v2 bpf-next] samples/bpf: xdpsock: order memory on AArch64 Brian Brooks
@ 2018-07-26 12:18 ` Björn Töpel
2018-07-27 1:48 ` Daniel Borkmann
1 sibling, 0 replies; 3+ messages in thread
From: Björn Töpel @ 2018-07-26 12:18 UTC (permalink / raw)
To: Brian Brooks
Cc: ast, Daniel Borkmann, Björn Töpel, Karlsson, Magnus,
Netdev, LKML
Den ons 25 juli 2018 kl 23:09 skrev Brian Brooks <brian.brooks@linaro.org>:
>
> Define u_smp_rmb() and u_smp_wmb() to respective barrier instructions.
> This ensures the processor will order accesses to queue indices against
> accesses to queue ring entries.
>
Thanks Brian!
Acked-by: Björn Töpel <bjorn.topel@intel.com>
> Signed-off-by: Brian Brooks <brian.brooks@linaro.org>
> ---
> samples/bpf/xdpsock_user.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/samples/bpf/xdpsock_user.c b/samples/bpf/xdpsock_user.c
> index 5904b1543831..1e82f7c617c3 100644
> --- a/samples/bpf/xdpsock_user.c
> +++ b/samples/bpf/xdpsock_user.c
> @@ -145,8 +145,13 @@ static void dump_stats(void);
> } while (0)
>
> #define barrier() __asm__ __volatile__("": : :"memory")
> +#ifdef __aarch64__
> +#define u_smp_rmb() __asm__ __volatile__("dmb ishld": : :"memory")
> +#define u_smp_wmb() __asm__ __volatile__("dmb ishst": : :"memory")
> +#else
> #define u_smp_rmb() barrier()
> #define u_smp_wmb() barrier()
> +#endif
> #define likely(x) __builtin_expect(!!(x), 1)
> #define unlikely(x) __builtin_expect(!!(x), 0)
>
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 bpf-next] samples/bpf: xdpsock: order memory on AArch64
2018-07-25 21:08 [PATCH v2 bpf-next] samples/bpf: xdpsock: order memory on AArch64 Brian Brooks
2018-07-26 12:18 ` Björn Töpel
@ 2018-07-27 1:48 ` Daniel Borkmann
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Borkmann @ 2018-07-27 1:48 UTC (permalink / raw)
To: Brian Brooks, ast, bjorn.topel, magnus.karlsson; +Cc: netdev, linux-kernel
On 07/25/2018 11:08 PM, Brian Brooks wrote:
> Define u_smp_rmb() and u_smp_wmb() to respective barrier instructions.
> This ensures the processor will order accesses to queue indices against
> accesses to queue ring entries.
>
> Signed-off-by: Brian Brooks <brian.brooks@linaro.org>
Applied to bpf-next, thanks Brian!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-27 1:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-25 21:08 [PATCH v2 bpf-next] samples/bpf: xdpsock: order memory on AArch64 Brian Brooks
2018-07-26 12:18 ` Björn Töpel
2018-07-27 1:48 ` Daniel Borkmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).