* [PATCH] TDA1997x: fix tda1997x_query_dv_timings() return value
@ 2021-07-26 10:46 Krzysztof Hałasa
2021-08-19 16:48 ` Tim Harvey
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Hałasa @ 2021-07-26 10:46 UTC (permalink / raw)
To: Tim Harvey; +Cc: Mauro Carvalho Chehab, linux-media, linux-kernel
Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c
index 043cc8275d00..cbfe58e413e9 100644
--- a/drivers/media/i2c/tda1997x.c
+++ b/drivers/media/i2c/tda1997x.c
@@ -1695,14 +1695,15 @@ static int tda1997x_query_dv_timings(struct v4l2_subdev *sd,
struct v4l2_dv_timings *timings)
{
struct tda1997x_state *state = to_state(sd);
+ int ret;
v4l_dbg(1, debug, state->client, "%s\n", __func__);
memset(timings, 0, sizeof(struct v4l2_dv_timings));
mutex_lock(&state->lock);
- tda1997x_detect_std(state, timings);
+ ret = tda1997x_detect_std(state, timings);
mutex_unlock(&state->lock);
- return 0;
+ return ret;
}
static const struct v4l2_subdev_video_ops tda1997x_video_ops = {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] TDA1997x: fix tda1997x_query_dv_timings() return value
2021-07-26 10:46 [PATCH] TDA1997x: fix tda1997x_query_dv_timings() return value Krzysztof Hałasa
@ 2021-08-19 16:48 ` Tim Harvey
0 siblings, 0 replies; 2+ messages in thread
From: Tim Harvey @ 2021-08-19 16:48 UTC (permalink / raw)
To: Krzysztof Hałasa; +Cc: Mauro Carvalho Chehab, linux-media, open list
On Mon, Jul 26, 2021 at 3:46 AM Krzysztof Hałasa <khalasa@piap.pl> wrote:
>
> Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl>
>
> diff --git a/drivers/media/i2c/tda1997x.c b/drivers/media/i2c/tda1997x.c
> index 043cc8275d00..cbfe58e413e9 100644
> --- a/drivers/media/i2c/tda1997x.c
> +++ b/drivers/media/i2c/tda1997x.c
> @@ -1695,14 +1695,15 @@ static int tda1997x_query_dv_timings(struct v4l2_subdev *sd,
> struct v4l2_dv_timings *timings)
> {
> struct tda1997x_state *state = to_state(sd);
> + int ret;
>
> v4l_dbg(1, debug, state->client, "%s\n", __func__);
> memset(timings, 0, sizeof(struct v4l2_dv_timings));
> mutex_lock(&state->lock);
> - tda1997x_detect_std(state, timings);
> + ret = tda1997x_detect_std(state, timings);
> mutex_unlock(&state->lock);
>
> - return 0;
> + return ret;
> }
>
> static const struct v4l2_subdev_video_ops tda1997x_video_ops = {
Krzysztof,
Patch looks good to me but needs a commit log.
Best regards,
Tim
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-19 16:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-26 10:46 [PATCH] TDA1997x: fix tda1997x_query_dv_timings() return value Krzysztof Hałasa
2021-08-19 16:48 ` Tim Harvey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).