linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] devfreq: Fix build break of devfreq-event class
@ 2015-01-30  4:54 Chanwoo Choi
  2015-01-30  9:09 ` MyungJoo Ham
  0 siblings, 1 reply; 2+ messages in thread
From: Chanwoo Choi @ 2015-01-30  4:54 UTC (permalink / raw)
  To: rafael.j.wysocki, myungjoo.ham
  Cc: kyungmin.park, cw00.choi, linux-pm, linux-kernel, Rafael J. Wysocki

This patch fixes the build break of the exynos-ppmu driver because Makefile
in drivers/devfreq don't include the entry of devfreq-event.c driver.

The original patch[1] includes the entry to build devfreq-event.c without
the build break. This build break is generated in the process of merging the
patch.
[1] https://lkml.org/lkml/2015/1/25/579
- [PATCH v10 1/7] devfreq: event: Add new devfreq_event class to provide basic
                  data for devfreq governor

CC      init/version.o
LD      init/built-in.o
drivers/built-in.o: In function `exynos_ppmu_probe':
binder.c:(.text+0x4447ec): undefined reference to `devm_devfreq_event_add_edev'
make: *** [vmlinux] Error 1

Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
---
 drivers/devfreq/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile
index 9256c35..5134f9e 100644
--- a/drivers/devfreq/Makefile
+++ b/drivers/devfreq/Makefile
@@ -1,4 +1,5 @@
 obj-$(CONFIG_PM_DEVFREQ)	+= devfreq.o
+obj-$(CONFIG_PM_DEVFREQ_EVENT)	+= devfreq-event.o
 obj-$(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND)	+= governor_simpleondemand.o
 obj-$(CONFIG_DEVFREQ_GOV_PERFORMANCE)	+= governor_performance.o
 obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE)	+= governor_powersave.o
-- 
1.8.5.5


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] devfreq: Fix build break of devfreq-event class
  2015-01-30  4:54 [PATCH] devfreq: Fix build break of devfreq-event class Chanwoo Choi
@ 2015-01-30  9:09 ` MyungJoo Ham
  0 siblings, 0 replies; 2+ messages in thread
From: MyungJoo Ham @ 2015-01-30  9:09 UTC (permalink / raw)
  To: Chanwoo Choi
  Cc: rafael.j.wysocki, Kyungmin Park, Linux PM list, LKML, Rafael J. Wysocki

On Fri, Jan 30, 2015 at 1:54 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> This patch fixes the build break of the exynos-ppmu driver because Makefile
> in drivers/devfreq don't include the entry of devfreq-event.c driver.
>
> The original patch[1] includes the entry to build devfreq-event.c without
> the build break. This build break is generated in the process of merging the
> patch.
> [1] https://lkml.org/lkml/2015/1/25/579
> - [PATCH v10 1/7] devfreq: event: Add new devfreq_event class to provide basic
>                   data for devfreq governor

Sorry, that one is already included in the for-rafael tree with
tags/pull_req_20150129. :)


>
> CC      init/version.o
> LD      init/built-in.o
> drivers/built-in.o: In function `exynos_ppmu_probe':
> binder.c:(.text+0x4447ec): undefined reference to `devm_devfreq_event_add_edev'
> make: *** [vmlinux] Error 1
>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
> ---
>  drivers/devfreq/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/devfreq/Makefile b/drivers/devfreq/Makefile
> index 9256c35..5134f9e 100644
> --- a/drivers/devfreq/Makefile
> +++ b/drivers/devfreq/Makefile
> @@ -1,4 +1,5 @@
>  obj-$(CONFIG_PM_DEVFREQ)       += devfreq.o
> +obj-$(CONFIG_PM_DEVFREQ_EVENT) += devfreq-event.o
>  obj-$(CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND)      += governor_simpleondemand.o
>  obj-$(CONFIG_DEVFREQ_GOV_PERFORMANCE)  += governor_performance.o
>  obj-$(CONFIG_DEVFREQ_GOV_POWERSAVE)    += governor_powersave.o
> --
> 1.8.5.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
MyungJoo Ham, Ph.D.
Frontier CS Lab, S/W Center, Samsung Electronics

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-30  9:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-30  4:54 [PATCH] devfreq: Fix build break of devfreq-event class Chanwoo Choi
2015-01-30  9:09 ` MyungJoo Ham

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).