linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ver_linux: reiserfsprogs.patch
@ 2015-10-01 18:24 Alexander Kapshuk
  0 siblings, 0 replies; only message in thread
From: Alexander Kapshuk @ 2015-10-01 18:24 UTC (permalink / raw)
  To: linux-kernel; +Cc: Greg KH

The current implementation uses both 'grep' and 'awk' for text processing
here, which may be alright as a quick solution to be run on the command
line. While in a script, 'sed' or 'awk' would be a better choice. On
top of that, the current implementation expects the version number to
be found in the last field as seen by 'awk'. Should the output format
be different, this approach would no longer be reliable.

The proposed implementation uses 'sed' as a more flexible tool to handle
varying output formats.


Tested on:
Arch Linux

Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---

--- linux/scripts/ver_linux.orig    2015-08-30 21:34:09.000000000 +0300
+++ linux/scripts/ver_linux    2015-09-30 22:44:27.421829120 +0300
@@ -33,8 +33,13 @@
 fsck.jfs -V 2>&1 | grep version | sed 's/,//' |  awk \
 'NR==1 {print "jfsutils              ", $3}'

-reiserfsck -V 2>&1 | grep ^reiserfsck | awk \
-'NR==1{print "reiserfsprogs         ", $2}'
+reiserfsck -V 2>&1 |
+sed '
+    /^reiserfsck/!d
+    s/[^0-9\.]//g
+    /^$/d
+    s/^/reiserfsprogs\t/
+'

 fsck.reiser4 -V 2>&1 | grep ^fsck.reiser4 | awk \
 'NR==1{print "reiser4progs          ", $2}'

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-10-01 18:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-01 18:24 [PATCH] ver_linux: reiserfsprogs.patch Alexander Kapshuk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).