linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* ver_linux: proposed implementation feedback request
@ 2015-10-05 17:00 Alexander Kapshuk
  2015-10-06  8:11 ` Greg KH
  2015-10-07  1:25 ` Theodore Ts'o
  0 siblings, 2 replies; 5+ messages in thread
From: Alexander Kapshuk @ 2015-10-05 17:00 UTC (permalink / raw)
  To: linux-kernel; +Cc: Jim Davis, richard, Theodore Ts'o, Greg KH

Thanks very much for everyone's feedback.

Instead of flooding this mailing list with another bunch of ver_linux
patches, I thought I would post another implementation, and see if you
find any of the proposed changes worth submitting as a patch. I will
be happy with whatever feedback you can give me. And we will leave it
at that. Thanks.
--------------------------------------------------------------------------------
#!/bin/sh
# Before running this script please ensure that your PATH is
# typical as you use for compilation/istallation. I use
# /bin /sbin /usr/bin /usr/sbin /usr/local/bin, but it may
# differ on your system.
#
echo 'If some fields are empty or look unusual you may have an old version.'
echo 'Compare to the current minimal requirements in Documentation/Changes.'
echo ' '

uname -a
echo ' '

gcc -dumpversion 2>&1 |
awk '/([0-9]+([\.])?)+/{
        match($0, /([0-9]+([\.])?)+/)
        printf("GNU C\t\t\t%s\n",
            substr($0,RSTART,RLENGTH))
}'

make --version 2>&1 |
awk '/GNU Make/{
        match($0, /([0-9]+([\.])?)+/)
        printf("GNU Make\t\t%s\n",
            substr($0,RSTART,RLENGTH))
}'

ld -v 2>&1 |
awk '/([0-9]+([\.])?)+/{
        match($0, /([0-9]+([\.])?)+/)
        printf("Binutils\t\t%s\n",
            substr($0,RSTART,RLENGTH))
}'

mount --version 2>&1 |
awk '/([0-9]+([\.])?)+/{
        match($0, /([0-9]+([\.])?)+/)
        $0 = substr($0,RSTART,RLENGTH)
        printf("Util-linux\t\t%s\nMount\t\t\t%s\n",$0,$0)
}'


depmod -V  2>&1 |
awk '/([0-9]+([\.])?)+/{
        match($0, /([0-9]+([\.])?)+/)
        printf("Module-init-tools\t%s\n",
            substr($0,RSTART,RLENGTH))
}'

tune2fs 2>&1 |
awk '/^tune2fs/{
        match($0, /([0-9]+([\.])?[0-9]+)+/)
        printf("E2fsprogs\t\t%s\n",
            substr($0,RSTART,RLENGTH))
}'

fsck.jfs -V 2>&1 |
awk '/version/{
        match($0, /([0-9]+([\.])?)+/)
        printf("Jfsutils\t\t%s\n",
            substr($0,RSTART,RLENGTH))
}'

fsck.reiser4 -V 2>&1 |
awk '/^reiserfsck/{
        match($0, /([0-9]+([\.])?)+/)
        printf("Reiserfsprogs\t\t%s\n",
            substr($0,RSTART,RLENGTH))
}'

fsck.reiser4 -V 2>&1 | grep ^fsck.reiser4 | awk \
'NR==1{print "reiser4progs          ", $2}'


xfs_db -V 2>&1 |
awk '/version/{
        match($0, /([0-9]+([\.])?)+/)
        printf("Xfsprogs\t\t%s\n",
            substr($0,RSTART,RLENGTH))
}'

pccardctl -V 2>&1 |
awk '/pcmciautils/{
        match($0, /([0-9]+([\.])?)+/)
        printf("Pcmciautils\t\t%s\n",
            substr($0,RSTART,RLENGTH))
}'


cardmgr -V 2>&1| grep version | awk \
'NR==1{print "pcmcia-cs             ", $3}'

quota -V 2>&1 |
awk '/version/{
        match($0, /([0-9]+([\.])?)+/)
        printf("Quota-tools\t\t%s\n",
            substr($0,RSTART,RLENGTH-1))
}'

pppd --version 2>&1 |
awk '/version/{
        match($0, /([0-9]+([\.])?)+/)
        printf("PPP\t\t%s\n",
            substr($0,RSTART,RLENGTH))
}'

isdnctrl 2>&1 | grep version | awk \
'NR==1{print "isdn4k-utils          ", $NF}'

showmount --version 2>&1 | grep nfs-utils | awk \
'NR==1{print "nfs-utils             ", $NF}'

test -r /proc/self/maps &&
sed '
    /.*libc-\(.*\)\.so$/!d
    s//Linux C Library\t\t\1/
    q
' /proc/self/maps

ldd --version 2>&1 |
awk '/^ldd/{
        match($0, /([0-9]+([\.])?)+/)
        printf("Dynamic linker (ldd)\t%s\n",
            substr($0,RSTART,RLENGTH))
}'

libcpp=`ldconfig -p 2>/dev/null |
    awk '/(libg|stdc)[+]+\.so/ {
    print $NF
    exit
    }
'`
test -r "$libcpp" &&
ls -l $libcpp |
sed '
    s!.*so\.!!
    s!^!Linux C++ Library\t!
'

ps --version 2>&1 |
awk '/version/{
        match($0, /([0-9]+([\.])?)+/)
        printf("Procps\t\t\t%s\n",
            substr($0,RSTART,RLENGTH))
}'

ifconfig --version 2>&1 |
awk '/tools/{
        match($0, /([0-9]+([\.])?)+/)
        printf("Net-tools\t\t%s\n",
            substr($0,RSTART,RLENGTH))
}'

loadkeys -V 2>&1 |
awk '/([0-9]+([\.])?)+/{
        match($0, /([0-9]+([\.])?)+/)
        $0 = substr($0,RSTART,RLENGTH)
        printf("Kbd\t\t\t%s\nConsole-tools\t\t%s\n",$0,$0)
}'

oprofiled --version 2>&1 | awk \
'(NR==1 && ($2 == "oprofile")) {print "oprofile              ", $3}'

expr --v 2>&1 |
awk '/^expr/{
        match($0, /([0-9]+([\.])?)+/)
        printf("Sh-utils\t\t%s\n",
            substr($0,RSTART,RLENGTH))
}'

udevadm --version 2>&1 |
awk '/([0-9]+([\.])?)+/{
        match($0, /([0-9]+([\.])?)+/)
        printf("Udev\t\t\t%s\n",
            substr($0,RSTART,RLENGTH))
}'

iwconfig --version 2>&1 |
awk '/version/{
        match($0, /([0-9]+([\.])?)+/)
        printf("Wireless-tools\t\t%s\n",
            substr($0,RSTART,RLENGTH))
}'

test -e /proc/modules &&
sort /proc/modules |
sed '
    s/ .*//
    H
${
    g
    s/^\n/Modules Loaded\t\t/
    y/\n/ /
    q
}
    d
'

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: ver_linux: proposed implementation feedback request
  2015-10-05 17:00 ver_linux: proposed implementation feedback request Alexander Kapshuk
@ 2015-10-06  8:11 ` Greg KH
  2015-10-06 11:28   ` Alexander Kapshuk
  2015-10-07  1:25 ` Theodore Ts'o
  1 sibling, 1 reply; 5+ messages in thread
From: Greg KH @ 2015-10-06  8:11 UTC (permalink / raw)
  To: Alexander Kapshuk; +Cc: linux-kernel, Jim Davis, richard, Theodore Ts'o

On Mon, Oct 05, 2015 at 08:00:40PM +0300, Alexander Kapshuk wrote:
> Thanks very much for everyone's feedback.
> 
> Instead of flooding this mailing list with another bunch of ver_linux
> patches, I thought I would post another implementation, and see if you
> find any of the proposed changes worth submitting as a patch. I will
> be happy with whatever feedback you can give me. And we will leave it
> at that. Thanks.

We can't try to do a diff ourselves in order to try to determine if this
is "good enough" to take, sorry, that's not hoe kernel development
works.  If you don't think it's "good enough", then we sure don't :)

If you want to redo your series, to fix issues you have found, great,
please do so and resend them and we will be glad to review them, as we
have been doing.  We can work with that, not with a "raw" file like
this.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: ver_linux: proposed implementation feedback request
  2015-10-06  8:11 ` Greg KH
@ 2015-10-06 11:28   ` Alexander Kapshuk
  0 siblings, 0 replies; 5+ messages in thread
From: Alexander Kapshuk @ 2015-10-06 11:28 UTC (permalink / raw)
  To: linux-kernel; +Cc: Greg KH, Jim Davis, richard, Theodore Ts'o

 On Tue, Oct 6, 2015 at 11:11 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Oct 05, 2015 at 08:00:40PM +0300, Alexander Kapshuk wrote:
>> Thanks very much for everyone's feedback.
>>
>> Instead of flooding this mailing list with another bunch of ver_linux
>> patches, I thought I would post another implementation, and see if you
>> find any of the proposed changes worth submitting as a patch. I will
>> be happy with whatever feedback you can give me. And we will leave it
>> at that. Thanks.
>
> We can't try to do a diff ourselves in order to try to determine if this
> is "good enough" to take, sorry, that's not hoe kernel development
> works.  If you don't think it's "good enough", then we sure don't :)
>
> If you want to redo your series, to fix issues you have found, great,
> please do so and resend them and we will be glad to review them, as we
> have been doing.  We can work with that, not with a "raw" file like
> this.
>
> thanks,
>
> greg k-h

 Understood. Thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: ver_linux: proposed implementation feedback request
  2015-10-05 17:00 ver_linux: proposed implementation feedback request Alexander Kapshuk
  2015-10-06  8:11 ` Greg KH
@ 2015-10-07  1:25 ` Theodore Ts'o
  2015-10-07 18:00   ` Alexander Kapshuk
  1 sibling, 1 reply; 5+ messages in thread
From: Theodore Ts'o @ 2015-10-07  1:25 UTC (permalink / raw)
  To: Alexander Kapshuk; +Cc: linux-kernel, Jim Davis, richard, Greg KH

On Mon, Oct 05, 2015 at 08:00:40PM +0300, Alexander Kapshuk wrote:
> Thanks very much for everyone's feedback.
> 
> Instead of flooding this mailing list with another bunch of ver_linux
> patches, I thought I would post another implementation, and see if you
> find any of the proposed changes worth submitting as a patch. I will
> be happy with whatever feedback you can give me. And we will leave it
> at that. Thanks.

Can you also explain what the changes are that you're making?  That
might be very helpful.

I'm also curious if someone suggested that you break apart the patch
into a separate one for each program?  In my opinion that actually
made it harder to review the patch set (especially when I was cc'ed on
the one for tune2fs, but not the patch that set $tune2fs :-).

My suggestion would be to break it apart by functional changes.  If
the main change is to support different version numbers emitted by a
wide range of version numbers, just say something like: fixed the
version number detection of the FOO, BAR, and BAZ packages.

Cheers,

					- Ted

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: ver_linux: proposed implementation feedback request
  2015-10-07  1:25 ` Theodore Ts'o
@ 2015-10-07 18:00   ` Alexander Kapshuk
  0 siblings, 0 replies; 5+ messages in thread
From: Alexander Kapshuk @ 2015-10-07 18:00 UTC (permalink / raw)
  To: Theodore Ts'o, linux-kernel, Jim Davis, richard, Greg KH,
	Alexander Kapshuk

On Wed, Oct 7, 2015 at 4:25 AM, Theodore Ts'o <tytso@mit.edu> wrote:
> On Mon, Oct 05, 2015 at 08:00:40PM +0300, Alexander Kapshuk wrote:
>> Thanks very much for everyone's feedback.
>>
>> Instead of flooding this mailing list with another bunch of ver_linux
>> patches, I thought I would post another implementation, and see if you
>> find any of the proposed changes worth submitting as a patch. I will
>> be happy with whatever feedback you can give me. And we will leave it
>> at that. Thanks.
>
> Can you also explain what the changes are that you're making?  That
> might be very helpful.
>
> I'm also curious if someone suggested that you break apart the patch
> into a separate one for each program?  In my opinion that actually
> made it harder to review the patch set (especially when I was cc'ed on
> the one for tune2fs, but not the patch that set $tune2fs :-).
>
> My suggestion would be to break it apart by functional changes.  If
> the main change is to support different version numbers emitted by a
> wide range of version numbers, just say something like: fixed the
> version number detection of the FOO, BAR, and BAZ packages.
>
> Cheers,
>
>                                         - Ted

Thanks. It has been suggested to me before to break the patch apart
into individual patches, as you suggested as well.

I'm looking into the process of making and submitting patches using
git at the moment. Not something I've done before. So please bear with
me. I should be able to get back to the list with git-generated
patches some time soon.

Thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2015-10-07 18:00 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-05 17:00 ver_linux: proposed implementation feedback request Alexander Kapshuk
2015-10-06  8:11 ` Greg KH
2015-10-06 11:28   ` Alexander Kapshuk
2015-10-07  1:25 ` Theodore Ts'o
2015-10-07 18:00   ` Alexander Kapshuk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).