linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ver_linux: wireless-tools.patch
@ 2015-10-01 18:41 Alexander Kapshuk
  0 siblings, 0 replies; only message in thread
From: Alexander Kapshuk @ 2015-10-01 18:41 UTC (permalink / raw)
  To: linux-kernel; +Cc: Greg KH

Using 'awk' here is a bit of an overkill. Should the output of 'iwconfig
--version' vary on another disto, or change overtime, it may no longer
be available in field 4, as relied on by the current implementation.

I believe 'sed' offers greater flexibility here in terms of processing
varying output as well as being more light-weight.


Tested on:
Arch Linux
openSuSE 13.2

Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---

--- linux/scripts/ver_linux.orig    2015-08-30 21:34:09.000000000 +0300
+++ linux/scripts/ver_linux    2015-09-30 23:03:05.019050132 +0300
@@ -89,8 +89,12 @@

 udevinfo -V 2>&1 | grep version | awk '{print "udev                  ", $3}'

-iwconfig --version 2>&1 | awk \
-'(NR==1 && ($3 == "version")) {print "wireless-tools        ",$4}'
+iwconfig --version 2>&1 |
+sed '
+    /version/!d
+    s/[^0-9\.]//g
+    s/^/wireless-tools\t\t/
+'

 if [ -e /proc/modules ]; then
     X=`cat /proc/modules | sed -e "s/ .*$//"`

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-10-01 18:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-01 18:41 [PATCH] ver_linux: wireless-tools.patch Alexander Kapshuk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).