linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ver_linux: net-tools.patch
@ 2015-10-01 18:27 Alexander Kapshuk
  0 siblings, 0 replies; only message in thread
From: Alexander Kapshuk @ 2015-10-01 18:27 UTC (permalink / raw)
  To: linux-kernel; +Cc: Greg KH

The current implementation relies on 'ifconfig' to be available in the
PATH. It also uses both 'grep' and 'awk' for text processing here, which
may be alright as a quick solution to be run on the command line. While
in a script, 'sed' or 'awk' would be a better choice. On top of that,
the current implementation expects the version number to be found in
the last field as seen by 'awk'. Should the output format be different,
this approach would no longer be reliable.

The proposed implementation locates 'ifconfig', and uses 'sed' as a more
flexible tool to handle varying output formats.

Tested on:
Gentoo Linux
Debian 6.0.10
Oracle Linux Server release 7.1
Arch Linux
openSuSE 13.2


Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---

--- linux/scripts/ver_linux.orig    2015-08-30 21:34:09.000000000 +0300
+++ linux/scripts/ver_linux    2015-09-30 22:57:38.819620721 +0300
@@ -71,8 +71,15 @@
 ps --version 2>&1 | grep version | awk \
 'NR==1{print "Procps                ", $NF}'

-ifconfig --version 2>&1 | grep tools | awk \
-'NR==1{print "Net-tools             ", $NF}'
+ifconfig=`whereis ifconfig | awk '{print $2}'`
+test -n "$ifconfig" &&
+$ifconfig --version 2>&1 |
+sed '
+    /net-tools/!d
+    s/\([0-9]\)-.*/\1/
+    s/[ \t]/\t\t/
+    s/_.*//
+'

 # Kbd needs 'loadkeys -h',
 loadkeys -h 2>&1 | awk \

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2015-10-01 18:27 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-01 18:27 [PATCH] ver_linux: net-tools.patch Alexander Kapshuk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).