[PATCH] ver_linux: pcmciautils.patch

[PATCH] ver_linux: pcmciautils.patch

[Alexander Kapshuk]

The current implementation uses both 'grep' and 'awk' for text processing
here, which may be alright as a quick solution to be run on the command
line. While in a script, 'sed' or 'awk' would be a better choice. On
top of that, the current implementation expects the version number to be
found in field 2 as seen by 'awk'. Should the output format be different,
this approach would no longer be reliable.

The proposed implementation uses 'sed' as a more flexible tool to handle
varying output formats.



Tested on:
Arch Linux
openSuSE 13.2

Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---

--- linux/scripts/ver_linux.orig    2015-08-30 21:34:09.000000000 +0300
+++ linux/scripts/ver_linux    2015-09-30 22:47:53.451206718 +0300
@@ -42,7 +42,11 @@
 xfs_db -V 2>&1 | grep version | awk \
 'NR==1{print "xfsprogs              ", $3}'

-pccardctl -V 2>&1| grep pcmciautils | awk '{print "pcmciautils
   ", $2}'
+pccardctl -V 2>&1 |
+sed '
+    /^\(pcmciautils\)[ \t]/!d
+    s//\1\t\t/
+'

 cardmgr -V 2>&1| grep version | awk \
 'NR==1{print "pcmcia-cs             ", $3}'