From: Leonardo Bras Soares Passos <leobras@redhat.com>
To: Valentin Schneider <vschneid@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Nadav Amit <namit@vmware.com>,
Chen Zhongjin <chenzhongjin@huawei.com>,
Daniel Bristot de Oliveira <bristot@kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Juergen Gross <jgross@suse.com>,
Yury Norov <yury.norov@gmail.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v4 1/2] trace,smp: Add tracepoints around remotelly called functions
Date: Wed, 14 Jun 2023 01:10:08 -0300 [thread overview]
Message-ID: <CAJ6HWG6x4WgLtr3RGNar4jFoccD4bCocid-_WzSFofDRP8+2gA@mail.gmail.com> (raw)
In-Reply-To: <xhsmh353ep0m7.mognet@vschneid.remote.csb>
Hello Valentin, thanks for the feedback!
On Tue, May 30, 2023 at 7:36 AM Valentin Schneider <vschneid@redhat.com> wrote:
>
> On 15/05/23 15:30, Leonardo Bras wrote:
> > @@ -375,7 +386,7 @@ static int generic_exec_single(int cpu, call_single_data_t *csd)
> > csd_lock_record(csd);
> > csd_unlock(csd);
> > local_irq_save(flags);
> > - func(info);
> > + csd_do_func(func, info, csd);
>
> I'd suggest making this match the local case of
> smp_call_function_many_cond(), IOW pass NULL as the csd when executing
> locally.
Sure, done!
>
> IMO this is required for postprocessing with e.g. synthetic events for CSD
> delivery measurement, otherwise we'll try to match this execution with a
> previous CSD enqueue.
>
> > csd_lock_record(NULL);
> > local_irq_restore(flags);
> > return 0;
>
next prev parent reply other threads:[~2023-06-14 4:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 18:30 [RFC PATCH v4 0/2] trace,smp: Add tracepoints for csd Leonardo Bras
2023-05-15 18:30 ` [RFC PATCH v4 1/2] trace,smp: Add tracepoints around remotelly called functions Leonardo Bras
2023-05-30 10:36 ` Valentin Schneider
2023-06-14 4:10 ` Leonardo Bras Soares Passos [this message]
2023-05-15 18:30 ` [RFC PATCH v4 2/2] trace,smp: Add tracepoints for scheduling " Leonardo Bras
2023-05-15 18:47 ` [RFC PATCH v4 0/2] trace,smp: Add tracepoints for csd Leonardo Brás
2023-05-30 10:36 ` Valentin Schneider
2023-06-14 4:14 ` Leonardo Bras Soares Passos
2023-06-14 5:16 ` Leonardo Bras Soares Passos
2023-06-14 9:27 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ6HWG6x4WgLtr3RGNar4jFoccD4bCocid-_WzSFofDRP8+2gA@mail.gmail.com \
--to=leobras@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=bristot@kernel.org \
--cc=chenzhongjin@huawei.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mtosatti@redhat.com \
--cc=namit@vmware.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vschneid@redhat.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).