From: "Leonardo Brás" <leobras@redhat.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Nadav Amit <namit@vmware.com>,
Chen Zhongjin <chenzhongjin@huawei.com>,
Daniel Bristot de Oliveira <bristot@kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
Juergen Gross <jgross@suse.com>,
Valentin Schneider <vschneid@redhat.com>,
Yury Norov <yury.norov@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v4 0/2] trace,smp: Add tracepoints for csd
Date: Mon, 15 May 2023 15:47:51 -0300 [thread overview]
Message-ID: <cefdad7f7154155f69d9613efe53f9cbbea2ed20.camel@redhat.com> (raw)
In-Reply-To: <20230515183045.654199-1-leobras@redhat.com>
On Mon, 2023-05-15 at 15:30 -0300, Leonardo Bras wrote:
> Changes since RFCv3:
> - Split the patch in 2: entry/exit and queue
> - Fix 'struct __call_single_data' & call_single_data_t alignment issue
> - Made all TP_printk follow the same pattern
>
> Changes since RFCv2:
> - Fixed some spacing issues and trace calls
>
> Changes since RFCv1:
> - Implemented trace_csd_queue_cpu() as suggested by Valentin Schneider
> - Using EVENT_CLASS in order to avoid duplication
> - Introduced new helper: csd_do_func()
> - Name change from smp_call_function_* to csd_function_*
> - Rebased on top of torvalds/master
>
> Leonardo Bras (2):
> trace,smp: Add tracepoints around remotelly called functions
> trace,smp: Add tracepoints for scheduling remotelly called functions
>
> include/trace/events/smp.h | 72 ++++++++++++++++++++++++++++++++++++++
> kernel/smp.c | 41 +++++++++++++---------
> 2 files changed, 96 insertions(+), 17 deletions(-)
> create mode 100644 include/trace/events/smp.h
>
argh, almost sure some llvm build will output some alignment warning because
csd_do_func() has an 'struct __call_single_data' argument while the tracepoints
have call_single_data_t arguments.
Other than that, it should be fine.
I will collect other suggestions before sending a v5 with this fix.
Leo
next prev parent reply other threads:[~2023-05-15 18:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 18:30 [RFC PATCH v4 0/2] trace,smp: Add tracepoints for csd Leonardo Bras
2023-05-15 18:30 ` [RFC PATCH v4 1/2] trace,smp: Add tracepoints around remotelly called functions Leonardo Bras
2023-05-30 10:36 ` Valentin Schneider
2023-06-14 4:10 ` Leonardo Bras Soares Passos
2023-05-15 18:30 ` [RFC PATCH v4 2/2] trace,smp: Add tracepoints for scheduling " Leonardo Bras
2023-05-15 18:47 ` Leonardo Brás [this message]
2023-05-30 10:36 ` [RFC PATCH v4 0/2] trace,smp: Add tracepoints for csd Valentin Schneider
2023-06-14 4:14 ` Leonardo Bras Soares Passos
2023-06-14 5:16 ` Leonardo Bras Soares Passos
2023-06-14 9:27 ` Valentin Schneider
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cefdad7f7154155f69d9613efe53f9cbbea2ed20.camel@redhat.com \
--to=leobras@redhat.com \
--cc=bigeasy@linutronix.de \
--cc=bristot@kernel.org \
--cc=chenzhongjin@huawei.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mtosatti@redhat.com \
--cc=namit@vmware.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vschneid@redhat.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).