From: Axel Rasmussen <axelrasmussen@google.com>
To: Gang Li <ligang.bdlg@bytedance.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
LKML <linux-kernel@vger.kernel.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH 1/3] mm: mmap_lock: remove redundant "\n" in TP_printk
Date: Thu, 29 Jul 2021 10:25:16 -0700 [thread overview]
Message-ID: <CAJHvVchhhUXyi2YbaqMW53y=bT50kmOBjjbApaMG8QZPQ=h1OQ@mail.gmail.com> (raw)
In-Reply-To: <20210729092831.38106-1-ligang.bdlg@bytedance.com>
Reviewed-by: Axel Rasmussen <axelrasmussen@google.com>
On Thu, Jul 29, 2021 at 2:28 AM Gang Li <ligang.bdlg@bytedance.com> wrote:
>
> Ftrace core will add "\n" automatically on print. "\n" in TP_printk
> will create blank line, so remove it.
>
> Signed-off-by: Gang Li <ligang.bdlg@bytedance.com>
> ---
> include/trace/events/mmap_lock.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/trace/events/mmap_lock.h b/include/trace/events/mmap_lock.h
> index 0abff67b96f0..5f980c92e3e9 100644
> --- a/include/trace/events/mmap_lock.h
> +++ b/include/trace/events/mmap_lock.h
> @@ -32,7 +32,7 @@ TRACE_EVENT_FN(mmap_lock_start_locking,
> ),
>
> TP_printk(
> - "mm=%p memcg_path=%s write=%s\n",
> + "mm=%p memcg_path=%s write=%s",
> __entry->mm,
> __get_str(memcg_path),
> __entry->write ? "true" : "false"
> @@ -63,7 +63,7 @@ TRACE_EVENT_FN(mmap_lock_acquire_returned,
> ),
>
> TP_printk(
> - "mm=%p memcg_path=%s write=%s success=%s\n",
> + "mm=%p memcg_path=%s write=%s success=%s",
> __entry->mm,
> __get_str(memcg_path),
> __entry->write ? "true" : "false",
> @@ -92,7 +92,7 @@ TRACE_EVENT_FN(mmap_lock_released,
> ),
>
> TP_printk(
> - "mm=%p memcg_path=%s write=%s\n",
> + "mm=%p memcg_path=%s write=%s",
> __entry->mm,
> __get_str(memcg_path),
> __entry->write ? "true" : "false"
> --
> 2.20.1
>
next prev parent reply other threads:[~2021-07-29 17:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 9:28 [PATCH 1/3] mm: mmap_lock: remove redundant "\n" in TP_printk Gang Li
2021-07-29 17:25 ` Axel Rasmussen [this message]
2021-07-30 2:45 ` Muchun Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJHvVchhhUXyi2YbaqMW53y=bT50kmOBjjbApaMG8QZPQ=h1OQ@mail.gmail.com' \
--to=axelrasmussen@google.com \
--cc=akpm@linux-foundation.org \
--cc=ligang.bdlg@bytedance.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).