linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] mm: mmap_lock: remove redundant "\n" in TP_printk
@ 2021-07-29  9:28 Gang Li
  2021-07-29 17:25 ` Axel Rasmussen
  2021-07-30  2:45 ` Muchun Song
  0 siblings, 2 replies; 3+ messages in thread
From: Gang Li @ 2021-07-29  9:28 UTC (permalink / raw)
  To: rostedt
  Cc: mingo, akpm, vbabka, axelrasmussen, linux-kernel, linux-mm, Gang Li

Ftrace core will add "\n" automatically on print. "\n" in TP_printk
will create blank line, so remove it.

Signed-off-by: Gang Li <ligang.bdlg@bytedance.com>
---
 include/trace/events/mmap_lock.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/trace/events/mmap_lock.h b/include/trace/events/mmap_lock.h
index 0abff67b96f0..5f980c92e3e9 100644
--- a/include/trace/events/mmap_lock.h
+++ b/include/trace/events/mmap_lock.h
@@ -32,7 +32,7 @@ TRACE_EVENT_FN(mmap_lock_start_locking,
 	),
 
 	TP_printk(
-		"mm=%p memcg_path=%s write=%s\n",
+		"mm=%p memcg_path=%s write=%s",
 		__entry->mm,
 		__get_str(memcg_path),
 		__entry->write ? "true" : "false"
@@ -63,7 +63,7 @@ TRACE_EVENT_FN(mmap_lock_acquire_returned,
 	),
 
 	TP_printk(
-		"mm=%p memcg_path=%s write=%s success=%s\n",
+		"mm=%p memcg_path=%s write=%s success=%s",
 		__entry->mm,
 		__get_str(memcg_path),
 		__entry->write ? "true" : "false",
@@ -92,7 +92,7 @@ TRACE_EVENT_FN(mmap_lock_released,
 	),
 
 	TP_printk(
-		"mm=%p memcg_path=%s write=%s\n",
+		"mm=%p memcg_path=%s write=%s",
 		__entry->mm,
 		__get_str(memcg_path),
 		__entry->write ? "true" : "false"
-- 
2.20.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/3] mm: mmap_lock: remove redundant "\n" in TP_printk
  2021-07-29  9:28 [PATCH 1/3] mm: mmap_lock: remove redundant "\n" in TP_printk Gang Li
@ 2021-07-29 17:25 ` Axel Rasmussen
  2021-07-30  2:45 ` Muchun Song
  1 sibling, 0 replies; 3+ messages in thread
From: Axel Rasmussen @ 2021-07-29 17:25 UTC (permalink / raw)
  To: Gang Li
  Cc: Steven Rostedt, Ingo Molnar, Andrew Morton, Vlastimil Babka,
	LKML, Linux MM

Reviewed-by: Axel Rasmussen <axelrasmussen@google.com>

On Thu, Jul 29, 2021 at 2:28 AM Gang Li <ligang.bdlg@bytedance.com> wrote:
>
> Ftrace core will add "\n" automatically on print. "\n" in TP_printk
> will create blank line, so remove it.
>
> Signed-off-by: Gang Li <ligang.bdlg@bytedance.com>
> ---
>  include/trace/events/mmap_lock.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/trace/events/mmap_lock.h b/include/trace/events/mmap_lock.h
> index 0abff67b96f0..5f980c92e3e9 100644
> --- a/include/trace/events/mmap_lock.h
> +++ b/include/trace/events/mmap_lock.h
> @@ -32,7 +32,7 @@ TRACE_EVENT_FN(mmap_lock_start_locking,
>         ),
>
>         TP_printk(
> -               "mm=%p memcg_path=%s write=%s\n",
> +               "mm=%p memcg_path=%s write=%s",
>                 __entry->mm,
>                 __get_str(memcg_path),
>                 __entry->write ? "true" : "false"
> @@ -63,7 +63,7 @@ TRACE_EVENT_FN(mmap_lock_acquire_returned,
>         ),
>
>         TP_printk(
> -               "mm=%p memcg_path=%s write=%s success=%s\n",
> +               "mm=%p memcg_path=%s write=%s success=%s",
>                 __entry->mm,
>                 __get_str(memcg_path),
>                 __entry->write ? "true" : "false",
> @@ -92,7 +92,7 @@ TRACE_EVENT_FN(mmap_lock_released,
>         ),
>
>         TP_printk(
> -               "mm=%p memcg_path=%s write=%s\n",
> +               "mm=%p memcg_path=%s write=%s",
>                 __entry->mm,
>                 __get_str(memcg_path),
>                 __entry->write ? "true" : "false"
> --
> 2.20.1
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/3] mm: mmap_lock: remove redundant "\n" in TP_printk
  2021-07-29  9:28 [PATCH 1/3] mm: mmap_lock: remove redundant "\n" in TP_printk Gang Li
  2021-07-29 17:25 ` Axel Rasmussen
@ 2021-07-30  2:45 ` Muchun Song
  1 sibling, 0 replies; 3+ messages in thread
From: Muchun Song @ 2021-07-30  2:45 UTC (permalink / raw)
  To: Gang Li
  Cc: Steven Rostedt, Ingo Molnar, Andrew Morton, Vlastimil Babka,
	Axel Rasmussen, LKML, Linux Memory Management List

On Thu, Jul 29, 2021 at 5:28 PM Gang Li <ligang.bdlg@bytedance.com> wrote:
>
> Ftrace core will add "\n" automatically on print. "\n" in TP_printk
> will create blank line, so remove it.
>
> Signed-off-by: Gang Li <ligang.bdlg@bytedance.com>

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-30  2:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-29  9:28 [PATCH 1/3] mm: mmap_lock: remove redundant "\n" in TP_printk Gang Li
2021-07-29 17:25 ` Axel Rasmussen
2021-07-30  2:45 ` Muchun Song

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).