linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: Exynos4415: remove dead build rule
@ 2017-01-19  9:11 ` Valentin Rothberg
  2017-01-19  9:14   ` Chanwoo Choi
  2017-01-19  9:18   ` Krzysztof Kozlowski
  0 siblings, 2 replies; 9+ messages in thread
From: Valentin Rothberg @ 2017-01-19  9:11 UTC (permalink / raw)
  To: krzk, s.nawrocki, cw00.choi, tomasz.figa, mturquette, sboyd
  Cc: linux-clk, linux-kernel, Valentin Rothberg, Valentin Rothberg

Commit 22dfab102cfa ("ARM: EXYNOS: Remove Exynos4415 arch code (SoC not
supported anymore)") removed the Kconfig option SOC_EXYNOS4415.  Thus,
we are safe to remove the last reference in the Makefile.

Signed-off-by: Valentin Rothberg <valetinrothberg@gmail.com>
---
Detected by using ./scripts/checkkconfigsymbols.py

 drivers/clk/samsung/Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
index 57f4dc6dc447..7afc21dc374e 100644
--- a/drivers/clk/samsung/Makefile
+++ b/drivers/clk/samsung/Makefile
@@ -5,7 +5,6 @@
 obj-$(CONFIG_COMMON_CLK)	+= clk.o clk-pll.o clk-cpu.o
 obj-$(CONFIG_SOC_EXYNOS3250)	+= clk-exynos3250.o
 obj-$(CONFIG_ARCH_EXYNOS4)	+= clk-exynos4.o
-obj-$(CONFIG_SOC_EXYNOS4415)	+= clk-exynos4415.o
 obj-$(CONFIG_SOC_EXYNOS5250)	+= clk-exynos5250.o
 obj-$(CONFIG_SOC_EXYNOS5260)	+= clk-exynos5260.o
 obj-$(CONFIG_SOC_EXYNOS5410)	+= clk-exynos5410.o
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: Exynos4415: remove dead build rule
  2017-01-19  9:11 ` [PATCH] ARM: Exynos4415: remove dead build rule Valentin Rothberg
@ 2017-01-19  9:14   ` Chanwoo Choi
  2017-01-19  9:31     ` Chanwoo Choi
  2017-01-19  9:18   ` Krzysztof Kozlowski
  1 sibling, 1 reply; 9+ messages in thread
From: Chanwoo Choi @ 2017-01-19  9:14 UTC (permalink / raw)
  To: Valentin Rothberg, krzk, s.nawrocki, tomasz.figa, mturquette, sboyd
  Cc: linux-clk, linux-kernel, Valentin Rothberg

Hi,

On 2017년 01월 19일 18:11, Valentin Rothberg wrote:
> Commit 22dfab102cfa ("ARM: EXYNOS: Remove Exynos4415 arch code (SoC not
> supported anymore)") removed the Kconfig option SOC_EXYNOS4415.  Thus,
> we are safe to remove the last reference in the Makefile.
> 
> Signed-off-by: Valentin Rothberg <valetinrothberg@gmail.com>
> ---
> Detected by using ./scripts/checkkconfigsymbols.py
> 
>  drivers/clk/samsung/Makefile | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
> index 57f4dc6dc447..7afc21dc374e 100644
> --- a/drivers/clk/samsung/Makefile
> +++ b/drivers/clk/samsung/Makefile
> @@ -5,7 +5,6 @@
>  obj-$(CONFIG_COMMON_CLK)	+= clk.o clk-pll.o clk-cpu.o
>  obj-$(CONFIG_SOC_EXYNOS3250)	+= clk-exynos3250.o
>  obj-$(CONFIG_ARCH_EXYNOS4)	+= clk-exynos4.o
> -obj-$(CONFIG_SOC_EXYNOS4415)	+= clk-exynos4415.o
>  obj-$(CONFIG_SOC_EXYNOS5250)	+= clk-exynos5250.o
>  obj-$(CONFIG_SOC_EXYNOS5260)	+= clk-exynos5260.o
>  obj-$(CONFIG_SOC_EXYNOS5410)	+= clk-exynos5410.o
> 

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Best Regards,
Chanwoo Choi
S/W Center, Samsung Electronics

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: Exynos4415: remove dead build rule
  2017-01-19  9:11 ` [PATCH] ARM: Exynos4415: remove dead build rule Valentin Rothberg
  2017-01-19  9:14   ` Chanwoo Choi
@ 2017-01-19  9:18   ` Krzysztof Kozlowski
  2017-01-19  9:20     ` Krzysztof Kozlowski
  1 sibling, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2017-01-19  9:18 UTC (permalink / raw)
  To: Valentin Rothberg
  Cc: Sylwester Nawrocki, Chanwoo Choi, Tomasz Figa, mturquette, sboyd,
	linux-clk, linux-kernel, Valentin Rothberg

On Thu, Jan 19, 2017 at 11:11 AM, Valentin Rothberg
<valentinrothberg@gmail.com> wrote:
> Commit 22dfab102cfa ("ARM: EXYNOS: Remove Exynos4415 arch code (SoC not
> supported anymore)") removed the Kconfig option SOC_EXYNOS4415.  Thus,
> we are safe to remove the last reference in the Makefile.
>
> Signed-off-by: Valentin Rothberg <valetinrothberg@gmail.com>
> ---
> Detected by using ./scripts/checkkconfigsymbols.py
>
>  drivers/clk/samsung/Makefile | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
> index 57f4dc6dc447..7afc21dc374e 100644
> --- a/drivers/clk/samsung/Makefile
> +++ b/drivers/clk/samsung/Makefile
> @@ -5,7 +5,6 @@
>  obj-$(CONFIG_COMMON_CLK)       += clk.o clk-pll.o clk-cpu.o
>  obj-$(CONFIG_SOC_EXYNOS3250)   += clk-exynos3250.o
>  obj-$(CONFIG_ARCH_EXYNOS4)     += clk-exynos4.o
> -obj-$(CONFIG_SOC_EXYNOS4415)   += clk-exynos4415.o

It is already removed. Which tree are you using?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: Exynos4415: remove dead build rule
  2017-01-19  9:18   ` Krzysztof Kozlowski
@ 2017-01-19  9:20     ` Krzysztof Kozlowski
  2017-01-19  9:25       ` Valentin Rothberg
  0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2017-01-19  9:20 UTC (permalink / raw)
  To: Valentin Rothberg
  Cc: Sylwester Nawrocki, Chanwoo Choi, Tomasz Figa, mturquette, sboyd,
	linux-clk, linux-kernel, Valentin Rothberg

On Thu, Jan 19, 2017 at 11:18 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> On Thu, Jan 19, 2017 at 11:11 AM, Valentin Rothberg
> <valentinrothberg@gmail.com> wrote:
>> Commit 22dfab102cfa ("ARM: EXYNOS: Remove Exynos4415 arch code (SoC not
>> supported anymore)") removed the Kconfig option SOC_EXYNOS4415.  Thus,
>> we are safe to remove the last reference in the Makefile.
>>
>> Signed-off-by: Valentin Rothberg <valetinrothberg@gmail.com>
>> ---
>> Detected by using ./scripts/checkkconfigsymbols.py
>>
>>  drivers/clk/samsung/Makefile | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
>> index 57f4dc6dc447..7afc21dc374e 100644
>> --- a/drivers/clk/samsung/Makefile
>> +++ b/drivers/clk/samsung/Makefile
>> @@ -5,7 +5,6 @@
>>  obj-$(CONFIG_COMMON_CLK)       += clk.o clk-pll.o clk-cpu.o
>>  obj-$(CONFIG_SOC_EXYNOS3250)   += clk-exynos3250.o
>>  obj-$(CONFIG_ARCH_EXYNOS4)     += clk-exynos4.o
>> -obj-$(CONFIG_SOC_EXYNOS4415)   += clk-exynos4415.o
>
> It is already removed. Which tree are you using?

BTW, please fix your own mail/name etc in from and Signed-off-by. One
of them is wrong and bounces.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: Exynos4415: remove dead build rule
  2017-01-19  9:20     ` Krzysztof Kozlowski
@ 2017-01-19  9:25       ` Valentin Rothberg
  2017-01-19  9:28         ` Krzysztof Kozlowski
  0 siblings, 1 reply; 9+ messages in thread
From: Valentin Rothberg @ 2017-01-19  9:25 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Sylwester Nawrocki, Chanwoo Choi, Tomasz Figa, mturquette, sboyd,
	linux-clk, linux-kernel, Valentin Rothberg

Hi Krzysztof,

On 19/01/2017 10:20, Krzysztof Kozlowski wrote:
> On Thu, Jan 19, 2017 at 11:18 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On Thu, Jan 19, 2017 at 11:11 AM, Valentin Rothberg
>> <valentinrothberg@gmail.com> wrote:
>>> Commit 22dfab102cfa ("ARM: EXYNOS: Remove Exynos4415 arch code (SoC not
>>> supported anymore)") removed the Kconfig option SOC_EXYNOS4415.  Thus,
>>> we are safe to remove the last reference in the Makefile.
>>>
>>> Signed-off-by: Valentin Rothberg <valetinrothberg@gmail.com>
>>> ---
>>> Detected by using ./scripts/checkkconfigsymbols.py
>>>
>>>  drivers/clk/samsung/Makefile | 1 -
>>>  1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
>>> index 57f4dc6dc447..7afc21dc374e 100644
>>> --- a/drivers/clk/samsung/Makefile
>>> +++ b/drivers/clk/samsung/Makefile
>>> @@ -5,7 +5,6 @@
>>>  obj-$(CONFIG_COMMON_CLK)       += clk.o clk-pll.o clk-cpu.o
>>>  obj-$(CONFIG_SOC_EXYNOS3250)   += clk-exynos3250.o
>>>  obj-$(CONFIG_ARCH_EXYNOS4)     += clk-exynos4.o
>>> -obj-$(CONFIG_SOC_EXYNOS4415)   += clk-exynos4415.o
>>
>> It is already removed. Which tree are you using?

I'm on today's linux-next.  Please excuse the noise, I did not see your
other patch on lkml.

> BTW, please fix your own mail/name etc in from and Signed-off-by. One
> of them is wrong and bounces.

Thanks for the hint.

Kind regards,
 Valentin

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: Exynos4415: remove dead build rule
  2017-01-19  9:25       ` Valentin Rothberg
@ 2017-01-19  9:28         ` Krzysztof Kozlowski
  2017-01-19  9:44           ` Sylwester Nawrocki
  0 siblings, 1 reply; 9+ messages in thread
From: Krzysztof Kozlowski @ 2017-01-19  9:28 UTC (permalink / raw)
  To: Valentin Rothberg, Sylwester Nawrocki
  Cc: Chanwoo Choi, Tomasz Figa, mturquette, sboyd, linux-clk, linux-kernel

On Thu, Jan 19, 2017 at 11:25 AM, Valentin Rothberg
<valentinrothberg@gmail.com> wrote:
> Hi Krzysztof,
>
> On 19/01/2017 10:20, Krzysztof Kozlowski wrote:
>> On Thu, Jan 19, 2017 at 11:18 AM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>> On Thu, Jan 19, 2017 at 11:11 AM, Valentin Rothberg
>>> <valentinrothberg@gmail.com> wrote:
>>>> Commit 22dfab102cfa ("ARM: EXYNOS: Remove Exynos4415 arch code (SoC not
>>>> supported anymore)") removed the Kconfig option SOC_EXYNOS4415.  Thus,
>>>> we are safe to remove the last reference in the Makefile.
>>>>
>>>> Signed-off-by: Valentin Rothberg <valetinrothberg@gmail.com>
>>>> ---
>>>> Detected by using ./scripts/checkkconfigsymbols.py
>>>>
>>>>  drivers/clk/samsung/Makefile | 1 -
>>>>  1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile
>>>> index 57f4dc6dc447..7afc21dc374e 100644
>>>> --- a/drivers/clk/samsung/Makefile
>>>> +++ b/drivers/clk/samsung/Makefile
>>>> @@ -5,7 +5,6 @@
>>>>  obj-$(CONFIG_COMMON_CLK)       += clk.o clk-pll.o clk-cpu.o
>>>>  obj-$(CONFIG_SOC_EXYNOS3250)   += clk-exynos3250.o
>>>>  obj-$(CONFIG_ARCH_EXYNOS4)     += clk-exynos4.o
>>>> -obj-$(CONFIG_SOC_EXYNOS4415)   += clk-exynos4415.o
>>>
>>> It is already removed. Which tree are you using?
>
> I'm on today's linux-next.  Please excuse the noise, I did not see your
> other patch on lkml.

Sylwester,

Is your tree included in linux-next? I see my patch here:
https://git.linuxtv.org/snawrocki/samsung.git/log/?h=for-v4.11/clk/next
so maybe something in linux-next is missing?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: Exynos4415: remove dead build rule
  2017-01-19  9:14   ` Chanwoo Choi
@ 2017-01-19  9:31     ` Chanwoo Choi
  0 siblings, 0 replies; 9+ messages in thread
From: Chanwoo Choi @ 2017-01-19  9:31 UTC (permalink / raw)
  To: Valentin Rothberg, krzk, s.nawrocki, tomasz.figa, mturquette, sboyd
  Cc: linux-clk, linux-kernel, Valentin Rothberg

Dear all,

On 2017년 01월 19일 18:14, Chanwoo Choi wrote:
> Hi,
> 
> On 2017년 01월 19일 18:11, Valentin Rothberg wrote:
>> Commit 22dfab102cfa ("ARM: EXYNOS: Remove Exynos4415 arch code (SoC not
>> supported anymore)") removed the Kconfig option SOC_EXYNOS4415.  Thus,
>> we are safe to remove the last reference in the Makefile.
>>
>> Signed-off-by: Valentin Rothberg <valetinrothberg@gmail.com>
>> ---
>> Detected by using ./scripts/checkkconfigsymbols.py
>>
>>  drivers/clk/samsung/Makefile | 1 -
>>  1 file changed, 1 deletion(-)

Please ignore this reply. Krzysztof's patch[1] already
removed the entry of clk-exynos4415.c.
[1] https://www.spinics.net/lists/arm-kernel/msg554369.html

-- 
Best Regards,
Chanwoo Choi
S/W R&D Center
Samsung Electronics

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: Exynos4415: remove dead build rule
  2017-01-19  9:28         ` Krzysztof Kozlowski
@ 2017-01-19  9:44           ` Sylwester Nawrocki
  2017-01-19 13:56             ` Krzysztof Kozlowski
  0 siblings, 1 reply; 9+ messages in thread
From: Sylwester Nawrocki @ 2017-01-19  9:44 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Valentin Rothberg, Chanwoo Choi, Tomasz Figa, mturquette, sboyd,
	linux-clk, linux-kernel

On 01/19/2017 10:28 AM, Krzysztof Kozlowski wrote:
> Is your tree included in linux-next? I see my patch here:
> https://git.linuxtv.org/snawrocki/samsung.git/log/?h=for-v4.11/clk/next
> so maybe something in linux-next is missing?

No, it's not included. I will be sending a pull request to the clk
maintainers this week so the patches should end up in linux-next soon.

-- 
Thanks,
Sylwester

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PATCH] ARM: Exynos4415: remove dead build rule
  2017-01-19  9:44           ` Sylwester Nawrocki
@ 2017-01-19 13:56             ` Krzysztof Kozlowski
  0 siblings, 0 replies; 9+ messages in thread
From: Krzysztof Kozlowski @ 2017-01-19 13:56 UTC (permalink / raw)
  To: Sylwester Nawrocki
  Cc: Valentin Rothberg, Chanwoo Choi, Tomasz Figa, mturquette, sboyd,
	linux-clk, linux-kernel

On Thu, Jan 19, 2017 at 11:44 AM, Sylwester Nawrocki
<s.nawrocki@samsung.com> wrote:
> On 01/19/2017 10:28 AM, Krzysztof Kozlowski wrote:
>> Is your tree included in linux-next? I see my patch here:
>> https://git.linuxtv.org/snawrocki/samsung.git/log/?h=for-v4.11/clk/next
>> so maybe something in linux-next is missing?
>
> No, it's not included. I will be sending a pull request to the clk
> maintainers this week so the patches should end up in linux-next soon.

... so how about including it? I do not see any reasons not to be part
of linux-next. You are picking patches for Samsung clk and pinctrl
(and media drivers? and maybe more?) so everything you pick should be
in next as fast as possible.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2017-01-19 13:58 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20170119091246epcas2p3b647c978e26c99baaa4cab3d757fd59d@epcas2p3.samsung.com>
2017-01-19  9:11 ` [PATCH] ARM: Exynos4415: remove dead build rule Valentin Rothberg
2017-01-19  9:14   ` Chanwoo Choi
2017-01-19  9:31     ` Chanwoo Choi
2017-01-19  9:18   ` Krzysztof Kozlowski
2017-01-19  9:20     ` Krzysztof Kozlowski
2017-01-19  9:25       ` Valentin Rothberg
2017-01-19  9:28         ` Krzysztof Kozlowski
2017-01-19  9:44           ` Sylwester Nawrocki
2017-01-19 13:56             ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).