From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Alim Akhtar <alim.akhtar@samsung.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kgene@kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: exynos7: Enable HS200 mode operation
Date: Mon, 2 Nov 2015 21:27:57 +0900 [thread overview]
Message-ID: <CAJKOXPf+twUu4_fxjQ1Xp24L-YzNj6=mZ+dOxu72FWJcrYk3Rw@mail.gmail.com> (raw)
In-Reply-To: <56375229.3090906@samsung.com>
2015-11-02 21:08 GMT+09:00 Alim Akhtar <alim.akhtar@samsung.com>:
> Hi Krzysztof,
>
>
> On 11/02/2015 05:28 PM, Krzysztof Kozlowski wrote:
>>
>> Subject - name of the board at the end (not the name of the SoC):
>> arm64: dts: Enable HS200 mode operation on exynos7-espresso
>>
>> 2015-11-02 19:04 GMT+09:00 Alim Akhtar <alim.akhtar@samsung.com>:
>>>
>>> This patch enables HS200 mode operation on exynos7 based
>>> espresso board.
>>> This also remove _broken-cd_ property as per mmc binding documentation
>>
>>
>> s/remove/removes/
>>
>>> which say one of the properties between broken-cd and non-removable
>>
>>
>> s/say/says/
>>
>>> should be used. And we already use _non-removable_ as emmc mounted
>>> on board which is a non-removable device.
>>>
>>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>>> ---
>>> arch/arm64/boot/dts/exynos/exynos7-espresso.dts | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
>>> b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
>>> index 8ce04a0ec928..7f19b99fc85b 100644
>>> --- a/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
>>> +++ b/arch/arm64/boot/dts/exynos/exynos7-espresso.dts
>>> @@ -405,8 +405,8 @@
>>> &mmc_0 {
>>> status = "okay";
>>> num-slots = <1>;
>>> - broken-cd;
>>> cap-mmc-highspeed;
>>> + mmc-hs200-1_8v;
>>
>>
>> The "mmc-ddr-1_8v" should also be supported but I guess you did not
>> add it on purpose?
>>
> Well, I have not tested it, that why didn't added. Will check if this works
> then will add.
> Thanks for your comments.
Right, it would require testing... Just came to my mind. Anyway this
is up to you.
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-11-02 12:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 10:04 [PATCH 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree node Alim Akhtar
2015-11-02 10:04 ` [PATCH 2/2] arm64: dts: exynos7: Enable HS200 mode operation Alim Akhtar
2015-11-02 11:32 ` Javier Martinez Canillas
2015-11-02 11:58 ` Krzysztof Kozlowski
2015-11-02 12:08 ` Alim Akhtar
2015-11-02 12:27 ` Krzysztof Kozlowski [this message]
2015-11-02 11:30 ` [PATCH 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree node Javier Martinez Canillas
2015-11-02 11:58 ` Alim Akhtar
2015-11-02 12:25 ` Krzysztof Kozlowski
2015-11-02 13:01 ` Alim Akhtar
2015-11-02 13:52 ` Krzysztof Kozlowski
2015-11-05 5:37 ` Alim Akhtar
2015-11-05 5:40 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPf+twUu4_fxjQ1Xp24L-YzNj6=mZ+dOxu72FWJcrYk3Rw@mail.gmail.com' \
--to=k.kozlowski@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).