* [RFT] powerpc/boot: Fix missing crc32poly.h when building with KERNEL_XZ
@ 2018-08-29 7:32 Krzysztof Kozlowski
2018-08-29 7:55 ` Krzysztof Kozlowski
2018-08-29 10:45 ` Michal Kubecek
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2018-08-29 7:32 UTC (permalink / raw)
To: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
Krzysztof Kozlowski, linuxppc-dev, linux-kernel
Cc: Michal Kubecek
After commit faa16bc404d7 ("lib: Use existing define with
polynomial") the lib/xz/xz_crc32.c includes a header from include/linux
directory thus any other user of this code should define proper include
path.
This fixes the build error on powerpc with CONFIG_KERNEL_XZ:
In file included from ../arch/powerpc/boot/../../../lib/decompress_unxz.c:233:0,
from ../arch/powerpc/boot/decompress.c:42:
../arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:29: fatal error: linux/crc32poly.h: No such file or directory
Reported-by: Michal Kubecek <mkubecek@suse.cz>
Fixes: faa16bc404d7 ("lib: Use existing define with polynomial")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
Only compile tested.
---
arch/powerpc/boot/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
index 0fb96c26136f..ba4182fb185d 100644
--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -63,7 +63,7 @@ ifeq ($(call cc-option-yn, -fstack-protector),y)
BOOTCFLAGS += -fno-stack-protector
endif
-BOOTCFLAGS += -I$(objtree)/$(obj) -I$(srctree)/$(obj)
+BOOTCFLAGS += -I$(objtree)/$(obj) -I$(srctree)/$(obj) -I$(srctree)/include
DTC_FLAGS ?= -p 1024
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RFT] powerpc/boot: Fix missing crc32poly.h when building with KERNEL_XZ
2018-08-29 7:32 [RFT] powerpc/boot: Fix missing crc32poly.h when building with KERNEL_XZ Krzysztof Kozlowski
@ 2018-08-29 7:55 ` Krzysztof Kozlowski
2018-08-29 8:06 ` Mathieu Malaterre
2018-08-29 10:45 ` Michal Kubecek
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2018-08-29 7:55 UTC (permalink / raw)
To: benh, paulus, mpe, linuxppc-dev, linux-kernel; +Cc: mkubecek
On Wed, 29 Aug 2018 at 09:32, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> After commit faa16bc404d7 ("lib: Use existing define with
> polynomial") the lib/xz/xz_crc32.c includes a header from include/linux
> directory thus any other user of this code should define proper include
> path.
>
> This fixes the build error on powerpc with CONFIG_KERNEL_XZ:
>
> In file included from ../arch/powerpc/boot/../../../lib/decompress_unxz.c:233:0,
> from ../arch/powerpc/boot/decompress.c:42:
> ../arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:29: fatal error: linux/crc32poly.h: No such file or directory
>
> Reported-by: Michal Kubecek <mkubecek@suse.cz>
Reported earlier by Kbuild:
https://lkml.org/lkml/2018/8/23/47
for the credits:
Reported-by: kbuild test robot <lkp@intel.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFT] powerpc/boot: Fix missing crc32poly.h when building with KERNEL_XZ
2018-08-29 7:55 ` Krzysztof Kozlowski
@ 2018-08-29 8:06 ` Mathieu Malaterre
2018-08-29 8:12 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Mathieu Malaterre @ 2018-08-29 8:06 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
linuxppc-dev, LKML, mkubecek, Meelis Roos
On Wed, Aug 29, 2018 at 9:59 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On Wed, 29 Aug 2018 at 09:32, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > After commit faa16bc404d7 ("lib: Use existing define with
> > polynomial") the lib/xz/xz_crc32.c includes a header from include/linux
> > directory thus any other user of this code should define proper include
> > path.
> >
> > This fixes the build error on powerpc with CONFIG_KERNEL_XZ:
> >
> > In file included from ../arch/powerpc/boot/../../../lib/decompress_unxz.c:233:0,
> > from ../arch/powerpc/boot/decompress.c:42:
> > ../arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:29: fatal error: linux/crc32poly.h: No such file or directory
> >
> > Reported-by: Michal Kubecek <mkubecek@suse.cz>
>
> Reported earlier by Kbuild:
> https://lkml.org/lkml/2018/8/23/47
>
> for the credits:
> Reported-by: kbuild test robot <lkp@intel.com>
Technically Meelis reported it earlier:
https://lkml.org/lkml/2018/8/22/365
;)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFT] powerpc/boot: Fix missing crc32poly.h when building with KERNEL_XZ
2018-08-29 8:06 ` Mathieu Malaterre
@ 2018-08-29 8:12 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2018-08-29 8:12 UTC (permalink / raw)
To: malat; +Cc: benh, paulus, mpe, linuxppc-dev, linux-kernel, mkubecek, mroos
On Wed, 29 Aug 2018 at 10:06, Mathieu Malaterre <malat@debian.org> wrote:
>
> On Wed, Aug 29, 2018 at 9:59 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Wed, 29 Aug 2018 at 09:32, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> > >
> > > After commit faa16bc404d7 ("lib: Use existing define with
> > > polynomial") the lib/xz/xz_crc32.c includes a header from include/linux
> > > directory thus any other user of this code should define proper include
> > > path.
> > >
> > > This fixes the build error on powerpc with CONFIG_KERNEL_XZ:
> > >
> > > In file included from ../arch/powerpc/boot/../../../lib/decompress_unxz.c:233:0,
> > > from ../arch/powerpc/boot/decompress.c:42:
> > > ../arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:29: fatal error: linux/crc32poly.h: No such file or directory
> > >
> > > Reported-by: Michal Kubecek <mkubecek@suse.cz>
> >
> > Reported earlier by Kbuild:
> > https://lkml.org/lkml/2018/8/23/47
> >
> > for the credits:
> > Reported-by: kbuild test robot <lkp@intel.com>
>
> Technically Meelis reported it earlier:
>
> https://lkml.org/lkml/2018/8/22/365
>
> ;)
Oh, right... so for the full credits:
Reported-by: Meelis Roos <mroos@linux.ee>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [RFT] powerpc/boot: Fix missing crc32poly.h when building with KERNEL_XZ
2018-08-29 7:32 [RFT] powerpc/boot: Fix missing crc32poly.h when building with KERNEL_XZ Krzysztof Kozlowski
2018-08-29 7:55 ` Krzysztof Kozlowski
@ 2018-08-29 10:45 ` Michal Kubecek
1 sibling, 0 replies; 5+ messages in thread
From: Michal Kubecek @ 2018-08-29 10:45 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Benjamin Herrenschmidt, Paul Mackerras, Michael Ellerman,
linuxppc-dev, linux-kernel
On Wed, Aug 29, 2018 at 09:32:23AM +0200, Krzysztof Kozlowski wrote:
> After commit faa16bc404d7 ("lib: Use existing define with
> polynomial") the lib/xz/xz_crc32.c includes a header from include/linux
> directory thus any other user of this code should define proper include
> path.
>
> This fixes the build error on powerpc with CONFIG_KERNEL_XZ:
>
> In file included from ../arch/powerpc/boot/../../../lib/decompress_unxz.c:233:0,
> from ../arch/powerpc/boot/decompress.c:42:
> ../arch/powerpc/boot/../../../lib/xz/xz_crc32.c:18:29: fatal error: linux/crc32poly.h: No such file or directory
>
> Reported-by: Michal Kubecek <mkubecek@suse.cz>
> Fixes: faa16bc404d7 ("lib: Use existing define with polynomial")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Only compile tested.
> ---
> arch/powerpc/boot/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
> index 0fb96c26136f..ba4182fb185d 100644
> --- a/arch/powerpc/boot/Makefile
> +++ b/arch/powerpc/boot/Makefile
> @@ -63,7 +63,7 @@ ifeq ($(call cc-option-yn, -fstack-protector),y)
> BOOTCFLAGS += -fno-stack-protector
> endif
>
> -BOOTCFLAGS += -I$(objtree)/$(obj) -I$(srctree)/$(obj)
> +BOOTCFLAGS += -I$(objtree)/$(obj) -I$(srctree)/$(obj) -I$(srctree)/include
>
> DTC_FLAGS ?= -p 1024
>
> --
> 2.7.4
>
With this patch 4.19-rc1 builds and boots on ppc64le. Thank you.
Tested-by: Michal Kubecek <mkubecek@suse.cz>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-29 10:45 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-29 7:32 [RFT] powerpc/boot: Fix missing crc32poly.h when building with KERNEL_XZ Krzysztof Kozlowski
2018-08-29 7:55 ` Krzysztof Kozlowski
2018-08-29 8:06 ` Mathieu Malaterre
2018-08-29 8:12 ` Krzysztof Kozlowski
2018-08-29 10:45 ` Michal Kubecek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).