[PATCH 1/1] MAINTAINERS: fix bad file reference into Documentation

[PATCH 1/1] MAINTAINERS: fix bad file reference into Documentation

[Otto Sabart]

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

There is no `samsung,exynos5250-trng.txt` file in the documentation and
I do not think it ever existed.

Signed-off-by: Otto Sabart <ottosabart@seberm.com>
---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 32d444476a90..609451bf2b1a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13309,7 +13309,6 @@ M:	Łukasz Stelmach <l.stelmach@samsung.com>
 L:	linux-samsung-soc@vger.kernel.org
 S:	Maintained
 F:	drivers/char/hw_random/exynos-trng.c
-F:	Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
 
 SAMSUNG FRAMEBUFFER DRIVER
 M:	Jingoo Han <jingoohan1@gmail.com>
-- 
2.17.2


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 1/1] MAINTAINERS: fix bad file reference into Documentation

[Joe Perches]

On Wed, 2019-01-09 at 20:09 +0100, Otto Sabart wrote:
> There is no `samsung,exynos5250-trng.txt` file in the documentation and
> I do not think it ever existed.

There was a patch for this

https://patchwork.kernel.org/patch/10623153/

But is is still unapplied...

> diff --git a/MAINTAINERS b/MAINTAINERS
[]
> @@ -13309,7 +13309,6 @@ M:	Łukasz Stelmach <l.stelmach@samsung.com>
>  L:	linux-samsung-soc@vger.kernel.org
>  S:	Maintained
>  F:	drivers/char/hw_random/exynos-trng.c
> -F:	Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt

Re: [PATCH 1/1] MAINTAINERS: fix bad file reference into Documentation

[Łukasz Stelmach]

[-- Attachment #1: Type: text/plain, Size: 743 bytes --]

It was <2019-01-09 śro 20:35>, when Joe Perches wrote:
> On Wed, 2019-01-09 at 20:09 +0100, Otto Sabart wrote:
>> There is no `samsung,exynos5250-trng.txt` file in the documentation and
>> I do not think it ever existed.
>
> There was a patch for this
>
> https://patchwork.kernel.org/patch/10623153/
>
> But is is still unapplied...
>
>> diff --git a/MAINTAINERS b/MAINTAINERS
> []
>> @@ -13309,7 +13309,6 @@ M:	Łukasz Stelmach <l.stelmach@samsung.com>
>>  L:	linux-samsung-soc@vger.kernel.org
>>  S:	Maintained
>>  F:	drivers/char/hw_random/exynos-trng.c
>> -F:	Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt

+ Rob Herring

-- 
Łukasz Stelmach
Samsung R&D Institute Poland
Samsung Electronics

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

Re: [PATCH 1/1] MAINTAINERS: fix bad file reference into Documentation

[Rob Herring]

On Thu, Jan 10, 2019 at 2:23 AM Łukasz Stelmach <l.stelmach@samsung.com> wrote:
>
> It was <2019-01-09 śro 20:35>, when Joe Perches wrote:
> > On Wed, 2019-01-09 at 20:09 +0100, Otto Sabart wrote:
> >> There is no `samsung,exynos5250-trng.txt` file in the documentation and
> >> I do not think it ever existed.
> >
> > There was a patch for this
> >
> > https://patchwork.kernel.org/patch/10623153/
> >
> > But is is still unapplied...
> >
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> > []
> >> @@ -13309,7 +13309,6 @@ M:   Łukasz Stelmach <l.stelmach@samsung.com>
> >>  L:  linux-samsung-soc@vger.kernel.org
> >>  S:  Maintained
> >>  F:  drivers/char/hw_random/exynos-trng.c
> >> -F:  Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
>
> + Rob Herring

Please resend the above patch. If I've acked it, then I'm assuming
it's going in via the driver tree. But I'll apply it if you tell me to
instead.

Rob

[PATCH v5.1 RESEND] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

[Łukasz Stelmach]

Add binding documentation for the True Random Number Generator
found on Samsung Exynos 5250+ SoCs.

Acked-by: Rob Herring <robh@kernel.org>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
---
 .../bindings/rng/samsung,exynos5250-trng.txt    | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt

diff --git a/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
new file mode 100644
index 000000000000..5a613a4ec780
--- /dev/null
+++ b/Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
@@ -0,0 +1,17 @@
+Exynos True Random Number Generator
+
+Required properties:
+
+- compatible  : Should be "samsung,exynos5250-trng".
+- reg         : Specifies base physical address and size of the registers map.
+- clocks      : Phandle to clock-controller plus clock-specifier pair.
+- clock-names : "secss" as a clock name.
+
+Example:
+
+	rng@10830600 {
+		compatible = "samsung,exynos5250-trng";
+		reg = <0x10830600 0x100>;
+		clocks = <&clock CLK_SSS>;
+		clock-names = "secss";
+	};
-- 
2.20.1

Re: [PATCH v5.1 RESEND] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

[Krzysztof Kozlowski]

On Fri, 11 Jan 2019 at 14:22, Łukasz Stelmach <l.stelmach@samsung.com> wrote:
>
> Add binding documentation for the True Random Number Generator
> found on Samsung Exynos 5250+ SoCs.
>
> Acked-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---

Rob,
Could you apply this directly? You acked this some time ago but it
never went through drivers tree. Lukasz resent this patch and it is
waiting since then.
The driver implementing compatible is already in mainline.

Best regards,
Krzysztof

Re: [PATCH v5.1 RESEND] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

[Andreas Färber]

Hi guys,

Am 26.03.19 um 12:42 schrieb Krzysztof Kozlowski:
> On Fri, 11 Jan 2019 at 14:22, Łukasz Stelmach <l.stelmach@samsung.com> wrote:
>>
>> Add binding documentation for the True Random Number Generator
>> found on Samsung Exynos 5250+ SoCs.
>>
>> Acked-by: Rob Herring <robh@kernel.org>
>> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
>> ---
> 
> Rob,
> Could you apply this directly? You acked this some time ago but it
> never went through drivers tree. Lukasz resent this patch and it is
> waiting since then.
> The driver implementing compatible is already in mainline.

For some reason this text file in linux-next is lonely in devicetree/...
rather than living in Documentation/devicetree/... - please fix that.
The patch here looks correct, so not sure what went wrong:

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/devicetree/bindings/rng/samsung,exynos5250-trng.txt?h=next-20191023&id=85552c22f03c9066c33f26f34538b67fee6a91a8

Thanks,
Andreas

-- 
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)

Re: [PATCH v5.1 RESEND] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

[Herbert Xu]

On Wed, Oct 23, 2019 at 10:16:48AM +0200, Andreas Färber wrote:
>
> For some reason this text file in linux-next is lonely in devicetree/...
> rather than living in Documentation/devicetree/... - please fix that.
> The patch here looks correct, so not sure what went wrong:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/devicetree/bindings/rng/samsung,exynos5250-trng.txt?h=next-20191023&id=85552c22f03c9066c33f26f34538b67fee6a91a8

It's because the patch

	https://patchwork.kernel.org/patch/11181265/

was generated at the wrong level (p0 instead of p1).

I'll fix this up in my tree.  Thanks for the heads up.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt