linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sultan Qasim <sultanqasim@gmail.com>
To: stable@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Mis-backport in af_unix patch for Linux 3.10.95
Date: Sun, 24 Jan 2016 00:10:35 -0500	[thread overview]
Message-ID: <CAJLwaKa3vMzRnTt+JL7msQ33HZk_Jp+xMjOteBYCad46u15hKg@mail.gmail.com> (raw)

Hello all,

I'm an outsider to the Linux kernel community, so I apologize if this
is not the right channel to mention this. I noticed that the
backported version of the patch "af_unix: Revert 'lock_interruptible'
in stream receive code" in Linux 3.10.95 seems to have removed the
mutex_lock_interruptible from the wrong function.

Here is the backported patch:
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=3a57e783016bf43ab9326172217f564941b85b17

Here is the original:
https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/net/unix/af_unix.c?id=3822b5c2fc62e3de8a0f33806ff279fb7df92432

Was it not meant to be removed from unix_stream_recvmsg instead of
unix_dgram_recvmsg? Also, the variable called "noblock" needs to be
removed from the function being changed to prevent unused variable
warnings.

Sultan Q. Khan

             reply	other threads:[~2016-01-24  5:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-24  5:10 Sultan Qasim [this message]
2016-01-24  8:31 ` Mis-backport in af_unix patch for Linux 3.10.95 Willy Tarreau
2016-01-24 16:16   ` Sultan Qasim
2016-01-24 21:40     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJLwaKa3vMzRnTt+JL7msQ33HZk_Jp+xMjOteBYCad46u15hKg@mail.gmail.com \
    --to=sultanqasim@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).