From: Jaesoo Lee <jalee@purestorage.com>
To: nitzanc@mellanox.com
Cc: sagi@grimberg.me, keith.busch@intel.com, axboe@fb.com,
hch@lst.de, Roland Dreier <roland@purestorage.com>,
Prabhath Sajeepa <psajeepa@purestorage.com>,
Ashish Karkare <ashishk@purestorage.com>,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme-rdma: complete requests from ->timeout
Date: Mon, 10 Dec 2018 15:40:16 -0800 [thread overview]
Message-ID: <CAJX3Cti_ZJF5E+NRuRzSeEUgaXsbA2U9C+Rh5OdYd4EMwXC1gw@mail.gmail.com> (raw)
In-Reply-To: <b7b26a7a-70be-d805-ee64-67fba0b4efa8@mellanox.com>
It seems that your patch is addressing the same bug. I will see if
that works for our failure scenarios.
Why don't you make it upstream?
On Sun, Dec 9, 2018 at 6:22 AM Nitzan Carmi <nitzanc@mellanox.com> wrote:
>
> Hi,
> We encountered similar issue.
> I think that the problem is that error_recovery might not even be
> queued, in case we're in DELETING state (or CONNECTING state, for that
> matter), because we cannot move from those states to RESETTING.
>
> We prepared some patches which handle completions in case such scenario
> happens (which, in fact, might happen in numerous error flows).
>
> Does it solve your problem?
> Nitzan.
>
>
> On 30/11/2018 03:30, Sagi Grimberg wrote:
> >
> >> This does not hold at least for NVMe RDMA host driver. An example
> >> scenario
> >> is when the RDMA connection is gone while the controller is being
> >> deleted.
> >> In this case, the nvmf_reg_write32() for sending shutdown admin
> >> command by
> >> the delete_work could be hung forever if the command is not completed by
> >> the timeout handler.
> >
> > If the queue is gone, this means that the queue has already flushed and
> > any commands that were inflight has completed with a flush error
> > completion...
> >
> > Can you describe the scenario that caused this hang? When has the
> > queue became "gone" and when did the shutdown command execute?
> >
> > _______________________________________________
> > Linux-nvme mailing list
> > Linux-nvme@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2018-12-10 23:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 23:59 [PATCH] nvme-rdma: complete requests from ->timeout Jaesoo Lee
2018-11-30 1:30 ` Sagi Grimberg
2018-11-30 1:54 ` Jaesoo Lee
2018-12-07 0:18 ` Jaesoo Lee
2018-12-07 20:05 ` Sagi Grimberg
2018-12-08 2:02 ` Keith Busch
2018-12-08 6:28 ` Jaesoo Lee
2018-12-09 14:22 ` Nitzan Carmi
2018-12-10 23:40 ` Jaesoo Lee [this message]
2018-12-11 9:14 ` Nitzan Carmi
2018-12-11 23:16 ` Jaesoo Lee
2018-12-11 23:38 ` Sagi Grimberg
2018-12-12 1:31 ` Jaesoo Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJX3Cti_ZJF5E+NRuRzSeEUgaXsbA2U9C+Rh5OdYd4EMwXC1gw@mail.gmail.com \
--to=jalee@purestorage.com \
--cc=ashishk@purestorage.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nitzanc@mellanox.com \
--cc=psajeepa@purestorage.com \
--cc=roland@purestorage.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).